Koha/cataloguing/value_builder/marc21_field_007.pl
Marcel de Rooy 0d177c9546 Bug 10480: Remove useless routines and irrelevant pod lines
This patch makes the following cleanup actions for all plugins:

1- Remove sub plugin_parameters. This function is not used.
2- Remove empty plugin or empty plugin_javascript subs.
3- Remove empty Blur, Clic or Focus routines from javascript.
4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs.
5- Remove the last 1; line. It is no longer needed.

Test plan:
Run the unit test t/db_dependent/FrameworkPlugins.t
Test some cataloguing plugins in addbiblio.
Test some item plugins in additem and neworderempty.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I also checked the syntax of all plugins with perl -c.
And checked the pod (if any) with podchecker: Two files still produce a
warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2015-04-16 14:48:40 -03:00

149 lines
4.1 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright 2000-2002 Katipo Communications
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
use strict;
#use warnings; FIXME - Bug 2505
use C4::Auth;
use CGI qw ( -utf8 );
use C4::Context;
use C4::Search;
use C4::Output;
=head1 DESCRIPTION
plugin_parameters : other parameters added when the plugin is called by the dopop function
=cut
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my $function_name= $field_number;
my $res="
<script type=\"text/javascript\">
//<![CDATA[
function Clic$function_name(i) {
defaultvalue=document.getElementById(\"$field_number\").value;
newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=marc21_field_007.pl&index=$field_number&result=\"+defaultvalue,\"tag_editor\",'width=1000,height=600,toolbar=false,scrollbars=yes');
}
//]]>
</script>
";
return ($function_name,$res);
}
sub plugin {
my ($input) = @_;
my $index= $input->param('index');
my $result= $input->param('result');
my $dbh = C4::Context->dbh;
my ($template, $loggedinuser, $cookie)
= get_template_and_user({template_name => "cataloguing/value_builder/marc21_field_007.tt",
query => $input,
type => "intranet",
authnotrequired => 0,
flagsrequired => {editcatalogue => '*'},
debug => 1,
});
$result = "ta" unless $result;
my $f0 = substr($result,0,1);
my $f1 = substr($result,1,1);
#added new parameters to allow for all material types
my $f2 = substr($result,2,1);
my $f3 = substr($result,3,1);
my $f4 = substr($result,4,1);
my $f5 = substr($result,5,1);
my $f6 = substr($result,6,1);
my $f7 = substr($result,7,1);
my $f8 = substr($result,8,1);
my $f9 = substr($result,9,1);
my $f10 = substr($result,10,1);
my $f11 = substr($result,11,1);
my $f12 = substr($result,12,1);
my $f13 = substr($result,13,1);
my $f14 = substr($result,14,1);
my $f15 = substr($result,15,1);
my $f16 = substr($result,16,1);
my $f17 = substr($result,17,1);
my $f18 = substr($result,18,1);
my $f19 = substr($result,19,1);
my $f20 = substr($result,20,1);
my $f21 = substr($result,21,1);
my $f22 = substr($result,22,1);
#FIXME: There is probably a more-elegant way to do this!
#FIXME: Two of the material types treat position 06, 07, and 08 as a single
#three-char field. This script works fine for creating values and sending them
#back to the MARC, but if there is already a value in the 007, it won't send
#it properly to the value builder for those two instances. Not sure how to solve.
$template->param( index => $index,
f0 => $f0,
"f0$f0" => $f0,
f1 => $f1,
"f1$f1" => $f1,
f2 => $f2,
"f2$f2" => $f2,
f3 => $f3,
"f3$f3" => $f3,
f4 => $f4,
"f4$f4" => $f4,
f5 => $f5,
"f5$f5" => $f5,
f6 => $f6,
"f6$f6" => $f6,
f7 => $f7,
"f7$f7" => $f7,
f8 => $f8,
"f8$f8" => $f8,
f9 => $f9,
"f9$f9" => $f9,
f10 => $f10,
"f10$f10" => $f10,
f11 => $f11,
"f11$f11" => $f11,
f12 => $f12,
"f12$f12" => $f12,
f13 => $f13,
"f13$f13" => $f13,
f14 => $f14,
"f14$f14" => $f14,
f15 => $f15,
"f15$f15" => $f15,
f16 => $f16,
"f16$f16" => $f16,
f17 => $f17,
"f17$f17" => $f17,
f18 => $f18,
"f18$f18" => $f18,
f19 => $f19,
"f19$f19" => $f19,
f20 => $f20,
"f20$f20" => $f20,
f21 => $f21,
"f21$f21" => $f21,
f22 => $f22,
"f22$f22" => $f22,
);
output_html_with_http_headers $input, $cookie, $template->output;
}