Koha/koha-tmpl/intranet-tmpl/prog/en
Martin Renvoize 0d19d9fa44 Bug 22393: Remove last remaining use of C4::Accounts::manualinvoice
This patch re-arranges the manualinvoice controller script to clarify
code flow, replaces the last call to C4::Accounts::manualinvoice with a
call to Koha::Accounts->add_debit wrapped in a try catch block and also
adds a check on passed barcodes when the invoice type is 'LOST' so it
can link the subsequently created accountline to the item and issue.

Test plan
1/ Add a manual invoice (without entering a barcode)
2/ Add a manual invoice with a valid barcode (Not a LOST type)
3/ Add a manual invoice with a valid, but old, barcode (Not a LOST type)
4/ Add a manual invoice with an invalid barcode, note that an error is
displayed
5/ Add a manual invoice with type 'LOST' and a valid barcode for a
checkout your user has had checked out
6/ Add a manual invoice with type 'LOST' and a valid barcode, but not
one that will match a checkout for your user. Note an error is displayed
7/ When errors are displayed, note the form contains data from the
previous submission so you can just correct the error rather than
re-enter all data.
8/ Signoff

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-08-18 17:39:48 +02:00
..
data Bug 24312: Update MARC21 frameworks to Updates 28+29 (May and November 2019) 2020-01-07 15:10:45 +00:00
includes Bug 25867: Label "Current location" as "Current library" and "Permanent location" as "Home library" 2020-08-18 15:48:37 +02:00
modules Bug 22393: Remove last remaining use of C4::Accounts::manualinvoice 2020-08-18 17:39:48 +02:00
xslt Bug 17853: Don't remove () from 780 link text 2020-05-11 10:02:18 +01:00
columns.def Bug 14570: Make it possible to add multiple guarantors to a record 2019-08-20 16:04:48 +01:00