b168f4a2e9
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
37 lines
1.1 KiB
Perl
Executable file
37 lines
1.1 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
# This script finds and fixes missing biblionumber/biblioitemnumber fields in Koha
|
|
# Written by TG on 01/10/2005
|
|
# Revised by Joshua Ferraro on 03/31/2006
|
|
use strict;
|
|
use warnings;
|
|
BEGIN {
|
|
# find Koha's Perl modules
|
|
# test carefully before changing this
|
|
use FindBin;
|
|
eval { require "$FindBin::Bin/kohalib.pl" };
|
|
}
|
|
|
|
# Koha modules used
|
|
use Koha::Script;
|
|
use C4::Context;
|
|
use C4::Biblio;
|
|
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my $sth=$dbh->prepare("SELECT biblio.biblionumber, biblioitemnumber, frameworkcode FROM biblio JOIN biblioitems USING (biblionumber)");
|
|
$sth->execute();
|
|
|
|
while (my ($biblionumber,$biblioitemnumber,$frameworkcode)=$sth->fetchrow ){
|
|
my $record = GetMarcBiblio({ biblionumber => $biblionumber });
|
|
C4::Biblio::_koha_marc_update_bib_ids($record, $frameworkcode, $biblionumber, $biblioitemnumber);
|
|
my $biblionumber = eval {ModBiblioMarc( $record, $biblionumber, $frameworkcode )};
|
|
if($@){
|
|
print "Problem with biblionumber : $biblionumber\n";
|
|
exit -1;
|
|
}else{
|
|
print "biblionumber : $biblionumber\r\r";
|
|
}
|
|
}
|
|
|
|
END;
|