Martin Renvoize 0e9603bb49 Bug 34764: Set fee_acknowledged to expect a string ... For consistency with other options I opted to have the fee acknowledged parameter to expect a string and as it's an optional parameter I've dropped the default value of 'N' too. Test plan 1) Prior to this patch 1a) Attempt a checkout without passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 --item 39999000007756 -m checkout` The final field of the SIP request will be '|BON', the default 1b) Attempt a checkout passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged --patron 23529000035676 --item 39999000007756 -m checkout` The final field of the SIP request will still be '|BON', failure 1c) Attempt a checkout passing a string for fee_acknoewledeged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 23529000035676 --item 39999000007756 -m checkout` The final field of the SIP request will still be '|BON', failure 2) Apply the patch 2a) Attempt a checkout without passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 --item 39999000007756 -m checkout` The optional `|BO` element should not be present 2b) Attempt a checkout passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged N --patron 23529000035676 --item 39999000007756 -m checkout` The final field of the SIP request will now be '|BON', success 2c) Attempt a checkout passing a string for fee_acknoewledeged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 23529000035676 --item 39999000007756 -m checkout` The final field of the SIP request will now be '|BOY', success Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>		2023-09-15 11:57:10 -03:00
..
admin
bin
cronjobs	Bug 28995: Update aliases	2023-09-08 11:54:55 -03:00
devel
interface_customization
maintenance	Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons	2023-08-29 14:59:08 -03:00
migration_tools	Bug 32800: Don't embed items for deleted records	2023-04-12 09:26:50 -03:00
release_notes	Amend release team	2023-05-31 21:09:08 -03:00
search_tools
translator	Translation fixes	2023-05-31 16:10:07 -03:00
workers	Bug 34470: Initialize random seed after spawning a child worker process	2023-08-15 11:25:48 +03:00
add_date_fields_to_marc_records.pl	Bug 23924: Reset the fields to add	2023-05-05 12:13:53 -03:00
add_statistics_borrowers_categorycode.pl	Bug 32922: Remove space in shebang	2023-02-20 09:44:06 -03:00
batchCompareMARCvsFrameworks.pl
batchdeletebiblios.pl
batchDeleteUnusedSubfields.pl
batchImportMARCWithBiblionumbers.pl
batchRebuildBiblioTables.pl
batchRebuildItemsTables.pl
batchRepairMissingBiblionumbers.pl
check_sysprefs.pl
commit_file.pl	Bug 15869: Change framework on overlay	2023-02-07 10:32:22 -03:00
export_borrowers.pl
export_records.pl
exportauth.pl
import_patrons.pl	Bug 34213: import_patrons.pl - Fix short version of matchpoint option in POD	2023-07-21 17:14:40 -03:00
koha-install-log
link_bibs_to_authorities.pl	Bug 32250: (follow-up) Remove use of AutoCommit=0	2023-05-05 09:13:23 -03:00
load_yaml.pl
mod_zebraqueue.pl
perlmodule_ls.pl
perlmodule_rm.pl	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
process_ill_updates.pl
recreateIssueStatistics.pl	Bug 30275: Rename issues.renewals to issues.renewals_count	2022-07-05 09:45:55 -03:00
sax_parser_print.pl
sax_parser_test.pl
sip_cli_emulator.pl	Bug 34764: Set fee_acknowledged to expect a string	2023-09-15 11:57:10 -03:00
stage_file.pl
z3950_responder.pl