Nick Clemens bbeab36789 Bug 34678: Allow new entries to overwrite hold_fill_targets ... When using background jobs, there is a possibility of a race condition where two jobs will be updating the holds queue for the same biblio. We should try to minimize those cases (see bug 34596) In the meantime though, we should prevent jobs possibly dying, and allow the most recent update to succeed. There is a possibility two updates wil assign different items to the same reserve, and that a reserve could end up in the queue twice, however, whichever one is filled first will delete both entries. as filling the hold deletes by reserve id (see bug 24359) This patch adds a transaction to delete and then inset the new row To test: 1 - prove -v t/db_dependent/Reserves.t 2 - It fails 3 - Apply patch 4 - t/db_dependent/Reserves.t 5 - It succeeds! Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>		2023-10-27 16:44:24 -03:00
..
AuthoritiesMarc
Barcodes
ClassSortRoutine
ClassSplitRoutine	Bug 28572: Remove C4::Debug	2021-06-22 12:04:32 +02:00
Creators	Bug 10762: (QA follow-up) Perltidy	2023-10-25 10:35:31 -03:00
External
Form
Heading	Bug 21828: build $bib_heading_fields only once per invocation	2023-09-22 12:57:46 -03:00
ILSDI	Bug 15504: (follow-up) Migrate to one clear method	2023-10-24 10:05:15 -03:00
Installer	Bug 30731: Remove Readonly::XS::MAGIC_COOKIE	2022-06-01 16:15:26 -03:00
Labels	Bug 10762: (QA follow-up) Perltidy	2023-10-25 10:35:31 -03:00
Linker
Members	Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name	2023-10-11 10:31:46 -03:00
OAI
Output
Patroncards	Bug 34532: Silence warns in Patroncard.pm	2023-09-15 11:57:08 -03:00
Reports
Search
Serials
SIP	Bug 15504: Remove PatronLastActivity preference	2023-10-24 10:05:22 -03:00
Utils
Accounts.pm
Acquisition.pm	Bug 14092: (QA follow-up) Avoid fiddling with the hash in the template	2023-10-20 16:31:15 -03:00
Auth.pm	Bug 15504: (follow-up) Migrate to one clear method	2023-10-24 10:05:15 -03:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm
Auth_with_ldap.pm	Bug 34731: Don't call SendQueuedMessages if message_id is bad	2023-09-12 09:44:59 -03:00
Auth_with_shibboleth.pm	Bug 34731: Don't call SendQueuedMessages if message_id is bad	2023-09-12 09:44:59 -03:00
AuthoritiesMarc.pm
Barcodes.pm
Biblio.pm	Bug 34014: (follow-up) Tidy	2023-10-20 11:03:00 -03:00
Breeding.pm	Bug 28166: (QA follow-up) Fix and tidy tests and code	2023-10-23 11:33:50 -03:00
Budgets.pm	Bug 31631: Optionally use tax-exclusive values for calculating fund values	2023-10-18 15:41:35 -03:00
Calendar.pm	Bug 32048: Added clear cache routine to delete_holiday_range_repeatable	2023-09-18 15:31:50 -03:00
Charset.pm
Circulation.pm	Bug 15504: (follow-up) Migrate to one clear method	2023-10-24 10:05:15 -03:00
ClassSortRoutine.pm	Bug 29951: Fix EXPORT for C4::ClassS*Routine modules	2022-07-08 15:29:56 -03:00
ClassSource.pm
ClassSplitRoutine.pm	Bug 29951: Fix EXPORT for C4::ClassS*Routine modules	2022-07-08 15:29:56 -03:00
Context.pm	Bug 29033: Add C4::Context->multivalue_preference	2023-10-10 10:53:59 -03:00
Contract.pm
CourseReserves.pm	Bug 30016: Remove GetOpenIssue subroutine	2022-08-31 08:50:37 -03:00
Creators.pm
Heading.pm
HoldsQueue.pm	Bug 34678: Allow new entries to overwrite hold_fill_targets	2023-10-27 16:44:24 -03:00
HTML5Media.pm
ImportBatch.pm	Bug 34822: Process real time holds along with indexing	2023-10-04 09:15:38 -04:00
ImportExportFramework.pm
InstallAuth.pm	Bug 26019: Koha should set SameSite attribute on cookies	2022-04-13 15:55:38 +02:00
Installer.pm
ItemCirculationAlertPreference.pm	Bug 29844: Fix ->search occurrences	2022-02-09 15:36:23 -10:00
Items.pm	Bug 34656: Do not update real Time Holds Queue when moving from cart to shelf	2023-09-15 11:57:13 -03:00
Koha.pm	Bug 34828: Fix test	2023-10-10 09:22:37 -03:00
Labels.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Languages.pm
Letters.pm	Bug 33547: Add print slip	2023-10-23 11:33:51 -03:00
Linker.pm
Log.pm
MarcModificationTemplates.pm
Matcher.pm
Members.pm	Bug 31383: Create a parent-child DB relation for additional content	2023-10-20 14:43:56 -03:00
Message.pm
Output.pm
Overdues.pm
Patroncards.pm	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Record.pm	Bug 33045: Use process_tt in C4::Record::marcrecord2csv	2023-09-15 11:57:16 -03:00
Reports.pm	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Reserves.pm	Bug 8838: Add digest option for HOLD notice	2023-10-25 11:07:48 -03:00
Ris.pm
RotatingCollections.pm
Scheduler.pm
Scrubber.pm	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Search.pm
Serials.pm	Bug 31846: (QA follow-up) Tidy code to make qa script happy	2023-10-25 10:35:28 -03:00
Service.pm
ShelfBrowser.pm
SMS.pm	Bug 27673: Replace YAML with YAML::XS	2021-02-16 14:54:50 +01:00
SocialData.pm	Bug 33833: Add two FIXMEs to SocialData::get_report	2023-09-05 14:35:35 -03:00
Stats.pm	Bug 33608: (QA follow-up) Remove ->insert method	2023-10-25 11:07:59 -03:00
Suggestions.pm
Tags.pm
Templates.pm	Bug 31390: Remove noisy warns in C4::Templates	2022-08-22 13:25:00 -03:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm
UsageStats.pm
XISBN.pm
XSLT.pm	Bug 26314: Update for changes to bug 11175 methodology	2023-10-17 14:45:13 -03:00