0f4a831344
Bug 7447 introduces the --date option for overdue notices. This option has never worked: the code is waiting for a value but the option is defined as a boolean. This patch fixes the option and change the way to calculate the range of dates. This range is now managed in Perl instead of in the SQL query. To do it in Perl allows to build dates simply using the DateTime and DateTime::Duration modules. To test this patch you should have a DB with a lot of overdues, (I tested on a DB with 512 overdues). A test plan could be: 1/ Dump your message_queue table 2/ Verify the number of overdues in the database before applying the patch: mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v -t (the triggered option will generate overdue for today) mysql> SELECT COUNT(*) FROM message_queue; Note this value 2A mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v mysql> SELECT COUNT(*) FROM message_queue; Note this value 2B 2/ Apply the patch 4/ Verify the number of overdues generated by the patched script: mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v -t mysql> SELECT COUNT(*) FROM message_queue; Note this value 4A mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v mysql> SELECT COUNT(*) FROM message_queue; Note this value 4B mysql> DELETE FROM message_queue; # The date should be defined depending your dateformat preference # and should be the date of the current day perl misc/cronjobs/overdue_notices.pl -v -t --date="YYYY-MM-DD" mysql> SELECT COUNT(*) FROM message_queue; Note this value 4C mysql> DELETE FROM message_queue; # The date should be defined depending your dateformat preference # and should be the date of the current day perl misc/cronjobs/overdue_notices.pl -v --date="YYYY-MM-DD" mysql> SELECT COUNT(*) FROM message_queue; Note this value 4D 5/ Compare the values: All values generated with the -t options should be equals. Same for values without the -t options. => 2A == 4A == 4C and 2B == 4B == 4D 6/ Go back to a normal activity for 3 days or manually change the date_due for issues in the DB: mysql> update issues SET date_due = DATE_SUB(date_due, INTERVAL 3 DAY); Do again step 4C and 4D with a date equals to today - 3 days. Values should be the same as 4C and 4D. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with my own test data, checked generating overdues with and without the --date option. All worked as expected. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> |
||
|---|---|---|
| .. | ||
| holds | ||
| rss | ||
| social_data | ||
| thirdparty | ||
| advance_notices.pl | ||
| automatic_renewals.pl | ||
| backup.sh | ||
| batch_anonymise.pl | ||
| build_browser_and_cloud.pl | ||
| cart_to_shelf.pl | ||
| check-url-quick.pl | ||
| check-url.pl | ||
| cleanup_database.pl | ||
| cloud-kw.pl | ||
| cloud-sample.conf | ||
| CONFIGURE.gmail | ||
| create_koc_db.pl | ||
| crontab.example | ||
| delete_expired_opac_registrations.pl | ||
| delete_patrons.pl | ||
| delete_unverified_opac_registrations.pl | ||
| fines.pl | ||
| gather_print_notices.pl | ||
| import_webservice_batch.pl | ||
| j2a.pl | ||
| longoverdue.pl | ||
| MARC21_parse_test.pl | ||
| nl-sync-from-koha.pl | ||
| nl-sync-to-koha.pl | ||
| overdue_notices.pl | ||
| printoverdues.sh | ||
| process_message_queue.pl | ||
| purge_suggestions.pl | ||
| runreport.pl | ||
| serialsUpdate.pl | ||
| services_throttle.pl | ||
| share_usage_with_koha_community.pl | ||
| staticfines.pl | ||
| update_totalissues.pl | ||