b168f4a2e9
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
146 lines
6.3 KiB
Perl
Executable file
146 lines
6.3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
#
|
|
# Copyright 2009 Foundations Bible College.
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use autouse 'Data::Dumper' => qw(Dumper);
|
|
|
|
use C4::Auth qw(get_template_and_user);
|
|
use C4::Output qw(output_html_with_http_headers);
|
|
use C4::Creators;
|
|
use C4::Patroncards;
|
|
|
|
my $cgi = new CGI;
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "patroncards/print.tt",
|
|
query => $cgi,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { catalogue => 1 },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $op = $cgi->param('op') || 'none';
|
|
my @label_ids = $cgi->multi_param('label_id'); # this will handle individual card printing; we use label_id to maintain consistency with the column names in the creator_batches table
|
|
my @batch_ids = $cgi->multi_param('batch_id');
|
|
my $patronlist_id = $cgi->param('patronlist_id') || undef;
|
|
my $layout_id = $cgi->param('layout_id') || undef;
|
|
my $layout_back_id = $cgi->param('layout_back_id') || undef;
|
|
my $template_id = $cgi->param('template_id') || undef;
|
|
my $start_card = $cgi->param('start_card') || 1;
|
|
my @borrower_numbers = $cgi->multi_param('borrower_number');
|
|
my $output_format = $cgi->param('output_format') || 'pdf';
|
|
my $referer = $cgi->param('referer') || undef;
|
|
|
|
my $layouts = undef;
|
|
my $templates = undef;
|
|
my $output_formats = undef;
|
|
my @batches = ();
|
|
my $multi_batch_count = scalar(@batch_ids);
|
|
my $card_count = scalar(@label_ids);
|
|
my $borrower_count = scalar(@borrower_numbers);
|
|
|
|
if ($op eq 'export') {
|
|
if (@label_ids) {
|
|
my $label_id_param = '&label_id=';
|
|
$label_id_param .= join ('&label_id=',@label_ids);
|
|
push (@batches, {create_script => ($output_format eq 'pdf' ? 'create-pdf.pl' : 'create-csv.pl'),
|
|
batch_id => $batch_ids[0],
|
|
template_id => $template_id,
|
|
layout_id => $layout_id,
|
|
layout_back_id => $layout_back_id,
|
|
start_card => $start_card,
|
|
label_ids => $label_id_param,
|
|
card_count => scalar(@label_ids),
|
|
});
|
|
$template->param(
|
|
batches => \@batches,
|
|
referer => $referer,
|
|
);
|
|
}
|
|
elsif (@borrower_numbers) {
|
|
my $borrower_number_param = '&borrower_number=';
|
|
$borrower_number_param .= join ('&borrower_number=',@borrower_numbers);
|
|
push (@batches, {create_script => ($output_format eq 'pdf' ? 'create-pdf.pl' : 'create-csv.pl'),
|
|
template_id => $template_id,
|
|
layout_id => $layout_id,
|
|
layout_back_id => $layout_back_id,
|
|
start_card => $start_card,
|
|
borrower_numbers => $borrower_number_param,
|
|
card_count => scalar(@borrower_numbers),
|
|
});
|
|
$template->param(
|
|
batches => \@batches,
|
|
referer => $referer,
|
|
);
|
|
}
|
|
elsif (@batch_ids) {
|
|
foreach my $batch_id (@batch_ids) {
|
|
push (@batches, {create_script => ($output_format eq 'pdf' ? 'create-pdf.pl' : 'create-csv.pl'),
|
|
batch_id => $batch_id,
|
|
template_id => $template_id,
|
|
layout_id => $layout_id,
|
|
layout_back_id => $layout_back_id,
|
|
start_card => $start_card,
|
|
});
|
|
}
|
|
$template->param(
|
|
batches => \@batches,
|
|
referer => $referer,
|
|
);
|
|
}
|
|
elsif ($patronlist_id ) {
|
|
$template->param(
|
|
patronlist_id => $patronlist_id,
|
|
template_id => $template_id,
|
|
layout_id => $layout_id,
|
|
layout_back_id => $layout_back_id,
|
|
start_card => $start_card,
|
|
referer => $referer,
|
|
);
|
|
}
|
|
}
|
|
elsif ($op eq 'none') {
|
|
# setup select menus for selecting layout and template for this run...
|
|
$referer = $ENV{'HTTP_REFERER'};
|
|
$referer =~ s/^.*?:\/\/.*?(\/.*)$/$1/m;
|
|
@batch_ids = map { {batch_id => $_} } @batch_ids;
|
|
@label_ids = map { {label_id => $_} } @label_ids;
|
|
@borrower_numbers = map { {borrower_number => $_} } @borrower_numbers;
|
|
$templates = get_all_templates( { fields => [qw( template_id template_code ) ], filters => { creator => "Patroncards" } });
|
|
$layouts = get_all_layouts({ fields => [ qw( layout_id layout_name ) ], filters => { creator => "Patroncards" } });
|
|
$output_formats = get_output_formats();
|
|
$template->param(
|
|
batch_ids => \@batch_ids,
|
|
label_ids => \@label_ids,
|
|
borrower_numbers => \@borrower_numbers,
|
|
patronlist_id => $patronlist_id,
|
|
templates => $templates,
|
|
layouts => $layouts,
|
|
output_formats => $output_formats,
|
|
multi_batch_count => $multi_batch_count,
|
|
card_count => $card_count,
|
|
borrower_count => $borrower_count,
|
|
referer => $referer,
|
|
);
|
|
}
|
|
output_html_with_http_headers $cgi, $cookie, $template->output;
|