a9b564678e
Test plan: 1) set an empty string for the ReservesMaxPickUpDelay pref 2) place a hold on an item 3) check in the item 4) click on "Print and confirm" 5) an error occurs > The 'days' parameter (undef) to DateTime::Duration::new was an 'undef' 6) apply the patch 7) repeat steps 1 to 4 8) the error does not occur anymore. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> An empty string didn't do it for me, I had to set the variable for the systempreference to NULL. I am not sure if this can happen when editing from the interface, but this change should not have any ill side effects and it has unit tests! Signed-off-by: Galen Charlton <gmc@esilibrary.com>
44 lines
1.3 KiB
Perl
Executable file
44 lines
1.3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
#
|
|
# This Koha test module is a stub!
|
|
# Add more tests here!!!
|
|
|
|
use Modern::Perl;
|
|
use DBI;
|
|
use Test::MockModule;
|
|
use Test::More tests => 4;
|
|
use t::lib::Mocks;
|
|
my $module = new Test::MockModule('C4::Context');
|
|
$module->mock(
|
|
'_new_dbh',
|
|
sub {
|
|
my $dbh = DBI->connect( 'DBI:Mock:', '', '' )
|
|
|| die "Cannot create handle: $DBI::errstr\n";
|
|
return $dbh;
|
|
}
|
|
);
|
|
my $mock_letters = [
|
|
[ 'module', 'code', 'branchcode', 'name', 'is_html', 'title', 'content' ],
|
|
[ 'blah', 'ISBN', 'NBSI', 'book', 1, 'green', 'blahblah' ],
|
|
[ 'bleh', 'ISSN', 'NSSI', 'page', 0, 'blue', 'blehbleh' ]
|
|
];
|
|
|
|
use_ok('C4::Letters');
|
|
|
|
my $dbh = C4::Context->dbh();
|
|
|
|
$dbh->{mock_add_resultset} = $mock_letters;
|
|
|
|
my $letters = C4::Letters::GetLetters();
|
|
|
|
is( $letters->{ISBN}, 'book', 'HASH ref of ISBN is book' );
|
|
|
|
# Regression test for bug 10843
|
|
# $dt->add takes a scalar, not undef
|
|
my $letter;
|
|
t::lib::Mocks::mock_preference('ReservesMaxPickUpDelay', undef);
|
|
$letter = C4::Letters::_parseletter( undef, 'reserves', {waitingdate => "2013-01-01"} );
|
|
is( ref($letter), 'HASH');
|
|
t::lib::Mocks::mock_preference('ReservesMaxPickUpDelay', 1);
|
|
$letter = C4::Letters::_parseletter( undef, 'reserves', {waitingdate => "2013-01-01"} );
|
|
is( ref($letter), 'HASH');
|