dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
97 lines
5.2 KiB
Text
97 lines
5.2 KiB
Text
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Web installer ›
|
|
[% UNLESS ( language ) %] Choose your language [% END %]
|
|
[% IF ( language ) %]
|
|
[% UNLESS ( checkmodule ) %]
|
|
[% IF ( missing_modules ) %]
|
|
Perl modules missing
|
|
[% END %]
|
|
[% IF ( problems ) %]
|
|
Perl version obsolete
|
|
[% END %]
|
|
[% END %]
|
|
Check Perl dependencies
|
|
[% END %]
|
|
</title>
|
|
[% INCLUDE 'installer-doc-head-close.inc' %]
|
|
|
|
<div class="container-fluid">
|
|
<div class="row">
|
|
<div id="installer-step1" class="installer-main col-sm-8 col-sm-offset-2 col-md-8 col-md-offset-2">
|
|
|
|
<h1 id="logo"><a href="#">Koha</a></h1>
|
|
|
|
[% UNLESS ( language ) %]
|
|
<h2>Web installer › Choose your language</h2>
|
|
<p>You are about to install Koha.</p>
|
|
|
|
<p>Please pick your language from the following list. If your language is not listed, please inform your system administrator.</p>
|
|
|
|
<form name="language" method="post" action="install.pl">
|
|
<div class="form-group">
|
|
<label for="language">Select a language: </label>
|
|
<select id="language" name="language">
|
|
[% IF ( installer_languages_loop ) %]
|
|
[% FOREACH installer_languages_loo IN installer_languages_loop %]
|
|
[% IF ( installer_languages_loo.plural ) %]
|
|
<optgroup label="[% installer_languages_loo.language | html %]">
|
|
[% FOREACH sublanguages_loo IN installer_languages_loo.sublanguages_loop %]
|
|
<option value="[% sublanguages_loo.rfc4646_subtag | html %]">[% IF ( sublanguages_loo.native_description ) %][% sublanguages_loo.native_description | html %][% ELSE %][% sublanguages_loo.rfc4646_subtag | html %][% END %]</option>
|
|
[% END %]
|
|
</optgroup>
|
|
[% ELSE %]
|
|
<option value="[% installer_languages_loo.rfc4646_subtag | html %]">[% IF ( installer_languages_loo.native_description ) %][% installer_languages_loo.native_description | html %][% ELSE %][% installer_languages_loo.rfc4646_subtag | html %][% END %]</option>
|
|
[% END %]
|
|
[% END %]
|
|
[% END %]
|
|
</select>
|
|
</div>
|
|
<p><input value="Continue to the next step" class="btn btn-primary" type="submit" /></p>
|
|
</form>
|
|
[% END %]
|
|
|
|
[% IF ( language ) %]
|
|
[% UNLESS ( checkmodule ) %]
|
|
[% IF ( missing_modules ) %]
|
|
<h2>Web installer › Perl modules missing</h2>
|
|
<p>Some Perl modules are missing. <span class="label label-danger">Important: </span>Required modules must be installed before you may continue.<br />
|
|
<ul>
|
|
[% FOREACH missing_module IN missing_modules %]
|
|
<li><strong>[% missing_module.name | html %]</strong> [% IF ( missing_module.require ) %]<span class="label label-danger">Required</span>[% END %]
|
|
<br /> Version: [% missing_module.version | html %]
|
|
<br /> Usage: [% missing_module.usage | html %]
|
|
</li>
|
|
[% END %]
|
|
</ul>
|
|
[% END %]
|
|
|
|
[% IF ( problems ) %]
|
|
<h2>Web installer › Perl version too old</h2>
|
|
<p>I encountered some problems.</p>
|
|
<ul>
|
|
[% IF ( perlversion ) %]
|
|
<li>Your Perl version is out of date. Please upgrade to a newer version of Perl (at least version 5.10).</li>
|
|
[% END %]
|
|
</ul>
|
|
[% END %]
|
|
|
|
<form name="checkmodules" action="install.pl">
|
|
<input type="hidden" name="step" value="1" />
|
|
<p> <input value="Recheck dependencies" class="btn btn-primary" type="submit" /></p>
|
|
</form>
|
|
|
|
[% ELSE # IF checkmodule %]
|
|
<h2>Web installer › Check Perl dependencies</h2>
|
|
<p>All required Perl modules appear to be installed.</p>
|
|
<p> All dependencies installed.</p>
|
|
|
|
<form name="checkmodules" role="form" action="install.pl">
|
|
<input type="hidden" name="step" value="2" />
|
|
<p> <input value="Continue to the next step" class="btn btn-primary" type="submit" /> </p>
|
|
</form>
|
|
[% END # IF checkmodule%]
|
|
[% END # IF language %]
|
|
</div> <!-- / #installer-step1 -->
|
|
</div> <!-- / .row -->
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|