Koha-community/Koha: Main Koha release repository - Koha - Koha: The world's first free and open source library system

Main Koha release repository https://koha-community.org

Tree: 11049f9d02

History

Jonathan Druart 24d6d83ada Bug 9811: Patron search improvement This patch add DataTables using server-side processing for the patrons search. It adds: - 1 module C4/Utils/DataTables/Members.pm - 2 services svc/members/search and svc/members/add_to_list - 1 template members/tables/members_results.tt - 1 new practice which is to add template for DataTables in a subdirectory named 'tables'. Impacted scripts: members/members-home.pl and members/members.pl To go further: We can imagine that all patrons searches use the same service with no big changes: 1 little template creates a JSON file and to implement DataTables on the template page, that's all. Amended patch: Since bug 10565 has been pushed, these patches don't apply cleanly. I had to rewrite a part of the patron list feature. I removed the choice to add all resultant patrons from a search. I think this choice is useless with this patch: we are able to display the number of patrons we want and to select all of them. Test plan: - Check that there is no regression on searching patrons. - Try filters on the left of the screen. - Try to sort each column. - Try the "Browse by last name" links. - Check that the "Clear" button clears yours filters. - Try with IndependantBranches ON and OFF. - Verify this feature does not break the patron list feature (cf bug 10565). Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, couldn't find any regressions or problems. Some notes left on the bug. Bug 9811: Add unit tests for C4::Utils::DT::Members Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Bug 9811: QA followup - removes 2 tabs - removes mysqlisms - add sort on borrowernotes - fix wrong capitalization - cat => Category Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Thx for fixing these! Bug 9811 - multilines notes brakes JSON In new patron search feature, the search results are fetched using Ajax and returned in JSON format. The JSON is created by TT using koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt. One of the fields is the borrower notes. When this notes contains several lines, the JSON is broken. This patch uses TT fileters to consert in notes linefeeds into HTML line break (html_line_break) and then remove linefeeds (collapse). Test plan : - perform a member search that does not return a borrower with a circ note - edit one of the borrowers returned by this search - enter serveral lines of text in "Circulation note" and save - reperform the member search => circ note is well displayed on several lines Bug 9811: use count(primary_key) instead of count(*) Bug 9811: A limit clause should be always added. By default, we want to retrieve 20 first results. Bug 9811: Load the page without any data. Displaying the first 20 patrons is not useful. With this patch, the table is hidden and no record is retrieved by default. On the same way, the existing side effect on redirect disappears. Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> ------------- -TEST REPORT- ------------- For the filter: Tested all the search fields, branches, search type. Found a bug with "date of birth", followup provided. Tested display limits and verified that AJAX-queries are efficient (using LIMIT clause) to not stress DB needlessly. Tested adding Patrons to a list. A good feature, which seems to work quite well. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Adding my test plan to the last patch of this bug. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	11 years ago
..
Members.t	Bug 9811: Patron search improvement	10 years ago

Jonathan Druart 24d6d83ada Bug 9811: Patron search improvement

This patch add DataTables using server-side processing for the patrons
search.

It adds:
- 1 module C4/Utils/DataTables/Members.pm
- 2 services svc/members/search and svc/members/add_to_list
- 1 template members/tables/members_results.tt
- 1 new practice which is to add template for DataTables in a
subdirectory named 'tables'.

Impacted scripts: members/members-home.pl and members/members.pl

To go further: We can imagine that all patrons searches use the same
service with no big changes: 1 little template creates a JSON file and
to implement DataTables on the template page, that's all.

Amended patch: Since bug 10565 has been pushed, these patches don't
apply cleanly. I had to rewrite a part of the patron list feature.
I removed the choice to add all resultant patrons from a search. I think
this choice is useless with this patch: we are able to display the
number of patrons we want and to select all of them.

Test plan:
- Check that there is no regression on searching patrons.
- Try filters on the left of the screen.
- Try to sort each column.
- Try the "Browse by last name" links.
- Check that the "Clear" button clears yours filters.
- Try with IndependantBranches ON and OFF.
- Verify this feature does not break the patron list feature (cf bug
10565).

Signed-off-by: Cedric Vita <cedric.vita@dracenie.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script, couldn't find any regressions
or problems. Some notes left on the bug.

Bug 9811: Add unit tests for C4::Utils::DT::Members

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>

Bug 9811: QA followup

- removes 2 tabs
- removes mysqlisms
- add sort on borrowernotes
- fix wrong capitalization
- cat => Category

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Thx for fixing these!

Bug 9811 - multilines notes brakes JSON

In new patron search feature, the search results are fetched using Ajax and returned in JSON format.
The JSON is created by TT using koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt.
One of the fields is the borrower notes. When this notes contains several lines, the JSON is broken.

This patch uses TT fileters to consert in notes linefeeds into HTML line break (html_line_break) and then remove linefeeds (collapse).

Test plan :
- perform a member search that does not return a borrower with a circ note
- edit one of the borrowers returned by this search
- enter serveral lines of text in "Circulation note" and save
- reperform the member search
=> circ note is well displayed on several lines

Bug 9811: use count(primary_key) instead of count(*)

Bug 9811: A limit clause should be always added.

By default, we want to retrieve 20 first results.

Bug 9811: Load the page without any data.

Displaying the first 20 patrons is not useful. With this patch, the
table is hidden and no record is retrieved by default.
On the same way, the existing side effect on redirect disappears.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
-------------
-TEST REPORT-
-------------
For the filter: Tested all the search fields, branches, search type.
Found a bug with "date of birth", followup provided.
Tested display limits and verified that AJAX-queries are
efficient (using LIMIT clause) to not stress DB needlessly.
Tested adding Patrons to a list.
A good feature, which seems to work quite well.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Adding my test plan to the last patch of this bug.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

11 years ago

Members.t

Bug 9811: Patron search improvement

10 years ago