Koha/acqui
Jon Knight 121b8105bc Bug 16739: Show note instead of 500 error for 'Generate EDIFACT' when no EDI account is configured
When a book seller (vendor) does not have EDI account information configured
the basketgroup display still shows a button to generate EDIFACT output which
results in 500 error when clicked.  This patch fixes two aspects of this:

a) it stops the button being displayed in the first place, replacing it with
a message that explains there is not EDIFACT configuration for the vendor.

b) if, somehow, an edifact print operation is passed to the basketgroup
script it detects the lack of an EAN and redirects back to the basket group
display page with a warning message.

To test:
1) Create a vendor with no EDI details.
2) Create a basket with some items in, then close it and add it to a basket
   group for this vendor.
   3) Go to that vendor's basket groups, click on the "Closed" tab and then
      click on the 'generate edifact order' button. You should get a 500 error.
   4) Apply this patch.
   5) Repeat 3, except this time you should find that the 'generate edifact
      order' button has been replaced with a note that there is
      "No EDIFACT configuration for <vendor>".

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-09-28 19:24:49 +00:00
..
pdfformat Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
acqui-home.pl Bug 19792: Performance boost for GetBudgetHierarchy 2018-05-11 10:52:46 -03:00
add_user_search.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
addorder.pl Bug 19289: Use the ACQ framework to display bibliographic details 2018-04-11 16:45:20 -03:00
addorderiso2709.pl Bug 18639: Add replacementprice field to acquisitions workflow 2018-08-31 12:46:28 +00:00
ajax-getauthvaluedropbox.pl Bug 17847: Replace C4::Koha::GetAuthvalueDropbox with Koha::AuthorisedValues 2017-03-31 10:12:37 +00:00
basket.pl Bug 21033: Remove few warns in acqui/basket.pl 2018-08-09 11:31:44 +00:00
basketgroup.pl Bug 16739: Show note instead of 500 error for 'Generate EDIFACT' when no EDI account is configured 2018-09-28 19:24:49 +00:00
basketheader.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
booksellers.pl Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
cancelorder.pl Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules 2017-10-09 14:00:58 -03:00
check_budget_total.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
check_uniqueness.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
edi_ean.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
edifactmsgs.pl Bug 20861: Correct EDI permissions on EDI messsages 2018-06-04 13:40:36 -04:00
edimsg.pl Bug 20861: Correct EDI permissions on EDI messsages 2018-06-04 13:40:36 -04:00
finishreceive.pl Bug 18639: Add replacementprice field to acquisitions workflow 2018-08-31 12:46:28 +00:00
histsearch.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
invoice-files.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
invoice.pl Bug 19166: (follow-up) Adjust table and files and QA issues 2018-07-19 17:28:41 +00:00
invoices.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
lateorders-export.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
lateorders.pl Bug 14535: Update the supplier filter too 2017-03-31 12:38:44 +00:00
modordernotes.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
neworderbiblio.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
neworderempty.pl Bug 18639: Add replacementprice field to acquisitions workflow 2018-08-31 12:46:28 +00:00
newordersubscription.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
newordersuggestion.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
ordered.pl Bug 19166: (follow-up) Adjust table and files and QA issues 2018-07-19 17:28:41 +00:00
orderreceive.pl Bug 18639: Add replacementprice field to acquisitions workflow 2018-08-31 12:46:28 +00:00
parcel.pl Bug 19812: Fix confusing holds count values in "Already received" table 2018-04-04 16:06:57 -03:00
parcels.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
showorder.pl Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI; 2018-07-06 14:01:50 +00:00
spent.pl Bug 19166: (follow-up) Adjust table and files and QA issues 2018-07-19 17:28:41 +00:00
supplier.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
transferorder.pl Bug 19130: (followup) Controller scripts should preserve behaviour 2017-08-25 11:53:44 -03:00
uncertainprice.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
updatesupplier.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
z3950_search.pl Bug 19916: Add keyword and standard ID fields to acq external search 2018-03-28 16:03:37 -03:00