Owen Leonard
13bc2848a1
This patch restores the inclusion of the jsdiff JS library on the guided
reports page when displaying saved SQL reports. This fixes a JS error in
the browser console when the user tries to use our automatic update on
SQL reports which use an older syntax.
The patch also corrects a problem with svc/convert_report which was
causing an error when trying to display the diff information.
To test, apply the patch and restart services.
- Go to Reports -> Create from SQL.
- Add a report which is based on an older db structure. The example I
found was:
SELECT biblionumber,
ExtractValue(marcxml,'//datafield/@tag/text()[substring(.,1,1) = "5"]') as 'notes'
FROM biblioitems
HAVING notes <> ''
- Save the report and go to the list of saved reports. There should be
an "Update" column in the table, with a message about your newly-added
report:
"This report seems obsolete, it uses biblioitems.marcxml field."
- Clicking the "Update SQL" button should trigger a modal window that
shows the before an after versions of the report. There should be
no error in the browser console. Unfortunately the diff will not
display because of a separate bug in svc/convert_report
Signed.off-by: Jessie Zairo <jzairo@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit
|
||
---|---|---|
.. | ||
cataloguing | ||
club | ||
config | ||
letters | ||
mana | ||
members | ||
records | ||
virtualshelves | ||
article_request | ||
authentication | ||
authorised_values | ||
barcode | ||
bib | ||
bib_framework | ||
bib_profile | ||
checkin | ||
checkout_notes | ||
checkouts | ||
convert_report | ||
cover_images | ||
creator_batches | ||
holds | ||
import_bib | ||
localization | ||
new_bib | ||
problem_reports | ||
recall | ||
renew | ||
report | ||
return_claims | ||
split_callnumbers |