Nick Clemens
02a404ef42
The job reports errors when deleting items. The issue seems to be that Koha::Object->delete claims in the POD to return -1, 0, or 1 as a result, but it in fact returns the Object itself on a successful deletion The errors are reported as: ERROR DELETING ITEM 501740: Koha::Item=HASH(0x55ce407a1a78) To recreate: 1 - Find or create a record with some items 2 - Ensure those items can be deleted (not on loan, etc.) 3 - Edit the record leader and set position 5 to 'd' 4 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 5 - Deletion succeeds, but reports failure on items 6 - Apply patch 7 - Find or create a new record as above, but this time add an additional item and check it out to a patron 8 - perl misc/cronjobs/delete_records_via_leader.pl -i -v 9 - Test mode should report 1 item to be deleted, one with error 10 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 11 - One item should be deleted, one item not, record not deleted 12 - check the item in 13 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 14 - Successful deletion with no error reported Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
136 lines
4.3 KiB
Perl
Executable file
136 lines
4.3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
#-----------------------------------
|
|
# Copyright 2013 ByWater Solutions
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
#-----------------------------------
|
|
|
|
use Modern::Perl;
|
|
|
|
binmode( STDOUT, ":encoding(UTF-8)" );
|
|
|
|
BEGIN {
|
|
|
|
# find Koha's Perl modules
|
|
# test carefully before changing this
|
|
use FindBin;
|
|
eval { require "$FindBin::Bin/../kohalib.pl" };
|
|
}
|
|
|
|
use Getopt::Long;
|
|
use Pod::Usage;
|
|
use Koha::Script -cron;
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use Koha::Database;
|
|
use Koha::Biblios;
|
|
use Koha::Biblio::Metadatas;
|
|
use Koha::Items;
|
|
|
|
my $delete_items;
|
|
my $confirm;
|
|
my $test;
|
|
my $verbose;
|
|
my $help;
|
|
|
|
GetOptions(
|
|
'i|di|delete-items' => \$delete_items,
|
|
'c|confirm' => \$confirm,
|
|
't|test' => \$test,
|
|
'v|verbose' => \$verbose,
|
|
'h|help' => \$help,
|
|
);
|
|
|
|
pod2usage(q|--test and --confirm cannot be specified together|) if $test and $confirm;
|
|
|
|
unless ( $confirm or $test ) {
|
|
warn "Running in test mode as --confirm is not passed\n";
|
|
$test = 1;
|
|
}
|
|
|
|
if ( $help ) {
|
|
say qq{
|
|
delete_records_via_leader.pl - Attempt to delete any MARC records where the leader character 5 equals 'd'
|
|
usage: delete_records_via_leader.pl --confirm --verbose [--test]
|
|
This script has the following parameters :
|
|
-h --help: Prints this message
|
|
-c --confirm: Script will do nothing without this parameter
|
|
-v --verbose: Be verbose
|
|
-t --test: Test mode, does not delete records.
|
|
Test mode cannot determine if a record/item will be deleted successfully,
|
|
it will only tell you what records and items the script will attempt to delete.
|
|
-i --delete-items: Try deleting items before deleting record.
|
|
Records with items cannot be deleted.
|
|
};
|
|
exit();
|
|
}
|
|
|
|
my @metadatas = # Should be replaced by a call to C4::Search on zebra index
|
|
# Record-status when bug 15537 will be pushed
|
|
Koha::Biblio::Metadatas->search( { format => 'marcxml', schema => C4::Context->preference('marcflavour'), metadata => { LIKE => '%<leader>_____d%' } } );
|
|
|
|
my $total_records_count = @metadatas;
|
|
my $deleted_records_count = 0;
|
|
my $total_items_count = 0;
|
|
my $deleted_items_count = 0;
|
|
foreach my $m (@metadatas) {
|
|
my $biblionumber = $m->get_column('biblionumber');
|
|
|
|
say "RECORD: $biblionumber" if $verbose;
|
|
|
|
if ($delete_items) {
|
|
my $deleted_count = 0;
|
|
my $biblio = Koha::Biblios->find( $biblionumber );
|
|
my @items = Koha::Items->search( { biblionumber => $biblionumber } );
|
|
foreach my $item ( @items ) {
|
|
my $itemnumber = $item->itemnumber;
|
|
|
|
if( $test ){
|
|
my $result = $item->safe_to_delete;
|
|
if ( $result eq "1") {
|
|
say "TEST MODE: Item $itemnumber would have been deleted";
|
|
} else {
|
|
say "TEST MODE: ERROR DELETING ITEM $itemnumber: $result";
|
|
}
|
|
} else {
|
|
my $result = $item->safe_delete;
|
|
if ( ref $result eq "Koha::Item" ){
|
|
say "DELETED ITEM $itemnumber" if $verbose;
|
|
$deleted_items_count++;
|
|
} else {
|
|
say "ERROR DELETING ITEM $itemnumber: $result";
|
|
}
|
|
}
|
|
$total_items_count++;
|
|
}
|
|
}
|
|
|
|
my $error = $test ? q{Test mode enabled} : DelBiblio($biblionumber);
|
|
if ( $error ) {
|
|
say "ERROR DELETING BIBLIO $biblionumber: $error";
|
|
} else {
|
|
say "DELETED BIBLIO $biblionumber" if $verbose;
|
|
$deleted_records_count++;
|
|
}
|
|
|
|
say q{};
|
|
}
|
|
|
|
if ( $verbose ) {
|
|
say "DELETED $deleted_records_count OF $total_records_count RECORDS";
|
|
say "DELETED $deleted_items_count OF $total_items_count ITEMS" if $delete_items;
|
|
}
|