Kyle M Hall
a57723fc59
Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
157 lines
6.2 KiB
Perl
Executable file
157 lines
6.2 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
use Modern::Perl;
|
|
|
|
use C4::Context;
|
|
|
|
use Test::More tests => 11;
|
|
|
|
use t::lib::TestBuilder;
|
|
use t::lib::Mocks;
|
|
use Koha::Holds;
|
|
|
|
BEGIN {
|
|
use_ok('C4::Reserves');
|
|
}
|
|
|
|
my $schema = Koha::Database->schema;
|
|
$schema->storage->txn_begin;
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my $builder = t::lib::TestBuilder->new;
|
|
|
|
my $library1 = $builder->build({
|
|
source => 'Branch',
|
|
});
|
|
my $library2 = $builder->build({
|
|
source => 'Branch',
|
|
});
|
|
my $library3 = $builder->build({
|
|
source => 'Branch',
|
|
});
|
|
my $itemtype = $builder->build({ source => 'Item' })->{itype};
|
|
|
|
my $bib_title = "Test Title";
|
|
|
|
my $borrower = $builder->build({
|
|
source => 'Borrower',
|
|
value => {
|
|
branchcode => $library1->{branchcode},
|
|
}
|
|
});
|
|
|
|
# Test hold_fulfillment_policy
|
|
my $borrowernumber = $borrower->{borrowernumber};
|
|
my $library_A = $library1->{branchcode};
|
|
my $library_B = $library2->{branchcode};
|
|
my $library_C = $library3->{branchcode};
|
|
$dbh->do("DELETE FROM transport_cost");
|
|
$dbh->do("DELETE FROM tmp_holdsqueue");
|
|
$dbh->do("DELETE FROM hold_fill_targets");
|
|
$dbh->do("DELETE FROM default_branch_circ_rules");
|
|
$dbh->do("DELETE FROM default_branch_item_rules");
|
|
$dbh->do("DELETE FROM default_circ_rules");
|
|
$dbh->do("DELETE FROM branch_item_rules");
|
|
|
|
$dbh->do("INSERT INTO biblio (frameworkcode, author, title, datecreated) VALUES ('', 'Koha test', '$bib_title', '2011-02-01')");
|
|
|
|
my $biblionumber = $dbh->selectrow_array("SELECT biblionumber FROM biblio WHERE title = '$bib_title'")
|
|
or BAIL_OUT("Cannot find newly created biblio record");
|
|
|
|
$dbh->do("INSERT INTO biblioitems (biblionumber, itemtype) VALUES ($biblionumber, '$itemtype')");
|
|
|
|
my $biblioitemnumber =
|
|
$dbh->selectrow_array("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber = $biblionumber")
|
|
or BAIL_OUT("Cannot find newly created biblioitems record");
|
|
|
|
$dbh->do("
|
|
INSERT INTO items (biblionumber, biblioitemnumber, homebranch, holdingbranch, notforloan, damaged, itemlost, withdrawn, onloan, itype)
|
|
VALUES ($biblionumber, $biblioitemnumber, '$library_A', '$library_B', 0, 0, 0, 0, NULL, '$itemtype')
|
|
");
|
|
|
|
my $itemnumber =
|
|
$dbh->selectrow_array("SELECT itemnumber FROM items WHERE biblionumber = $biblionumber")
|
|
or BAIL_OUT("Cannot find newly created item");
|
|
|
|
# With hold_fulfillment_policy = homebranch, hold should only be picked up if pickup branch = homebranch
|
|
$dbh->do("DELETE FROM default_circ_rules");
|
|
$dbh->do("INSERT INTO default_circ_rules ( holdallowed, hold_fulfillment_policy ) VALUES ( 2, 'homebranch' )");
|
|
|
|
# Home branch matches pickup branch
|
|
my $reserve_id = AddReserve( $library_A, $borrowernumber, $biblionumber, '', 1 );
|
|
my ( $status ) = CheckReserves($itemnumber);
|
|
is( $status, 'Reserved', "Hold where pickup branch matches home branch targeted" );
|
|
Koha::Holds->find( $reserve_id )->cancel;
|
|
|
|
# Holding branch matches pickup branch
|
|
$reserve_id = AddReserve( $library_B, $borrowernumber, $biblionumber, '', 1 );
|
|
( $status ) = CheckReserves($itemnumber);
|
|
is($status, q{}, "Hold where pickup ne home, pickup eq home not targeted" );
|
|
Koha::Holds->find( $reserve_id )->cancel;
|
|
|
|
# Neither branch matches pickup branch
|
|
$reserve_id = AddReserve( $library_C, $borrowernumber, $biblionumber, '', 1 );
|
|
( $status ) = CheckReserves($itemnumber);
|
|
is( $status, q{}, "Hold where pickup ne home, pickup ne holding not targeted" );
|
|
Koha::Holds->find( $reserve_id )->cancel;
|
|
|
|
# With hold_fulfillment_policy = holdingbranch, hold should only be picked up if pickup branch = holdingbranch
|
|
$dbh->do("DELETE FROM default_circ_rules");
|
|
$dbh->do("INSERT INTO default_circ_rules ( holdallowed, hold_fulfillment_policy ) VALUES ( 2, 'holdingbranch' )");
|
|
|
|
# Home branch matches pickup branch
|
|
$reserve_id = AddReserve( $library_A, $borrowernumber, $biblionumber, '', 1 );
|
|
( $status ) = CheckReserves($itemnumber);
|
|
is( $status, q{}, "Hold where pickup eq home, pickup ne holding not targeted" );
|
|
Koha::Holds->find( $reserve_id )->cancel;
|
|
|
|
# Holding branch matches pickup branch
|
|
$reserve_id = AddReserve( $library_B, $borrowernumber, $biblionumber, '', 1 );
|
|
( $status ) = CheckReserves($itemnumber);
|
|
is( $status, 'Reserved', "Hold where pickup ne home, pickup eq holding targeted" );
|
|
Koha::Holds->find( $reserve_id )->cancel;
|
|
|
|
# Neither branch matches pickup branch
|
|
$reserve_id = AddReserve( $library_C, $borrowernumber, $biblionumber, '', 1 );
|
|
( $status ) = CheckReserves($itemnumber);
|
|
is( $status, q{}, "Hold where pickup ne home, pickup ne holding not targeted" );
|
|
Koha::Holds->find( $reserve_id )->cancel;
|
|
|
|
# With hold_fulfillment_policy = any, hold should be pikcup up reguardless of matching home or holding branch
|
|
$dbh->do("DELETE FROM default_circ_rules");
|
|
$dbh->do("INSERT INTO default_circ_rules ( holdallowed, hold_fulfillment_policy ) VALUES ( 2, 'any' )");
|
|
|
|
# Home branch matches pickup branch
|
|
$reserve_id = AddReserve( $library_A, $borrowernumber, $biblionumber, '', 1 );
|
|
( $status ) = CheckReserves($itemnumber);
|
|
is( $status, 'Reserved', "Hold where pickup eq home, pickup ne holding targeted" );
|
|
Koha::Holds->find( $reserve_id )->cancel;
|
|
|
|
# Holding branch matches pickup branch
|
|
$reserve_id = AddReserve( $library_B, $borrowernumber, $biblionumber, '', 1 );
|
|
( $status ) = CheckReserves($itemnumber);
|
|
is( $status, 'Reserved', "Hold where pickup ne home, pickup eq holding targeted" );
|
|
Koha::Holds->find( $reserve_id )->cancel;
|
|
|
|
# Neither branch matches pickup branch
|
|
$reserve_id = AddReserve( $library_C, $borrowernumber, $biblionumber, '', 1 );
|
|
( $status ) = CheckReserves($itemnumber);
|
|
is( $status, 'Reserved', "Hold where pickup ne home, pickup ne holding targeted" );
|
|
Koha::Holds->find( $reserve_id )->cancel;
|
|
|
|
# Test enforement of branch transfer limits
|
|
t::lib::Mocks::mock_preference( 'UseBranchTransferLimits', '1' );
|
|
t::lib::Mocks::mock_preference( 'BranchTransferLimitsType', 'itemtype' );
|
|
Koha::Holds->search()->delete();
|
|
my ($item) = Koha::Biblios->find($biblionumber)->items;
|
|
my $limit = Koha::Item::Transfer::Limit->new(
|
|
{
|
|
toBranch => $library_C,
|
|
fromBranch => $item->holdingbranch,
|
|
itemtype => $item->effective_itemtype,
|
|
}
|
|
)->store();
|
|
$reserve_id = AddReserve( $library_C, $borrowernumber, $biblionumber, '', 1 );
|
|
($status) = CheckReserves($itemnumber);
|
|
is( $status, '', "No hold where branch transfer is not allowed" );
|
|
Koha::Holds->find($reserve_id)->cancel;
|