Alex Buckley
db3ebe47e8
Removed the sql code from Itemtypes.pm and replaced it with DBIx
database query in the itemtypes.pl administrative script
Test plan:
1. In the staff interface, stage and manage MARC records for import
2. Try to delete an itemtype. If there are items of that itemtype in the
database then a message telling you the number of items of that
itemtype there are will be displayed.
3. Record that number
4. View the admin/itemtpes.pl script and confirm that there is sql code
written in this file.
5. Apply this patch
6. View the admin/itemtypes.pl script and observe that there is no sql
in this file. There is however DBIx code, for example
$schema->resultset('Item')->search({ 'itype' => $itemtype_code} );
which is searching for items with the itype value matching
$itemtype_code value.
7. In the staff interface try to delete the same itemtype
8. Record the number of items there are with that itemtype in the
resulting message
9. The numbers recorded in steps 3 and 8 should match showing that the
DBIx code is working as intended
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
|
||
|---|---|---|
| .. | ||
| preferences | ||
| searchengine/elasticsearch | ||
| admin-home.tt | ||
| aqbudgetperiods.tt | ||
| aqbudgets.tt | ||
| aqcontract.tt | ||
| aqplan.tt | ||
| audio_alerts.tt | ||
| auth_subfields_structure.tt | ||
| auth_tag_structure.tt | ||
| authorised_values.tt | ||
| authtypes.tt | ||
| biblio_framework.tt | ||
| branch_transfer_limits.tt | ||
| branches.tt | ||
| categories.tt | ||
| checkmarc.tt | ||
| cities.tt | ||
| classsources.tt | ||
| clone-rules.tt | ||
| columns_settings.tt | ||
| currency.tt | ||
| didyoumean.tt | ||
| edi_accounts.tt | ||
| edi_ean_accounts.tt | ||
| fieldmapping.tt | ||
| item_circulation_alerts.tt | ||
| items_search_field.tt | ||
| items_search_fields.tt | ||
| itemtypes.tt | ||
| koha2marclinks.tt | ||
| localization.tt | ||
| marc_subfields_structure.tt | ||
| marctagstructure.tt | ||
| matching-rules.tt | ||
| oai_set_mappings.tt | ||
| oai_sets.tt | ||
| patron-attr-types.tt | ||
| preferences.tt | ||
| printers.tt | ||
| smart-rules.tt | ||
| sms_providers.tt | ||
| sru_modmapping.tt | ||
| systempreferences.tt | ||
| transport-cost-matrix.tt | ||
| usage_statistics.tt | ||
| z3950servers.tt | ||