571dab9c7c
Remedied by: - in Circulation.pm changing AnonymiseIssueHistory so that it returns ($rows, $err_history_not_deleted) instead of $rows - consequential change to misc/cronjobs/batch_anonymise.pl to handle updated return value, and fail if there is an error - consequential change to tools/cleanborrowers.pl although this still fails silently (raised as bug 9944) - update of opac-privacy.pl to check return value and pass on error - update of opac-privacy.tt to display error if appropriate Note bug 9942 remains unfixed, which is a similar issue upon issue return. To test: 1. OPAC - enable privacy mode (preference OpacPrivacy) - leave anonymous patron set to zero (preference AnonymousPatron) - attempt to delete user history - observe error - check history - still there - change anonymous patron to a valid user - attempt to delete user history - observe success message - check history - gone 2. cleanborrowers.pl - test it functions as before. bug 9944 has been raised for it continuing to silently fail. 3. batch_anonymise.pl - enable privacy mode (preference OpacPrivacy) - leave anonymous patron set to zero (preference AnonymousPatron) - run script (I use --days -1 for testing) - script should fail with a Carp message - change anonymous patron to a valid user - run script as before - script returns quietly - check history - gone Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
73 lines
2.3 KiB
Perl
Executable file
73 lines
2.3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
# This script lets the users change their privacy rules
|
|
#
|
|
# copyright 2009, BibLibre, paul.poulain@biblibre.com
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 2 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with Koha; if not, write to the Free Software Foundation, Inc.,
|
|
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
|
|
use strict;
|
|
use CGI;
|
|
|
|
use C4::Auth; # checkauth, getborrowernumber.
|
|
use C4::Context;
|
|
use C4::Circulation;
|
|
use C4::Members;
|
|
use C4::Output;
|
|
use C4::Dates;
|
|
|
|
my $query = new CGI;
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "opac-privacy.tmpl",
|
|
query => $query,
|
|
type => "opac",
|
|
authnotrequired => 0,
|
|
flagsrequired => { borrow => 1 },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $op = $query->param("op");
|
|
my $privacy = $query->param("privacy");
|
|
|
|
if ($op eq "update_privacy")
|
|
{
|
|
ModPrivacy($borrowernumber,$privacy);
|
|
$template->param('privacy_updated' => 1);
|
|
}
|
|
if ($op eq "delete_record") {
|
|
# delete all reading records for items returned
|
|
# uses a hardcoded date ridiculously far in the future
|
|
my ($rows,$err_history_not_deleted) = AnonymiseIssueHistory('2999-12-12',$borrowernumber);
|
|
# confirm the user the deletion has been done
|
|
if ( !$err_history_not_deleted ) {
|
|
$template->param( 'deleted' => 1 );
|
|
}
|
|
else {
|
|
$template->param( 'err_history_not_deleted' => 1 );
|
|
}
|
|
}
|
|
# get borrower privacy ....
|
|
my ( $borr ) = GetMemberDetails( $borrowernumber );
|
|
|
|
$template->param( 'Ask_data' => '1',
|
|
'privacy'.$borr->{'privacy'} => 1,
|
|
'firstname' => $borr->{'firstname'},
|
|
'surname' => $borr->{'surname'},
|
|
'privacyview' => 1,
|
|
);
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|