Jonathan Druart
9d6d641d1f
On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. This patch is a squashed version of: Bug 17600: After export.pl Bug 17600: After perlimport Bug 17600: Manual changes Bug 17600: Other manual changes after second perlimports run Bug 17600: Fix tests And a lot of other manual changes. export.pl is a dirty script that can be found on bug 17600. "perlimport" is: git clone https://github.com/oalders/App-perlimports.git cd App-perlimports/ cpanm --installdeps . export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib" find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; The ideas of this patch are to: * use EXPORT_OK instead of EXPORT * perltidy the EXPORT_OK list * remove '&' before the subroutine names * remove some uneeded use statements * explicitely import the subroutines we need within the controllers or modules Note that the private subroutines (starting with _) should not be exported (and not used from outside of the module except from tests). EXPORT vs EXPORT_OK (from https://www.thegeekstuff.com/2010/06/perl-exporter-examples/) """ Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members. @EXPORT and @EXPORT_OK are the two main variables used during export operation. @EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace. @EXPORT_OK does export of symbols on demand basis. """ If this patch caused a conflict with a patch you wrote prior to its push: * Make sure you are not reintroducing a "use" statement that has been removed * "$subroutine" is not exported by the C4::$MODULE module means that you need to add the subroutine to the @EXPORT_OK list * Bareword "$subroutine" not allowed while "strict subs" means that you didn't imported the subroutine from the module: - use $MODULE qw( $subroutine list ); You can also use the fully qualified namespace: C4::$MODULE::$subroutine Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
207 lines
5.8 KiB
Perl
Executable file
207 lines
5.8 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
# Copyright 2016 Koha Development Team
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
|
|
=head1 NAME
|
|
|
|
addbybiblionumber.pl
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
This script allow to add a virtual in a virtual shelf from a biblionumber.
|
|
|
|
=head1 CGI PARAMETERS
|
|
|
|
=over 4
|
|
|
|
=item biblionumber
|
|
|
|
The biblionumber
|
|
|
|
=item shelfnumber
|
|
|
|
the shelfnumber where to add the virtual.
|
|
|
|
=item newvirtualshelf
|
|
|
|
if this parameter exists, then it must be equals to the name of the shelf
|
|
to add.
|
|
|
|
=item category
|
|
|
|
if this script has to add a shelf, it add one with this category.
|
|
|
|
=item newshelf
|
|
|
|
if this parameter exists, then we create a new shelf
|
|
|
|
=back
|
|
|
|
=cut
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Output qw( output_html_with_http_headers );
|
|
use C4::Auth qw( get_template_and_user );
|
|
|
|
use Koha::Biblios;
|
|
use Koha::Virtualshelves;
|
|
|
|
my $query = CGI->new;
|
|
my $shelfnumber = $query->param('shelfnumber');
|
|
my $newvirtualshelf = $query->param('newvirtualshelf');
|
|
my $newshelf = $query->param('newshelf');
|
|
my $category = $query->param('category');
|
|
my $sortfield = $query->param('sortfield');
|
|
my $confirmed = $query->param('confirmed') || 0;
|
|
my ( $errcode, $authorized ) = ( 0, 1 );
|
|
my @biblionumbers = $query->multi_param('biblionumber');
|
|
|
|
if ( @biblionumbers == 0 && $query->param('biblionumbers') ) {
|
|
my $str = $query->param('biblionumbers');
|
|
@biblionumbers = split '/', $str;
|
|
} elsif ( @biblionumbers == 1 && $biblionumbers[0] =~ /\// ) {
|
|
@biblionumbers = split '/', $biblionumbers[0];
|
|
}
|
|
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{ template_name => "virtualshelves/addbybiblionumber.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
flagsrequired => { catalogue => 1 },
|
|
}
|
|
);
|
|
|
|
if ($newvirtualshelf) {
|
|
my $shelf = eval {
|
|
Koha::Virtualshelf->new(
|
|
{
|
|
shelfname => $newvirtualshelf,
|
|
category => $category,
|
|
sortfield => $sortfield,
|
|
owner => $loggedinuser,
|
|
}
|
|
)->store;
|
|
};
|
|
if ( $@ or not $shelf ) {
|
|
$errcode = 1;
|
|
$authorized = 0;
|
|
} else {
|
|
|
|
for my $biblionumber (@biblionumbers) {
|
|
$shelf->add_biblio( $biblionumber, $loggedinuser );
|
|
}
|
|
|
|
#Reload the page where you came from
|
|
print $query->header;
|
|
print "<html><meta http-equiv=\"refresh\" content=\"0\" /><body onload=\"window.opener.location.reload(true);self.close();\"></body></html>";
|
|
exit;
|
|
}
|
|
|
|
} elsif ( $shelfnumber && $confirmed ) {
|
|
my $shelf = Koha::Virtualshelves->find($shelfnumber);
|
|
if ( $shelf->can_biblios_be_added($loggedinuser) ) {
|
|
for my $biblionumber (@biblionumbers) {
|
|
$shelf->add_biblio( $biblionumber, $loggedinuser );
|
|
}
|
|
|
|
#Close this page and return
|
|
print $query->header;
|
|
print "<html><meta http-equiv=\"refresh\" content=\"0\" /><body onload=\"self.close();\"></body></html>";
|
|
exit;
|
|
} else {
|
|
$errcode = 2; #no perm
|
|
$authorized = 0;
|
|
}
|
|
|
|
} elsif ($shelfnumber) { #still needs confirmation
|
|
my $shelf = Koha::Virtualshelves->find($shelfnumber);
|
|
if ( $shelf->can_biblios_be_added($loggedinuser) ) {
|
|
|
|
#confirm adding to specific shelf
|
|
$template->param(
|
|
singleshelf => 1,
|
|
shelfnumber => $shelf->shelfnumber,
|
|
shelfname => $shelf->shelfname,
|
|
);
|
|
} else {
|
|
$authorized = 0;
|
|
$errcode = 2; #no perm
|
|
}
|
|
|
|
} else {
|
|
my $private_shelves = Koha::Virtualshelves->search(
|
|
{ category => 1,
|
|
owner => $loggedinuser,
|
|
allow_change_from_owner => 1,
|
|
},
|
|
{ order_by => 'shelfname' }
|
|
);
|
|
my $shelves_shared_with_me = Koha::Virtualshelves->search(
|
|
{ category => 1,
|
|
'virtualshelfshares.borrowernumber' => $loggedinuser,
|
|
allow_change_from_others => 1,
|
|
},
|
|
{ join => 'virtualshelfshares', }
|
|
);
|
|
my $public_shelves = Koha::Virtualshelves->search(
|
|
{ category => 2,
|
|
-or => [
|
|
-and => {
|
|
allow_change_from_owner => 1,
|
|
owner => $loggedinuser,
|
|
},
|
|
allow_change_from_others => 1,
|
|
],
|
|
},
|
|
{ order_by => 'shelfname' }
|
|
);
|
|
$template->param(
|
|
private_shelves => $private_shelves,
|
|
private_shelves_shared_with_me => $shelves_shared_with_me,
|
|
public_shelves => $public_shelves,
|
|
);
|
|
|
|
}
|
|
|
|
my @biblios;
|
|
for my $biblionumber (@biblionumbers) {
|
|
my $biblio = Koha::Biblios->find( $biblionumber );
|
|
push(
|
|
@biblios,
|
|
{ biblionumber => $biblionumber,
|
|
title => $biblio->title,
|
|
author => $biblio->author,
|
|
}
|
|
);
|
|
}
|
|
$template->param(
|
|
multiple => ( scalar(@biblios) > 1 ),
|
|
total => scalar @biblios,
|
|
biblios => \@biblios,
|
|
);
|
|
|
|
$template->param(
|
|
newshelf => $newshelf || 0,
|
|
authorized => $authorized,
|
|
errcode => $errcode,
|
|
);
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|