dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
145 lines
5 KiB
Text
145 lines
5 KiB
Text
[% USE raw %]
|
|
[% USE Asset %]
|
|
[% USE KohaDates %]
|
|
[% USE Koha %]
|
|
[% USE AuthorisedValues %]
|
|
[% USE Branches %]
|
|
[% USE ColumnsSettings %]
|
|
[% USE ItemTypes %]
|
|
[% SET footerjs = 1 %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Holds history for [% INCLUDE 'patron-title.inc' no_html = 1 %]</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
[% Asset.css("css/datatables.css") | $raw %]
|
|
</head>
|
|
|
|
<body id="pat_holdshistory" class="pat">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'patron-search.inc' %]
|
|
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/members/members-home.pl">Patrons</a> › Holds history for [% INCLUDE 'patron-title.inc' %]</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
[% INCLUDE 'members-toolbar.inc' %]
|
|
<h1>Holds history</h1>
|
|
|
|
[% UNLESS Koha.Preference('intranetreadinghistory') %]
|
|
<div class="dialog alert">Staff members are not allowed to access patron's holds history</div>
|
|
[% ELSIF is_anonymous %]
|
|
<div class="dialog alert">This is the anonymous patron, so no holds history is displayed.</div>
|
|
[% ELSIF ( !holds ) %]
|
|
<div class="dialog message">This patron has no holds history.</div>
|
|
[% ELSE %]
|
|
|
|
[% SET show_itemtype_column = Koha.Preference('AllowHoldItemTypeSelection') %]
|
|
|
|
<div id="holdshistory" style="overflow:hidden">
|
|
<table id="table_holdshistory">
|
|
<thead>
|
|
<th class="anti-the">Title</th>
|
|
<th>Author</th>
|
|
<th>Barcode</th>
|
|
<th>Library</th>
|
|
<th class="title-string">Hold date</th>
|
|
<th class="title-string">Expiration date</th>
|
|
<th class="title-string">Waiting date</th>
|
|
<th class="title-string">Cancellation date</th>
|
|
[% IF show_itemtype_column %]
|
|
<th>Requested item type</th>
|
|
[% END %]
|
|
<th>Status</th>
|
|
</thead>
|
|
<tbody>
|
|
[% FOREACH hold IN holds %]
|
|
<td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% hold.biblio.biblionumber | html %]">[% hold.biblio.title | html %]</a></td>
|
|
<td>[% hold.biblio.author | html %]</td>
|
|
<td>[% hold.item.barcode | html %]</td>
|
|
<td>[% Branches.GetName( hold.branchcode ) | html %]</td>
|
|
<td><span title="[% hold.reservedate | html %]">[% hold.reservedate | $KohaDates %]</span></td>
|
|
<td>
|
|
[% IF hold.expirationdate %]
|
|
<span title="[% hold.expirationdate | html %]">[% hold.expirationdate | $KohaDates %]</span>
|
|
[% ELSE %]
|
|
<span title="0000-00-00"></span>
|
|
[% END %]
|
|
</td>
|
|
<td>
|
|
[% IF hold.waitingdate %]
|
|
<span title="[% hold.waitingdate | html %]">[% hold.waitingdate | $KohaDates %]</span>
|
|
[% ELSE %]
|
|
<span title="0000-00-00"></span>
|
|
[% END %]
|
|
</td>
|
|
<td>
|
|
[% IF hold.cancellationdate %]
|
|
<span title="[% hold.cancellationdate | html %]">[% hold.cancellationdate | $KohaDates %]</span>
|
|
[% ELSE %]
|
|
<span title="0000-00-00"></span>
|
|
[% END %]
|
|
</td>
|
|
[% IF show_itemtype_column %]
|
|
<td>
|
|
[% IF hold.itemtype %]
|
|
[% ItemTypes.GetDescription( hold.itemtype ) | html %]
|
|
[% ELSE %]
|
|
<span>Any item type</span>
|
|
[% END %]
|
|
</td>
|
|
[% END %]
|
|
<td>
|
|
[% IF hold.found == 'F' %]
|
|
Fulfilled
|
|
[% ELSIF hold.cancellationdate %]
|
|
Cancelled
|
|
[% ELSIF hold.found == 'W' %]
|
|
Waiting
|
|
[% ELSIF hold.found == 'T' %]
|
|
In transit
|
|
[% ELSE %]
|
|
Pending
|
|
[% END %]
|
|
</td>
|
|
</tr>
|
|
[% END %]
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
|
|
[% END %]
|
|
</div>
|
|
</div>
|
|
|
|
<div class="yui-b">
|
|
[% INCLUDE 'circ-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% INCLUDE 'datatables.inc' %]
|
|
[% INCLUDE 'columns_settings.inc' %]
|
|
[% INCLUDE 'str/members-menu.inc' %]
|
|
[% Asset.js("js/members-menu.js") | $raw %]
|
|
<script type="text/javascript" id="js">
|
|
$(document).ready(function() {
|
|
var columns_settings = [% ColumnsSettings.GetColumns('members', 'holdshistory', 'holdshistory-table', 'json') %];
|
|
[% UNLESS show_itemtype_column %]
|
|
//Remove item type column settings
|
|
columns_settings = columns_settings.filter(function(c){return c['columnname'] != 'itemtype';});
|
|
[% END %]
|
|
var table = KohaTable("table_holdshistory", {
|
|
"sPaginationType": "four_button",
|
|
"aaSorting": [[4, 'desc']],
|
|
"sDom": 'C<"top pager"ilpfB><"#filter_c">tr<"bottom pager"ip>',
|
|
"aoColumnDefs": [
|
|
{ "sType": "anti-the", "aTargets" : [ "anti-the" ] },
|
|
{ "sType": "title-string", "aTargets" : [ "title-string" ] }
|
|
]
|
|
}, columns_settings);
|
|
});
|
|
</script>
|
|
[% END %]
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|