Jonathan Druart
93244efa3c
If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
177 lines
6.4 KiB
Perl
Executable file
177 lines
6.4 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
#script to place reserves/requests
|
|
#written 2/1/00 by chris@katipo.oc.nz
|
|
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use C4::Output;
|
|
use C4::Reserves;
|
|
use C4::Circulation;
|
|
use C4::Members;
|
|
use C4::Auth qw/checkauth/;
|
|
|
|
use Koha::Items;
|
|
use Koha::Patrons;
|
|
|
|
my $input = CGI->new();
|
|
|
|
checkauth($input, 0, { reserveforothers => 'place_holds' }, 'intranet');
|
|
|
|
my @bibitems = $input->multi_param('biblioitem');
|
|
my @reqbib = $input->multi_param('reqbib');
|
|
my $biblionumber = $input->param('biblionumber');
|
|
my $borrowernumber = $input->param('borrowernumber');
|
|
my $notes = $input->param('notes');
|
|
my $branch = $input->param('pickup');
|
|
my $startdate = $input->param('reserve_date') || '';
|
|
my @rank = $input->multi_param('rank-request');
|
|
my $type = $input->param('type');
|
|
my $title = $input->param('title');
|
|
my $checkitem = $input->param('checkitem');
|
|
my $expirationdate = $input->param('expiration_date');
|
|
my $itemtype = $input->param('itemtype') || undef;
|
|
|
|
my $borrower = Koha::Patrons->find( $borrowernumber );
|
|
$borrower = $borrower->unblessed if $borrower;
|
|
|
|
my $biblionumbers = $input->param('biblionumbers');
|
|
$biblionumbers ||= $biblionumber . '/';
|
|
|
|
my $bad_bibs = $input->param('bad_bibs');
|
|
my $holds_to_place_count = $input->param('holds_to_place_count') || 1;
|
|
|
|
my %bibinfos = ();
|
|
my @biblionumbers = split '/', $biblionumbers;
|
|
foreach my $bibnum (@biblionumbers) {
|
|
my %bibinfo = ();
|
|
$bibinfo{title} = $input->param("title_$bibnum");
|
|
$bibinfo{rank} = $input->param("rank_$bibnum");
|
|
$bibinfos{$bibnum} = \%bibinfo;
|
|
}
|
|
|
|
my $found;
|
|
|
|
if ( $type eq 'str8' && $borrower ) {
|
|
|
|
foreach my $biblionumber ( keys %bibinfos ) {
|
|
my $count = @bibitems;
|
|
@bibitems = sort @bibitems;
|
|
my $i2 = 1;
|
|
my @realbi;
|
|
$realbi[0] = $bibitems[0];
|
|
for ( my $i = 1 ; $i < $count ; $i++ ) {
|
|
my $i3 = $i2 - 1;
|
|
if ( $realbi[$i3] ne $bibitems[$i] ) {
|
|
$realbi[$i2] = $bibitems[$i];
|
|
$i2++;
|
|
}
|
|
}
|
|
|
|
my $can_override = C4::Context->preference('AllowHoldPolicyOverride');
|
|
if ( defined $checkitem && $checkitem ne '' ) {
|
|
|
|
my $item = Koha::Items->find($checkitem);
|
|
|
|
if ( $item->biblionumber ne $biblionumber ) {
|
|
$biblionumber = $item->biblionumber;
|
|
}
|
|
|
|
my $can_item_be_reserved = CanItemBeReserved($borrower->{'borrowernumber'}, $item->itemnumber, $branch)->{status};
|
|
|
|
if ( $can_item_be_reserved eq 'OK' || ( $can_item_be_reserved ne 'itemAlreadyOnHold' && $can_override ) ) {
|
|
AddReserve(
|
|
{
|
|
branchcode => $branch,
|
|
borrowernumber => $borrower->{'borrowernumber'},
|
|
biblionumber => $biblionumber,
|
|
priority => $rank[0],
|
|
reservation_date => $startdate,
|
|
expiration_date => $expirationdate,
|
|
notes => $notes,
|
|
title => $title,
|
|
itemnumber => $checkitem,
|
|
found => $found,
|
|
itemtype => $itemtype,
|
|
}
|
|
);
|
|
|
|
}
|
|
|
|
} elsif (@biblionumbers > 1) {
|
|
my $bibinfo = $bibinfos{$biblionumber};
|
|
if ( $can_override || CanBookBeReserved($borrower->{'borrowernumber'}, $biblionumber)->{status} eq 'OK' ) {
|
|
AddReserve(
|
|
{
|
|
branchcode => $branch,
|
|
borrowernumber => $borrower->{'borrowernumber'},
|
|
biblionumber => $biblionumber,
|
|
priority => $bibinfo->{rank},
|
|
reservation_date => $startdate,
|
|
expiration_date => $expirationdate,
|
|
notes => $notes,
|
|
title => $bibinfo->{title},
|
|
itemnumber => $checkitem,
|
|
found => $found,
|
|
itemtype => $itemtype,
|
|
}
|
|
);
|
|
}
|
|
} else {
|
|
# place a request on 1st available
|
|
for ( my $i = 0 ; $i < $holds_to_place_count ; $i++ ) {
|
|
if ( $can_override || CanBookBeReserved($borrower->{'borrowernumber'}, $biblionumber)->{status} eq 'OK' ) {
|
|
AddReserve(
|
|
{
|
|
branchcode => $branch,
|
|
borrowernumber => $borrower->{'borrowernumber'},
|
|
biblionumber => $biblionumber,
|
|
priority => $rank[0],
|
|
reservation_date => $startdate,
|
|
expiration_date => $expirationdate,
|
|
notes => $notes,
|
|
title => $title,
|
|
itemnumber => $checkitem,
|
|
found => $found,
|
|
itemtype => $itemtype,
|
|
}
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if ($bad_bibs) {
|
|
$biblionumbers .= $bad_bibs;
|
|
}
|
|
print $input->redirect("request.pl?biblionumber=$biblionumber");
|
|
}
|
|
elsif ( $borrowernumber eq '' ) {
|
|
print $input->header();
|
|
print "Invalid borrower number please try again";
|
|
|
|
# Not sure that Dump() does HTML escaping. Use firebug or something to trace
|
|
# instead.
|
|
#print $input->Dump;
|
|
}
|