b168f4a2e9
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 lines
415 B
Perl
Executable file
22 lines
415 B
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Remove a perl module
|
|
|
|
use Modern::Perl;
|
|
use ExtUtils::Packlist;
|
|
use ExtUtils::Installed;
|
|
|
|
$ARGV[0] or die "Usage: $0 Module::Name\n";
|
|
|
|
my $mod = $ARGV[0];
|
|
|
|
my $inst = ExtUtils::Installed->new();
|
|
|
|
foreach my $item (sort($inst->files($mod))) {
|
|
print "removing $item\n";
|
|
unlink $item;
|
|
}
|
|
|
|
my $packfile = $inst->packlist($mod)->packlist_file();
|
|
print "removing $packfile\n";
|
|
unlink $packfile;
|