Nick Clemens
6ac037f817
We should use Koha::DateUtils instead of Date::Time directly This patch simplay replaces calls to now() with a call to dt_from_string() which does effectively the same thing. Probably reading the code and verifying changes is sufficient but... To test: 1 - confirm the files all compile 2 - confirm all tests pass 3 - confirm Koha still works Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
200 lines
6.6 KiB
Perl
Executable file
200 lines
6.6 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
use DateTime;
|
|
|
|
use C4::Circulation;
|
|
use Koha::Database;
|
|
use Koha::DateUtils;
|
|
use Koha::Patrons;
|
|
use Koha::Biblio;
|
|
use Koha::Item;
|
|
use Koha::Holds;
|
|
use Koha::Hold;
|
|
use Koha::CirculationRules;
|
|
use t::lib::TestBuilder;
|
|
use t::lib::Mocks;
|
|
|
|
use Test::More tests => 17;
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
my $schema = Koha::Database->new()->schema();
|
|
my $builder = t::lib::TestBuilder->new;
|
|
|
|
$schema->storage->txn_begin();
|
|
|
|
my $now_value = dt_from_string();
|
|
my $mocked_datetime = Test::MockModule->new('DateTime');
|
|
$mocked_datetime->mock( 'now', sub { return $now_value->clone; } );
|
|
|
|
my $library = $builder->build( { source => 'Branch' } );
|
|
my $category = $builder->build( { source => 'Category' } );
|
|
my $itemtype = $builder->build( { source => 'Itemtype' } )->{itemtype};
|
|
|
|
t::lib::Mocks::mock_userenv({ branchcode => $library->{branchcode} });
|
|
is( C4::Context->userenv->{branch}, $library->{branchcode}, 'userenv set' );
|
|
|
|
my $patron_category = $builder->build({
|
|
source => 'Category',
|
|
value => {
|
|
category_type => 'P',
|
|
enrolmentfee => 0
|
|
}
|
|
});
|
|
|
|
my @patrons;
|
|
for my $i ( 1 .. 20 ) {
|
|
my $patron = Koha::Patron->new({
|
|
firstname => 'Kyle',
|
|
surname => 'Hall',
|
|
categorycode => $category->{categorycode},
|
|
branchcode => $library->{branchcode},
|
|
categorycode => $patron_category->{categorycode},
|
|
})->store();
|
|
push( @patrons, $patron );
|
|
}
|
|
|
|
my $biblio = $builder->build_sample_biblio();
|
|
|
|
my @items;
|
|
for my $i ( 1 .. 10 ) {
|
|
my $item = $builder->build_sample_item(
|
|
{
|
|
biblionumber => $biblio->id(),
|
|
itype => $itemtype
|
|
}
|
|
);
|
|
push( @items, $item );
|
|
}
|
|
|
|
for my $i ( 0 .. 5 ) {
|
|
my $patron = $patrons[$i];
|
|
my $hold = Koha::Hold->new(
|
|
{
|
|
borrowernumber => $patron->id,
|
|
biblionumber => $biblio->id,
|
|
branchcode => $library->{branchcode},
|
|
}
|
|
)->store();
|
|
}
|
|
|
|
my $item = pop(@items);
|
|
my $patron = pop(@patrons);
|
|
|
|
Koha::CirculationRules->set_rules(
|
|
{
|
|
branchcode => undef,
|
|
categorycode => undef,
|
|
itemtype => $item->itype,
|
|
rules => {
|
|
issuelength => '14',
|
|
lengthunit => 'days',
|
|
reservesallowed => '99',
|
|
holds_per_record => '99',
|
|
}
|
|
}
|
|
);
|
|
|
|
|
|
my $orig_due = C4::Circulation::CalcDateDue(
|
|
dt_from_string(),
|
|
$item->effective_itemtype,
|
|
$patron->branchcode,
|
|
$patron->unblessed
|
|
);
|
|
|
|
t::lib::Mocks::mock_preference( 'decreaseLoanHighHolds', 1 );
|
|
t::lib::Mocks::mock_preference( 'decreaseLoanHighHoldsDuration', 1 );
|
|
t::lib::Mocks::mock_preference( 'decreaseLoanHighHoldsValue', 1 );
|
|
t::lib::Mocks::mock_preference( 'decreaseLoanHighHoldsControl', 'static' );
|
|
t::lib::Mocks::mock_preference( 'decreaseLoanHighHoldsIgnoreStatuses', 'damaged,itemlost,notforloan,withdrawn' );
|
|
|
|
my $item_hr = { itemnumber => $item->id, biblionumber => $biblio->id, homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, barcode => $item->barcode };
|
|
my $patron_hr = { borrowernumber => $patron->id, branchcode => $library->{branchcode} };
|
|
|
|
my $data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
|
|
is( $data->{exceeded}, 1, "Static mode should exceed threshold" );
|
|
is( $data->{outstanding}, 6, "Should have 5 outstanding holds" );
|
|
is( $data->{duration}, 1, "Should have duration of 1" );
|
|
is( ref( $data->{due_date} ), 'DateTime', "due_date should be a DateTime object" );
|
|
|
|
my $duedate = $data->{due_date};
|
|
is($duedate->hour, $orig_due->hour, 'New due hour is equal to original due hour.');
|
|
is($duedate->min, $orig_due->min, 'New due minute is equal to original due minute.');
|
|
is($duedate->sec, 0, 'New due date second is zero.');
|
|
|
|
t::lib::Mocks::mock_preference( 'decreaseLoanHighHoldsControl', 'dynamic' );
|
|
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
|
|
is( $data->{exceeded}, 0, "Should not exceed threshold" );
|
|
|
|
for my $i ( 5 .. 10 ) {
|
|
my $patron = $patrons[$i];
|
|
my $hold = Koha::Hold->new(
|
|
{
|
|
borrowernumber => $patron->id,
|
|
biblionumber => $biblio->id,
|
|
branchcode => $library->{branchcode},
|
|
}
|
|
)->store();
|
|
}
|
|
|
|
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
|
|
is( $data->{exceeded}, 1, "Should exceed threshold of 1" );
|
|
|
|
t::lib::Mocks::mock_preference( 'decreaseLoanHighHoldsValue', 2 );
|
|
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
|
|
is( $data->{exceeded}, 0, "Should not exceed threshold of 2" );
|
|
|
|
my $unholdable = pop(@items);
|
|
$unholdable->damaged(-1);
|
|
$unholdable->store();
|
|
|
|
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
|
|
is( $data->{exceeded}, 1, "Should exceed threshold with one damaged item" );
|
|
|
|
$unholdable->damaged(0);
|
|
$unholdable->itemlost(-1);
|
|
$unholdable->store();
|
|
|
|
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
|
|
is( $data->{exceeded}, 1, "Should exceed threshold with one lost item" );
|
|
|
|
$unholdable->itemlost(0);
|
|
$unholdable->notforloan(-1);
|
|
$unholdable->store();
|
|
|
|
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
|
|
is( $data->{exceeded}, 1, "Should exceed threshold with one notforloan item" );
|
|
|
|
$unholdable->notforloan(0);
|
|
$unholdable->withdrawn(-1);
|
|
$unholdable->store();
|
|
|
|
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
|
|
is( $data->{exceeded}, 1, "Should exceed threshold with one withdrawn item" );
|
|
|
|
t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
|
|
|
|
my $patron_object = Koha::Patrons->find( $patron_hr->{borrowernumber} );
|
|
my ( undef, $needsconfirmation ) = CanBookBeIssued( $patron_object, $item->barcode );
|
|
ok( $needsconfirmation->{HIGHHOLDS}, "High holds checkout needs confirmation" );
|
|
|
|
( undef, $needsconfirmation ) = CanBookBeIssued( $patron_object, $item->barcode, undef, undef, undef, { override_high_holds => 1 } );
|
|
ok( !$needsconfirmation->{HIGHHOLDS}, "High holds checkout does not need confirmation" );
|
|
|
|
$schema->storage->txn_rollback();
|