Tomas Cohen Arazi
ecf68132b7
This patch adds tests for: - Output of ImportFramework on fields removal and error conditions (file not found) - Different file format behaviour (csv, xml and ods are tested). To test: - Run $ kshell k$ prove t/db_dependent/ImportExportFramework.t => SUCCESS: All green :-D - Sign off :-D Note: the biblio_framework* files are based on the original one on the patchset, and exported in 17.11 with different formats. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
100 lines
3.2 KiB
Perl
100 lines
3.2 KiB
Perl
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 1;
|
|
|
|
use t::lib::TestBuilder;
|
|
|
|
use File::Basename qw( dirname );
|
|
|
|
use Koha::Database;
|
|
use Koha::BiblioFrameworks;
|
|
use Koha::MarcSubfieldStructures;
|
|
use C4::ImportExportFramework;
|
|
|
|
my $schema = Koha::Database->new->schema;
|
|
my $builder = t::lib::TestBuilder->new;
|
|
|
|
subtest 'ImportFramework() tests' => sub {
|
|
|
|
plan tests => 3;
|
|
|
|
subtest 'CSV tests' => sub {
|
|
plan tests => 9;
|
|
|
|
run_tests('csv');
|
|
};
|
|
|
|
subtest 'ODS tests' => sub {
|
|
plan tests => 9;
|
|
|
|
run_tests('ods');
|
|
};
|
|
|
|
subtest 'XML tests' => sub {
|
|
plan tests => 9;
|
|
|
|
run_tests('xml');
|
|
};
|
|
};
|
|
|
|
sub run_tests {
|
|
|
|
my ($format) = @_;
|
|
|
|
$schema->storage->txn_begin;
|
|
|
|
my $data_filepath = dirname(__FILE__) . "/data/frameworks/biblio_framework.$format";
|
|
my $fw_1 = $builder->build_object({ class => 'Koha::BiblioFrameworks' });
|
|
|
|
my $result = C4::ImportExportFramework::ImportFramework( $data_filepath, $fw_1->id );
|
|
is( $result, 0, 'Import successful, no tags removed' );
|
|
|
|
my $nb_tags = $schema->resultset('MarcTagStructure')->search({ frameworkcode => $fw_1->id })->count;
|
|
is( $nb_tags, 4, "4 tags should have been imported" );
|
|
|
|
my $nb_subfields = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw_1->id })->count;
|
|
is( $nb_subfields, 12, "12 subfields should have been imported" );
|
|
|
|
# bad file tests
|
|
my $fw_2 = $builder->build_object({ class => 'Koha::BiblioFrameworks' });
|
|
$result = C4::ImportExportFramework::ImportFramework( '', $fw_2->id );
|
|
|
|
is( $result, -1, 'Bad file makes it return -1' );
|
|
|
|
$nb_tags = $schema->resultset('MarcTagStructure')->search({ frameworkcode => $fw_2->id })->count;
|
|
is( $nb_tags, 0, "0 tags should have been imported" );
|
|
|
|
$nb_subfields = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw_2->id })->count;
|
|
is( $nb_subfields, 0, "0 subfields should have been imported" );
|
|
|
|
# framework overwrite
|
|
$data_filepath = dirname(__FILE__) . "/data/frameworks/biblio_framework_smaller.$format";
|
|
|
|
$result = C4::ImportExportFramework::ImportFramework( $data_filepath, $fw_1->id );
|
|
is( $result, 5, 'Smaller fw import successful, 4 tags removed' );
|
|
|
|
$nb_tags = $schema->resultset('MarcTagStructure')->search({ frameworkcode => $fw_1->id })->count;
|
|
is( $nb_tags, 3, "3 tags should have been imported" );
|
|
|
|
$nb_subfields = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw_1->id })->count;
|
|
is( $nb_subfields, 8, "8 subfields should have been imported" );
|
|
|
|
$schema->storage->txn_rollback;
|
|
}
|