Koha/serials
Kyle M Hall 9f4b54a6d7 Bug 26604: "Generate next" button gives error on serials-collection.pl
In serials-collection.pl, the line

$frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity});

causes the error

Can't use string ("13") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Serials.pm line 2198.

This function call makes no sense, that subroutine always returns a list and doesn't take any parameters. I think it was meant to be GetSubscriptionFrequency which is in fact already called a few lines down.

Signed-off-by: kelly mcelligott <kelly@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

JD

Test plan:
1. Create a new subscription
  * When there is an irregular issue: Skip issue number
  * Select a frequency (not irregular)
  * Test prediction pattern and mark some "not published" (to fill the subscription.irregular DB field
2. Receive a first serial (mark it arrived, an "expected" one is created)
3. Claim the expected one
=> You have 1 arrived and 1 claimed.
It's the only way to not have an expected one and hit the else block in serials/serials-collection.pl
4. Generate next => boom

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-10-09 15:24:45 +02:00
..
acqui-search-result.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
acqui-search.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
add_user_search.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
checkexpiration.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
claims.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
create-numberpattern.pl
lateissues-export.pl Bug 18536: [QA Follow-up] Tiny regex simplification 2017-05-19 10:41:39 -04:00
reorder_members.pl Bug 20015: use Modern::Perl in Serials perl script 2018-02-05 09:46:45 -03:00
routing-preview.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
routing.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
serials-collection.pl Bug 26604: "Generate next" button gives error on serials-collection.pl 2020-10-09 15:24:45 +02:00
serials-edit.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
serials-home.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
serials-search.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
showpredictionpattern.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
subscription-add.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
subscription-batchedit.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
subscription-bib-search.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
subscription-detail.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
subscription-frequencies.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
subscription-frequency.pl
subscription-history.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
subscription-numberpattern.pl
subscription-numberpatterns.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
subscription-renew.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
viewalerts.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00