Jonathan Druart
450b629ed3
If you cancel holds in bulk, the list is not updated as we enqueued the task. But the "Update hold(s)" button will explode if clicked. Test plan: Place several holds on a bib record Use the "Cancel selected" link to cancel holds in bulk The job is enqueued and the hold list still show the holds you cancelled Click "Update holds" => Without this patch you get an ugly 500 Can't call method "found" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1060 => With this patch applied the table is refresh, no crash (and there is a warning in the log, that may not be necessary) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
110 lines
3.8 KiB
Perl
Executable file
110 lines
3.8 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
#script to modify reserves/requests
|
|
#written 2/1/00 by chris@katipo.oc.nz
|
|
#last update 27/1/2000 by chris@katipo.co.nz
|
|
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
use CGI qw ( -utf8 );
|
|
use List::MoreUtils qw( uniq );
|
|
use Try::Tiny;
|
|
|
|
use C4::Output;
|
|
use C4::Reserves qw( ModReserve ModReserveCancelAll );
|
|
use C4::Auth qw( get_template_and_user );
|
|
use Koha::DateUtils qw( dt_from_string );
|
|
|
|
my $query = CGI->new;
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "about.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
flagsrequired => { reserveforothers => 1 },
|
|
}
|
|
);
|
|
|
|
my @reserve_id = $query->multi_param('reserve_id');
|
|
my @rank = $query->multi_param('rank-request');
|
|
my @borrower = $query->multi_param('borrowernumber');
|
|
my @reservedates = $query->multi_param('reservedate');
|
|
my @expirationdates = $query->multi_param('expirationdate');
|
|
my @branch = $query->multi_param('pickup');
|
|
my @itemnumber = $query->multi_param('itemnumber');
|
|
my @biblionumber = $query->multi_param('biblionumber');
|
|
my $count=@rank;
|
|
|
|
@biblionumber = uniq @biblionumber;
|
|
|
|
my $CancelBiblioNumber = $query->param('CancelBiblioNumber');
|
|
my $CancelBorrowerNumber = $query->param('CancelBorrowerNumber');
|
|
my $CancelItemnumber = $query->param('CancelItemnumber');
|
|
|
|
# 2 possibilitys : cancel an item reservation, or modify or cancel the queded list
|
|
|
|
# 1) cancel an item reservation by function ModReserveCancelAll (in reserves.pm)
|
|
if ($CancelBorrowerNumber) {
|
|
ModReserveCancelAll($CancelItemnumber, $CancelBorrowerNumber);
|
|
$biblionumber[0] = $CancelBiblioNumber,
|
|
}
|
|
|
|
# 2) Cancel or modify the queue list of reserves (without item linked)
|
|
else {
|
|
for (my $i=0;$i<$count;$i++){
|
|
undef $itemnumber[$i] if !$itemnumber[$i];
|
|
my $suspend_until = $query->param( "suspend_until_" . $reserve_id[$i] );
|
|
my $cancellation_reason = $query->param("cancellation-reason");
|
|
my $params = {
|
|
rank => $rank[$i],
|
|
reserve_id => $reserve_id[$i],
|
|
expirationdate => $expirationdates[$i] ? dt_from_string($expirationdates[$i]) : undef,
|
|
branchcode => $branch[$i],
|
|
itemnumber => $itemnumber[$i],
|
|
defined $suspend_until ? ( suspend_until => $suspend_until ) : (),
|
|
cancellation_reason => $cancellation_reason,
|
|
};
|
|
if (C4::Context->preference('AllowHoldDateInFuture')) {
|
|
$params->{reservedate} = $reservedates[$i] ? dt_from_string($reservedates[$i]) : undef;
|
|
}
|
|
|
|
try {
|
|
ModReserve($params);
|
|
} catch {
|
|
if ($_->isa('Koha::Exceptions::ObjectNotFound')){
|
|
warn $_;
|
|
} else {
|
|
$_->rethrow;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
my $from=$query->param('from');
|
|
$from ||= q{};
|
|
if ( $from eq 'borrower'){
|
|
print $query->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$borrower[0]");
|
|
} elsif ( $from eq 'circ'){
|
|
print $query->redirect("/cgi-bin/koha/circ/circulation.pl?borrowernumber=$borrower[0]");
|
|
} else {
|
|
my $url = "/cgi-bin/koha/reserve/request.pl?";
|
|
$url .= "biblionumbers=" . join('/', @biblionumber);
|
|
print $query->redirect($url);
|
|
}
|