Koha/misc/translator
Marcel de Rooy fb62e8d1fc Bug 22236: Translation should generate tags with consistent attribute order
When running misc/translator/translate, the order of attributes in the translated templates is not consistent and may vary. This is caused by the random order of hash keys in perl.

This causes things like this in run 1:
<input type="submit" class="btn" value="Plaats aanvraag" />
And this in run 2:
<input value="Plaats aanvraag" type="submit" class="btn" />
As you can see, there is actually no difference apart from the order.

When comparing the result of various translation runs, I would rather get rid of such noise and only see the real changes.

The needed change is not trivial to find, but only requires a simple addition to a sort operation in tmpl_process3.pl. The current sort only makes sure that the '/' comes at the end. We should sort the names of the keys too when this value is 0 (just meaning: no end tag symbol).

Test plan:
[1] Run a translation without this patch and set a few templates aside.
[2] Run a translation with this patch.
[3] Run a compare (diff) on the templates copied in step 1. Verify that the
    only changes are found in the sort order of attributes in html tags.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-02-04 14:40:46 +00:00
..
po Translation updates for Koha 18.11.00 2018-11-26 22:22:14 -03:00
LangInstaller.pm Bug 21895: Fix path to POT file 2018-11-29 17:57:54 +00:00
tmpl_process3.pl Bug 22236: Translation should generate tags with consistent attribute order 2019-02-04 14:40:46 +00:00
TmplTokenizer.pm Bug 21481: (QA follow-up) Remove last reference to text-extract2 2018-10-05 15:03:18 +00:00
translate Bug 21480: misc/translator/translate does not work with perl 5.26 2018-10-03 17:33:37 +00:00
VerboseWarnings.pm Bug 16011: $VERSION - Remove the $VERSION init 2016-03-24 17:20:28 +00:00
xgettext.pl Bug 21481: Remove obsolete files from translation toolkit 2018-10-05 15:01:59 +00:00