c25dc92fd1
This patch does two things to improve the call number splitting algorithms:
1. It makes changes to ensure that cutter numbers are split correctly in ddcns
2. It moves custom/fiction/biography call number splitting to a separate algorithm.
Before they were incorrectly placed in ddcns.
This patch also modifies the call number splitting tests to accept call numbers from the
command line to allow quick testing of any give call number against a particular algorithm.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
63 lines
2.2 KiB
Perl
Executable file
63 lines
2.2 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 2 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along with
|
|
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
|
|
# Suite 330, Boston, MA 02111-1307 USA
|
|
#
|
|
# for context, see http://bugs.koha.org
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use Test::More;
|
|
|
|
BEGIN {
|
|
our $ccns = {};
|
|
if ($ARGV[0]) {
|
|
BAIL_OUT("USAGE: perl Labels_split_ccn.t 'BIO JP2 R5c.1' 'BIO,JP2,R5c.1'") unless $ARGV[1];
|
|
$ccns = {$ARGV[0] => [split (/,/,$ARGV[1])],};
|
|
}
|
|
else {
|
|
$ccns = {
|
|
'BIO JP2 R5c.1' => [qw(BIO JP2 R5 c.1)],
|
|
'FIC GIR J5c.1' => [qw(FIC GIR J5 c.1)],
|
|
'J DAR G7c.11' => [qw( J DAR G7 c.11)],
|
|
'MP3-CD F PARKER' => [qw(MP3-CD F PARKER)],
|
|
};
|
|
}
|
|
my $test_num = 1;
|
|
foreach (keys(%$ccns)) {
|
|
my $split_num += scalar(@{$ccns->{$_}});
|
|
$test_num += 2 * $split_num;
|
|
$test_num += 4;
|
|
}
|
|
plan tests => $test_num;
|
|
use_ok('C4::Labels::Label');
|
|
use vars qw($ccns);
|
|
}
|
|
|
|
foreach my $ccn (sort keys %$ccns) {
|
|
my (@parts, @expected);
|
|
ok($ccn, "ddcn: $ccn");
|
|
ok(@expected = @{$ccns->{$ccn}}, "split expected to produce " . scalar(@expected) . " pieces");
|
|
ok(@parts = C4::Labels::Label::_split_ccn($ccn), "C4::Labels::Label::_split_ccn($ccn)");
|
|
ok(scalar(@expected) == scalar(@parts), sprintf("%d of %d pieces produced", scalar(@parts), scalar(@expected)));
|
|
my $i = 0;
|
|
foreach my $unit (@expected) {
|
|
my $part;
|
|
ok($part = $parts[$i], "($ccn)[$i] populated: " . (defined($part) ? $part : 'UNDEF'));
|
|
ok((defined($part) and $part eq $unit), "($ccn)[$i] matches: $unit");
|
|
$i++;
|
|
}
|
|
}
|