Koha/tools
Tomas Cohen Arazi 1f62cbc618 Bug 29325: Fix commit_file.pl
This patch fixes the broken commit_file.pl script.

It doesn't deal with commiting the import from the UI.

To test:
1. Pick a file for staging:
   $ kshell
  k$ misc/stage_file.pl --file TestDataImportKoha.mrc
=> SUCCESS: All good
2. Commit!
  k$ misc/commit_file.pl --batch-number 1
=> FAIL: You see
DBIx::Class::Storage::DBI::_exec_txn_begin(): DBI Exception: DBD::mysql::db begin_work failed: Already in a transaction at /kohadevbox/koha/C4/Biblio.pm line 303
3. Apply this patch
4. Repeat 2
=> SUCCESS: Commit succeeds
5. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Bug 29325: (QA follow-up) Remove unexisting parameters of BatchRevertRecords

There is no interval and callback as in BatchCommitRecords.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Bug 29325: Call progress callback one last time to confirm comppletion

Previously after finishing the loop we were still in a transaction that never completed - we should report progress when done
one final time to commit the last records

To test:
1 - Stage a file with > 100 records
2 - Commit file
3 - Confirm batch is imported and no records left as staged

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Bug 29325: Fix import from staff client

same test as before, but via the staff client

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Bug 29325: Handle the transaction in BatchCommitRecords

Requiring the callback to commit was breaking reversion, and likely elsewhere

Let's simplify and say that the routine iteself will handle the txn and commit

TO test:
1 - Stage a file
2 - Import a file
3 - Revert a file
4 - Test staff client and command line

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-06-24 11:36:19 -03:00
..
csv-profiles MT2116: Addons to the CSV export 2010-02-17 07:51:33 -05:00
access_files.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
additional-contents.pl Bug 30904: (bug 24387 follow-up) Fix library modification of additional contents 2022-06-13 11:05:27 -03:00
ajax-inventory.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
automatic_item_modification_by_age.pl Bug 22827: Add age dependency on other fields than dateaccessioned 2022-04-08 15:49:16 +02:00
background-job-progress.pl Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
batch_delete_records.pl Bug 29771: Scalar context for split 2022-03-08 23:03:34 -10:00
batch_extend_due_dates.pl Bug 29380: Correct table name in joins to prevent errors 2021-11-03 15:40:52 +01:00
batch_record_modification.pl Bug 29771: Scalar context for split 2022-03-08 23:03:34 -10:00
batch_records_ajax.pl Bug 22785: Allow option to choose which record match is applied during import 2022-05-03 11:19:50 -10:00
batchMod.pl Bug 30525: Items batch modification broken 2022-04-21 13:41:36 -10:00
cleanborrowers.pl Bug 29843: Use in tools/cleanborrowers.pl 2022-02-10 14:44:23 -10:00
copy-holidays.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
csv-profiles.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
exceptionHolidays.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
export.pl Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
holidays.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
import_borrowers.pl Bug 29005: Add option to send welcome email from patron imports 2022-04-20 09:03:39 -10:00
inventory.pl Bug 29695: (follow-up) Remove C4::Reports::Guided::_get_column_defs 2022-04-12 11:40:16 +02:00
letter.pl Bug 30545: Replace the use of jQueryUI Accordion on the notices page 2022-05-02 11:22:58 -10:00
manage-marc-import.pl Bug 29325: Fix commit_file.pl 2022-06-24 11:36:19 -03:00
marc_modification_templates.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
modborrowers.pl Bug 29926: Add ability for superlibrarians to batch edit password expiration dates 2022-05-06 10:33:09 -10:00
newHolidays.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
overduerules.pl Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
picture-upload.pl Bug 6815: Capture member photo via webcam 2022-03-24 14:22:10 -10:00
problem-reports.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
quotes-upload.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
quotes.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
scheduler.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
showdiffmarc.pl Bug 17600: Fix missing C4::AuthoritiesMARC import 2021-07-29 15:34:25 +02:00
stage-marc-import.pl Bug 30525: Items batch modification broken 2022-04-21 13:41:36 -10:00
stockrotation.pl Bug 29771: Remove trivial cases 2022-03-08 23:03:34 -10:00
tools-home.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
upload-cover-image.pl Bug 30972: Don't replace biblio's local cover images when uploading an image's image 2022-06-20 10:39:34 -03:00
upload-file.pl Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
upload.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
viewlog.pl Bug 19532: (RM follow-up) More use of system preference 2022-03-14 23:11:12 -10:00