Main Koha release repository https://koha-community.org
Find a file
Kyle M Hall 218194fab0 Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library
Currently, when SingleBranchMode is enabled, nobody can change the
logged in library in Koha. To change it requires disable
SingleBranchMode, switching the library, and re-enabling it. It seems
reasonable to allow superlibrarians to switch the logged in library even
if SingleBranchMode is enabled.

Test Plan:
1) Apply this patch
3) Enable SingleBranchMode
4) Log in as a superlibrarian
5) Attempt to change the logged in branch
   This change should succeed
6) Log in as a non-superlibrarian account
7) Attempt to change the logged n branch
   This should not be allowed, as per Koha's current behavior

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I guess this doesn't do any harm even though the practical motivations
behind it, as described in the bug, seem otherwise solvable. If
SingleBranchMode is supposed to prevent librarians from switching their
logged in library why can they choose their library when they first log
in? Was SingleBranchMode supposed to only affect the OPAC originally? Or
should the login form be modified? This seems to be a band-aid on a
poorly-implemented feature.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch works as decribed. As this only adds a check for a superlibrarian
it seems safe and should not interfere with normal staff accounts.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2013-05-12 10:11:42 -04:00
acqui Bug 10044: Remove duplicate pagination on the pending orders page. 2013-05-01 22:58:27 -04:00
admin Revert "Bug 6554: Followup for preferences.pl" 2013-04-29 15:17:31 -07:00
authorities Revert "Bug 6554 - make Koha internally utf-8 clean" 2013-04-29 15:12:32 -07:00
basket Bug 9073 - Download option from the cart should match the menu button in lists 2012-11-25 18:08:46 -05:00
C4 Bug 9961: Add truncation support to QP driver 2013-05-08 09:44:23 -04:00
catalogue Revert "Bug 6554 - make Koha internally utf-8 clean" 2013-04-29 15:12:32 -07:00
cataloguing Bug 8278: build the structure with to_json instead of manually. 2013-05-08 09:49:55 -04:00
circ Revert "Bug 6554 Followup for circulation patron search" 2013-04-29 15:17:39 -07:00
debian Bug 10084 - YUI path wrong in CCSR theme with packages 2013-05-02 15:12:03 -07:00
docs Merge branch 'bug_7368' into 3.14-master 2013-05-01 07:58:41 -04:00
errors
etc Bug 9804 - Fix name for NORMARC biblio-koha-indexdefs.xml 2013-04-24 09:16:17 -04:00
install_misc Bug 9914: dependency updates for 3.12 2013-03-23 10:46:07 -04:00
installer Bug 10134 - set XSLT usage ON as default, for new Koha installs 2013-05-12 10:05:18 -04:00
Koha Bug 9961: Add truncation support to QP driver 2013-05-08 09:44:23 -04:00
koha-tmpl Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library 2013-05-12 10:11:42 -04:00
labels Bug 8943 - Add table sorting to labels - Followup - Sort pulldowns in batch export. 2013-03-31 08:33:42 -04:00
members Merge remote branch 'origin/new/bug6554_reverts' 2013-05-01 11:22:30 -07:00
misc Bug 10156 - Fix usr/bin/perl path for get_report_social_data.pl 2013-05-08 09:52:21 -04:00
offline_circ Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly. 2013-03-21 20:35:37 -04:00
opac Bug 10201 - Old OPAC patron update system should be removed 2013-05-12 09:54:07 -04:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patroncards Revert "Bug 9951: Followup for Tools" 2013-04-29 15:04:38 -07:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Merge remote branch 'origin/new/bug6554_reverts' 2013-05-01 11:22:30 -07:00
reserve Revert "Bug 6554 - make Koha internally utf-8 clean" 2013-04-29 15:12:32 -07:00
reviews
rotating_collections Bug 9605: rotating collections permissions are wrong 2013-03-30 22:11:05 -04:00
selenium
serials Revert "Bug 6554: Followup for serial search" 2013-04-29 15:17:18 -07:00
services Bug 7178: Acquisition item creation improvement 2012-03-26 11:07:23 +02:00
skel Bug 7804 - Add Koha Plugin System 2013-03-20 14:49:47 -04:00
sms
suggestion Bug 9226: Wrong branch filter after suggestion creation 2013-02-15 08:34:11 -05:00
svc Bug 9908 - Fixing OCLC Connexion Client 2013-03-29 21:29:10 -04:00
t Bug 8300: Add mechanized unit test for batch import 2013-05-01 07:57:11 -04:00
tags Merge remote branch 'origin/new/bug6554_reverts' 2013-05-01 11:22:30 -07:00
test
tmp/modified_authorities
tools Merge remote branch 'origin/new/bug6554_reverts' 2013-05-01 11:22:30 -07:00
virtualshelves Bug 7788: [SIGNED-OFF] Followup: GetShelf call in addbybiblio script corrected 2012-05-22 12:06:26 +02:00
xt Bug 9802 - add test case to ensure man pages have correct XML 2013-03-20 15:11:10 -04:00
.htaccess
.mailmap
about.pl Bug 6506: Followup add warning in the system information tab. 2013-05-01 08:44:11 -04:00
changelanguage.pl
edithelp.pl 7368 Typo in edithelp.pl warning 2013-04-18 09:47:58 -04:00
fix-perl-path.PL
help.pl Bug 8949: Trying to view help on a page without any help results in a nasty error 2012-11-05 08:39:23 -05:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
install-CPAN.pl
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 7440 - Remove NoZebra vestiges 2013-03-19 21:17:04 -04:00
INSTALL.opensuse Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.ubuntu Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.ubuntu.12.04 Bug 9267 - Ubuntu 12.04 install docs broken 2013-03-07 09:46:55 -05:00
INSTALL.ubuntu.lucid Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
koha_perl_deps.pl Bug 8485 - Make koha_perl_deps.pl batch friendly Added a -b flag for brief which outputs only the perl library name (Foo::BaR), and added a -r flag for required which filters the list to required=Yes perl libraries. 2012-08-31 17:35:49 +02:00
kohaversion.pl Bug 9681: Increment version number 2013-05-08 10:03:26 -04:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Revert "Bug 7167: New version for updatedatabase" 2012-12-27 14:02:56 -05:00
Makefile.PL Bug 9890 - Fix the new plugin system for package installs 2013-03-22 16:54:04 -04:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots
rewrite-config.PL Bug 7804 - Add Koha Plugin System 2013-03-20 14:49:47 -04:00

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/