889e1953ec
For changing the sequence of patrons on a routing list by changing one of the numbers via the pull downs, full serial permission is needed: To test: - Give your patron full serial permissions - Create a subscription and a routing list for it - Change the sequence on the routing list using the pull downs - Verify this works - Remove any of the serial sub permissions (claim serials or similar) - Verify changing the sequence now results in a permission error - Apply patch - Verify that the permission error is gone now - Remove the routing permission - Verify the permission error is back (but this seems to make sense) In general more fixes would be required to make all routing related features depend on the routing permission, but I think this fixes the bug making it depend on the correct permission. Followed test plan. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
38 lines
1.5 KiB
Perl
Executable file
38 lines
1.5 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 2 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with Koha; if not, write to the Free Software Foundation, Inc.,
|
|
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
|
|
# Routing.pl script used to create a routing list for a serial subscription
|
|
# In this instance it is in fact a setting up of a list of reserves for the item
|
|
# where the hierarchical order can be changed on the fly and a routing list can be
|
|
# printed out
|
|
use strict;
|
|
use warnings;
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth qw( checkauth );
|
|
use C4::Serials qw( reorder_members );
|
|
|
|
my $query = CGI->new;
|
|
my $subscriptionid = $query->param('subscriptionid');
|
|
my $routingid = $query->param('routingid');
|
|
my $rank = $query->param('rank');
|
|
|
|
checkauth( $query, 0, { serials => 'routing' }, 'intranet' );
|
|
|
|
reorder_members( $subscriptionid, $routingid, $rank );
|
|
|
|
print $query->redirect(
|
|
"/cgi-bin/koha/serials/routing.pl?subscriptionid=$subscriptionid");
|
|
|