Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/includes
History
Owen Leonard 23265158fc Bug 16754: Use validation plugin in budgets, planning, and contracts 
This patch removes the custom javascript form validation from three
templates: Budgets, budget planning, and contracts. Validation via the
validation plugin is done instead.

This patch also removes use of event attributes like onclick and
onchange. Also changed: I added the "Required" text next to required
fields as necessary.

To test, apply the patch and go to Administration -> Budgets.

- Test the budget creation process for adding, editing, and duplicating
  budgets. In all cases:
  - The start date and end date should be required
  - You should be warned if you enter an end date which falls before the
    start date.
  - The description should be required
  - The budget amount should be required to be a number

To test the budget planning page:

Note that much of the JS removed from this template was unused. It
looked for inputs by the name 'est_total' which don't exist.

- When viewing the table of funds for a budget, select a choice from the
  'planning' toolbar menu.
  - Verify that after entering a numeric value in any cell, the
    'remaning' value at the end of the row is correctly updated.
  - Verify that after entering non-numeric data an error is displayed.
  - Verify that clicking the 'auto-fill' button at the end of the row
    works to fill any empty or zero-value fields with the remaning funds
    available.

To test the vendor contracts page:

- Go to Acquisitions -> Vendor -> Contracts
- Add or edit a contract
  - Confirm that name, start date, and end date are required.
  - Confirm that you are warned if you enter an end date which falls
    before the start date.

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-10-17 12:42:04 +00:00
..
catalogue Bug 13618: Fix item search 2018-08-17 15:55:12 +00:00
csv_headers Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
modals Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
str Bug 21068: Remove NorwegianPatronDB related code 2018-08-30 13:40:29 +00:00
virtualshelves/merge Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
account_offset_type.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
accounttype.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
acquisitions-add-to-basket.inc Bug 21398: Make search field mandatory when adding to a basket from an existing record 2018-09-28 19:21:24 +00:00
acquisitions-menu.inc Bug 11911: Add a separate permission for managing suggestions 2018-07-23 15:34:20 +00:00
acquisitions-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
acquisitions-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
additem.js.inc
admin-items-search-field-form.inc Bug 13618: Remove filter when assigning array 2018-08-17 16:53:56 +00:00
admin-menu.inc Bug 7651: (follow-up) Correct visibility on admin sidebar 2018-07-18 17:45:21 +00:00
adv-search.inc Bug 13272: (follow-up) add missing type="text" 2018-10-01 11:18:32 +00:00
auth-finder-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
authorities-search-results.inc Bug 19550: (QA follow-up) Add missing [% USE %] 2018-09-07 15:55:01 +00:00
authorities-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
authorities-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
authorities.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
authorities_js.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
av-build-dropbox.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
biblio-default-view.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
biblio-view-menu.inc Bug 11897: (QA follow-up) Template filter fixes 2018-10-09 15:46:06 +00:00
blocked-fines.inc Bug 21454: Remove html filter for Price filtered variables 2018-10-01 13:56:34 +00:00
blocking_errors.inc Bug 13618: Remove html filter for STOP and deal with existing USE raw 2018-08-17 15:55:14 +00:00
borrower_debarments.inc Bug 13272: (follow-up) fix concerns from comment #5 2018-10-01 11:18:31 +00:00
branch-selector.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
browser-strings.inc
budgets-active-currency.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
budgets-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
budgets-admin-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
calendar.inc Bug 16754: Use validation plugin in budgets, planning, and contracts 2018-10-17 12:42:04 +00:00
cat-menu.inc
cat-search.inc Bug 13272: Adds type="text" to inputs missing it 2018-10-01 11:18:30 +00:00
cat-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
catalog-strings.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
cataloging-search.inc Bug 13272: (follow-up) add missing type="text" 2018-10-01 11:18:32 +00:00
cateditor-ui.inc Bug 20785: Advanced Editor does not honor MarcFieldDocURL 2018-09-28 19:38:06 +00:00
cateditor-widgets-marc21.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
chart.inc Bug 17282: add template's variable filters 2018-10-01 13:56:36 +00:00
checkin-search.inc Bug 13272: (follow-up) add missing type="text" 2018-10-01 11:18:32 +00:00
checkouts-table-footer.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
checkouts-table.inc Bug 19719: (follow-up) Show description instead of code 2018-08-22 13:22:18 +00:00
circ-menu.inc Bug 7996: Correct wrong permissions for modification log 2018-08-22 11:47:10 +00:00
circ-nav.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
circ-patron-search-results.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
circ-search.inc Bug 13272: Adds type="text" to inputs missing it 2018-10-01 11:18:30 +00:00
cities-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
columns_settings.inc Bug 18791: Export visible columns only 2018-04-13 13:55:22 -03:00
contracts-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
country-list.inc
currencies-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
datatables.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
date-format.inc
delimiter_text.inc Bug 19910: Use span to make translators happy 2018-04-04 16:06:56 -03:00
doc-head-close-receipt.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
doc-head-close.inc Bug 21352: Add missing USE statements 2018-10-03 17:45:58 +00:00
doc-head-open.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
empty_line.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
facets.inc Bug 13618: Fix BLOCKs 2018-08-17 15:55:09 +00:00
form-blocks.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
format_price.inc
greybox.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
guided-reports-view.inc Bug 19856: Improve styling of reports sidebar 2018-03-23 11:45:38 -03:00
header.inc Bug 20217: Make header's catalog search menu into a split button 2018-09-16 00:27:50 +00:00
holds_table.inc Bug 13272: (follow-up) add missing type="text" 2018-10-01 11:18:32 +00:00
home-search.inc Bug 13272: Adds type="text" to inputs missing it 2018-10-01 11:18:30 +00:00
html_helpers.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
ill-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
installer-doc-head-close.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
installer-strings.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
intranet-bottom.inc Bug 21352: Add missing USE statements 2018-10-03 17:45:58 +00:00
intranetstylesheet.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
js_includes.inc Bug 15734: Use To.json to filter audio alerts 2018-10-09 15:45:03 +00:00
labels-toolbar.inc Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
langmenu-staff-top.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
letters-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-alt-address-style-de.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-alt-address-style-fr.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-alt-address-style-us.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-alt-contact-style-de.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-alt-contact-style-fr.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-alt-contact-style-us.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-display-address-style-de.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-display-address-style-fr.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-display-address-style-us.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-display-alt-address-style-de.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-display-alt-address-style-fr.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-display-alt-address-style-us.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-main-address-style-de.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-main-address-style-fr.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-main-address-style-us.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
members-toolbar.inc Bug 21068: Remove NorwegianPatronDB related code 2018-08-30 13:40:29 +00:00
merge-record-strings.inc
merge-record.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
messaging-preference-form.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
noadd-warnings.inc
onboarding_messages.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
page-numbers.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
password_check.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
patron-article-requests.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
patron-search-box.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
patron-search.inc Bug 13272: Adds type="text" to inputs missing it 2018-10-01 11:18:30 +00:00
patron-title.inc Bug 13618: Deal with span in patron-title 2018-08-17 15:55:11 +00:00
patron-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
patroncards-errors.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
patroncards-toolbar.inc Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
patrons-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
permissions.inc Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
popup-bottom.inc Bug 13618: Manually replace missing .raw 2018-08-17 15:55:10 +00:00
prefs-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
prefs-menu.inc Bug 19538: Move EnableAdvancedCatalogingEdtor from 'Labs' to 'Cataloging' 2018-04-11 16:45:09 -03:00
quotes-toolbar.inc
quotes-upload-toolbar.inc
reports-menu.inc Bug 19856: (follow-up) Improve styling of reports sidebar 2018-03-23 11:45:38 -03:00
reports-toolbar.inc Bug 17282: add template's variable filters 2018-10-01 13:56:36 +00:00
resort_form.inc
rotating-collections-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
search_indexes.inc Bug 9968: Fix wrong index for Standard number in advanced and label search 2018-10-09 11:04:24 +00:00
select2.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
serials-menu.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
serials-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
serials-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
slip-print.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
stockrotation-toolbar.inc Bug 11897: (QA follow-up) Template filter fixes 2018-10-09 15:46:06 +00:00
strings.inc Bug 21029: Make "Suspend until:" translatable 2018-07-06 10:13:52 +00:00
subscriptions-search.inc
subtypes_unimarc.inc
suggestions-add-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
timepicker.inc
tools-item-action.inc
tools-menu.inc Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
tools-nomatch-action.inc
tools-overlay-action.inc
validator-strings.inc
vendor-menu.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
virtualshelves-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
wysiwyg-systempreferences.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
xslt-handler.inc Bug 20272: Changes for Breeding.pm and Record.pm 2018-07-02 12:12:49 +00:00
z3950-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
z3950_search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00