Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/nl-search.tt
Jonathan Druart dcd1f5d48c Bug 13618: Add html filters to all the variables 
Here we go, next step then.
As we did not fix the performance issue when autofiltering
the variables (see bug 20975), the only solution we have is to add the
filters explicitely.

This patch has been autogenerated (using add_html_filters.pl, see next
pathces) and add the html filter to all the variables displayed in the
template.
Exceptions are made (using the new 'raw' TT filter) to the variable we
already listed in the previous versions of this patch.

To test:
- Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated
data which contain <script> tags

- Remove them from borrower_debarments.comments (there are allowed here)
update  borrower_debarments set comment="html tags possible here";

- From the interface hit page and try to catch alert box.
If you find one it means you find a possible XSS.
To know where it comes from:
* note the exact URL where you found it
* note the alert box content
* Dump your DB and search for the string in the dump to identify its
location (for instance table.field)

Next:
* Ideally we would like to use the raw filter when it is not necessary
to HTML escape the variables (in big loop for instance)
* Provide a QA script to catch missing filters (we want html, uri, url
or raw, certainly others that I am forgetting now)
* Replace the html filters with uri when needed (!)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-08-17 15:55:05 +00:00

180 lines
10 KiB
Text
Raw Blame History

[% USE raw %]
[% USE Asset %]
[% USE KohaDates %]
[% USE Branches %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]
<title>Search the Norwegian national patron database</title>
[% INCLUDE 'doc-head-close.inc' %]
</head>
<body id="pat_nl_search" class="pat">
[% INCLUDE 'header.inc' %]
[% INCLUDE 'patron-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/members/members-home.pl">Patrons</a> &rsaquo; Search the Norwegian national patron database</div>
<div id="doc3" class="yui-t2">
<div id="bd">
<div id="yui-main">
<div class="yui-b">
<h1>Search the Norwegian national patron database</h1>
[% IF (error) %]
<div class="dialog alert">
[% IF ( error.nlenabled == 0 ) %]<p>You need to activate this function with the NorwegianPatronDBEnable system preference in order to use it.</p>[% END %]
[% IF ( error.endpoint == 0 ) %]<p>You need to specify an endpoint with the NorwegianPatronDBEndpoint system preference.</p>[% END %]
[% IF ( error.userpass == 0 ) %]<p>You need to fill in the NorwegianPatronDBUsername and NorwegianPatronDBPassword system preferences in order to use this function.</p>[% END %]
[% IF ( error == 'COULD_NOT_ADD_PATRON' ) %]<p>Could not add a new patron.</p>[% END %]
</div>
[% ELSE %]
[% SET nl_search_form_title='Search' %]
[% INCLUDE 'nl-search-form.tt' %]
[% END %]
[% IF ( local_result ) %]
<h3>Existing patrons</h3>
<ul>
[% FOREACH patron IN local_result %]
<li>[% patron.firstname | html %] [% patron.surname | html %] [% patron.cardnumber | html %] |
<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% patron.borrowernumber | html %]">Details</a> |
<a href="/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=[% patron.borrowernumber | html %]">Edit</a> |
<a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% patron.borrowernumber | html %]">Check out</a>
</li>
[% END %]
</ul>
[% END %]
[% IF ( result ) %]
[% IF result.antall_poster_returnert == 0 %]
<div class="dialog alert">
<p>No results found in the Norwegian national patron database. Message: "[% result.melding | html %]"</p>
</div>
[% ELSE %]
<h3>Results from the Norwegian national patron database</h3>
<div class="yui-g">
<div class="yui-u first">
[% PROCESS patron_detail p=result.respons_poster.0 %]
</div>
[% IF ( result.respons_poster.1 ) %]
<div class="yui-u">
[% PROCESS patron_detail p=result.respons_poster.1 %]
</div>
[% END %]
</div>
[% END %]
[% END %]
</div>
</div>
<div class="yui-b">
[% INCLUDE 'circ-menu.inc' %]
</div>
</div>
[% MACRO jsinclude BLOCK %]
[% INCLUDE 'str/members-menu.inc' %]
[% Asset.js("js/members-menu.js") | $raw %]
[% END %]
[% INCLUDE 'intranet-bottom.inc' %]
[% BLOCK patron_detail %]
<div class="rows">
<h4>[% p.navn | html_entity %]</h4>
<ol>
[% IF ( p.kjonn ) %]<li><span class="label">Gender:</span> [% p.kjonn | html_entity %]</li>[% END %]
[% IF ( p.fdato ) %]<li><span class="label">Date of birth:</span> [% p.fdato | html_entity %]</li>[% END %]
[% IF ( p.lnr ) %]<li><span class="label">Card number:</span> [% p.lnr | html_entity %]</li>[% END %]
[% IF ( p.fnr_hash ) %]<li><span class="label">Social security number hash:</span> [% p.fnr_hash | html_entity %]</li>[% END %]
[% IF ( p.epost ) %]<li><span class="label">Email:</span> [% p.epost | html_entity %]</li>[% END %]
[% IF ( p.epost_sjekk ) %]<li><span class="label">Email check:</span> [% p.epost_sjekk | html_entity %]</li>[% END %]
[% IF ( p.tlf_mobil ) %]<li><span class="label">Phone - mobile:</span> [% p.tlf_mobil | html_entity %]</li>[% END %]
[% IF ( p.tlf_hjemme ) %]<li><span class="label">Phone - home:</span> [% p.tlf_hjemme | html_entity %]</li>[% END %]
[% IF ( p.tlf_jobb ) %]<li><span class="label">Phone - work:</span> [% p.tlf_jobb | html_entity %]</li>[% END %]
[% IF ( p.p_adresse1 ) %]<li><span class="label">Address:</span> [% p.p_adresse1 | html_entity %]</li>[% END %]
[% IF ( p.p_adresse2 ) %]<li><span class="label">Address 2:</span> [% p.p_adresse2 | html_entity %]</li>[% END %]
[% IF ( p.p_postnr ) %]<li><span class="label">Zip/Postal code:</span> [% p.p_postnr | html_entity %]</li>[% END %]
[% IF ( p.p_sted ) %]<li><span class="label">City:</span> [% p.p_sted | html_entity %]</li>[% END %]
[% IF ( p.p_land ) %]<li><span class="label">Country:</span> [% p.p_land | html_entity %]</li>[% END %]
[% IF ( p.p_sjekk ) %]<li><span class="label">Check:</span> [% p.p_sjekk | html_entity %]</li>[% END %]
[% IF ( p.m_adresse1 ) %]<li><span class="label">Address:</span> [% p.m_adresse1 | html_entity %]</li>[% END %]
[% IF ( p.m_adresse2 ) %]<li><span class="label">Address 2:</span> [% p.m_adresse2 | html_entity %]</li>[% END %]
[% IF ( p.m_postnr ) %]<li><span class="label">Zip/Postal code:</span> [% p.m_postnr | html_entity %]</li>[% END %]
[% IF ( p.m_sted ) %]<li><span class="label">City:</span> [% p.m_sted | html_entity %]</li>[% END %]
[% IF ( p.m_land ) %]<li><span class="label">Country:</span> [% p.m_land | html_entity %]</li>[% END %]
[% IF ( p.m_sjek ) %]<li><span class="label">Check:</span> [% p.m_sjekk | html_entity %]</li>[% END %]
[% IF ( p.m_gyldig_til ) %]<li><span class="label">Valid until:</span> [% p.m_gyldig_til | html_entity %]</li>[% END %]
[% IF ( p.pin ) %]<li><span class="label">PIN:</span> [% p.pin | html_entity %]</li>[% END %]
[% IF ( p.passord ) %]<li><span class="label">Password:</span> [% p.passord | html_entity %]</li>[% END %]
[% IF ( p.feide ) %]<li><span class="label">FEIDE:</span> [% p.feide | html_entity %]</li>[% END %]
[% IF ( p.folkeregsjekk_dato ) %]<li><span class="label">Population registry date check:</span> [% p.folkeregsjekk_dato | html_entity %]</li>[% END %]
[% IF ( p.hjemmebibliotek ) %]<li><span class="label">Home library:</span> [% p.hjemmebibliotek | html_entity %]</li>[% END %]
[% IF ( p.opprettet ) %]<li><span class="label">Created:</span> [% p.opprettet | html_entity %]</li>[% END %]
[% IF ( p.opprettet_av ) %]<li><span class="label">Created by:</span> [% p.opprettet_av | html_entity %]</li>[% END %]
[% IF ( p.sist_endret ) %]<li><span class="label">Last changed:</span> [% p.sist_endret | html_entity %]</li>[% END %]
[% IF ( p.sist_endret_av ) %]<li><span class="label">Last changed by:</span> [% p.sist_endret_av | html_entity %]</li>[% END %]
[% IF ( p.gyldig_til ) %]<li><span class="label">Valid until:</span> [% p.gyldig_til | html_entity %]</li>[% END %]
[% IF ( p.prim_kontakt ) %]<li><span class="label">Primary contact:</span> [% p.prim_kontakt | html_entity %]</li>[% END %]
</ol>
<form action="nl-search.pl" method="POST">
<input type="hidden" name="op" value="save" />
<input type="hidden" name="navn" value="[% p.navn | html_entity %]" />
<input type="hidden" name="kjonn" value="[% p.kjonn | html_entity %]" />
<input type="hidden" name="fdato" value="[% p.fdato | html_entity %]" />
<input type="hidden" name="lnr" value="[% p.lnr | html_entity %]" />
<input type="hidden" name="fnr_hash" value="[% p.fnr_hash | html_entity %]" />
<input type="hidden" name="p_adresse1" value="[% p.p_adresse1 | html_entity %]" />
<input type="hidden" name="p_adresse2" value="[% p.p_adresse2 | html_entity %]" />
<input type="hidden" name="p_postnr" value="[% p.p_postnr | html_entity %]" />
<input type="hidden" name="p_sted" value="[% p.p_sted | html_entity %]" />
<input type="hidden" name="p_land" value="[% p.p_land | html_entity %]" />
<input type="hidden" name="p_sjekk" value="[% p.p_sjekk | html_entity %]" />
<input type="hidden" name="m_adresse1" value="[% p.m_adresse1 | html_entity %]" />
<input type="hidden" name="m_adresse2" value="[% p.m_adresse2 | html_entity %]" />
<input type="hidden" name="m_postnr" value="[% p.m_postnr | html_entity %]" />
<input type="hidden" name="m_sted" value="[% p.m_sted | html_entity %]" />
<input type="hidden" name="m_land" value="[% p.m_land | html_entity %]" />
<input type="hidden" name="m_sjekk" value="[% p.m_sjekk | html_entity %]" />
<input type="hidden" name="m_gyldig_til" value="[% p.m_gyldig_til | html_entity %]" />
<input type="hidden" name="pin" value="[% p.pin | html %]" />
<input type="hidden" name="passord" value="[% p.passord | html_entity %]" />
<input type="hidden" name="feide" value="[% p.feide | html_entity %]" />
<input type="hidden" name="folkeregsjekk_dato" value="[% p.folkeregsjekk_dato | html_entity %]" />
<input type="hidden" name="hjemmebibliotek" value="[% p.hjemmebibliotek | html_entity %]" />
<input type="hidden" name="opprettet" value="[% p.opprettet | html_entity %]" />
<input type="hidden" name="opprettet_av" value="[% p.opprettet_av | html_entity %]" />
<input type="hidden" name="sist_endret" value="[% p.sist_endret | html_entity %]" />
<input type="hidden" name="sist_endret_av" value="[% p.sist_endret_av | html_entity %]" />
<input type="hidden" name="gyldig_til" value="[% p.gyldig_til | html_entity %]" />
<input type="hidden" name="epost" value="[% p.epost | html_entity %]" />
<input type="hidden" name="epost_sjekk" value="[% p.epost_sjekk | html_entity %]" />
<input type="hidden" name="tlf_mobil" value="[% p.tlf_mobil | html_entity %]" />
<input type="hidden" name="tlf_hjemme" value="[% p.tlf_hjemme | html_entity %]" />
<input type="hidden" name="tlf_jobb" value="[% p.tlf_jobb | html_entity %]" />
<input type="hidden" name="prim_kontakt" value="[% p.prim_kontakt | html_entity %]" />
<input type="submit" value="Import this patron" />
as
<select name="categorycode">
[% FOREACH c IN categories %]
<option value="[% c.categorycode | html %]">[% c.description | html %]</option>
[% END %]
</select>
</form>
</div>
[% END %]
View git blame Copy permalink