Koha/acqui
Nick Clemens 781f34e504 Bug 35892: Populate order price using GetMarcPrice if no price specified
Previously this happened after the fact, automagically, if no price was included in the order record. We should
rather load the Marc price into the order form if we don't have a price form the '...ToOrder' system preferences

To test:

Setup -- Set systempreferences below

MarcFieldsToOrder:
price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q

MarcItemFieldsToOrder:
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

Stage the attached bib-303.marcxml file
Add to basket from the staged file
Note that item prices are populated as '6.50' from 949$g
Cancel
Update MarcFieldsToOrder and map price to "020$c"
Add to basket from the staged file
Note the price is not populated, because 020$c contains a dollar sign
Cancel
Apply patch, restart all
Add to basket from the staged file
Note the price is now correctly populated from fallback to GetMarcPrice

Note: GetMarcPrice does some automatic munging, that's why 020$c on it's own doesn't work - this could be done to fields in MarcFieldsToOrder/MarcItemFieldsToOrder but this would be an enhancement.
This bug simply restores the previous behavious, but does it on the front end and is more obvious to the user

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit c3035f7e1b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2024-03-11 11:05:16 +01:00
..
acqui-home.pl Bug 29287: Add child funds to display of parent funds on acqui home 2022-03-01 22:47:46 -10:00
addorder.pl Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order 2023-10-18 15:41:35 -03:00
addorderiso2709.pl Bug 35892: Populate order price using GetMarcPrice if no price specified 2024-03-11 11:05:16 +01:00
ajax-getauthvaluedropbox.pl
basket.pl Bug 34752: (QA follow-up) perltidy 2023-10-18 10:25:55 -03:00
basketgroup.pl Bug 31257: Add a new English 1 page layout to export basketgroup 2022-10-11 10:44:10 -03:00
basketheader.pl Bug 34509: Use select2 to load vendors on basket creation 2023-08-29 14:37:07 -03:00
booksellers.pl Bug 33103: Prevent vendors to be displayed several times in the search result 2023-04-20 15:48:42 -03:00
cancelorder.pl Bug 29658: Fix crash on cancelling cancelled order 2022-09-12 16:14:47 -03:00
check_budget_total.pl
check_uniqueness.pl
duplicate_orders.pl Bug 14092: (QA follow-up) Avoid fiddling with the hash in the template 2023-10-20 16:31:15 -03:00
edi_ean.pl
edifactmsgs.pl
edimsg.pl Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
finishreceive.pl Bug 34022: Adjust items data structure 2023-06-23 09:46:45 -03:00
histsearch.pl Bug 14092: (QA follow-up) Avoid fiddling with the hash in the template 2023-10-20 16:31:15 -03:00
invoice-files.pl
invoice.pl Bug 32705: Display the column if 1 order has an invoice price 2023-03-06 14:04:12 -03:00
invoices.pl Bug 31115: Add additional field filtering for invoice search 2022-10-24 14:11:07 -03:00
lateorders-export.pl Bug 15348: trivial code simplification 2022-09-16 10:36:53 -03:00
lateorders.pl Bug 33653: Use filter_by_active instead 2023-05-09 10:58:07 -03:00
moddeliverydate.pl Bug 15348: (follow-up) Fix modal to edit delivery date 2022-09-16 10:36:57 -03:00
modordernotes.pl
neworderempty.pl Bug 34708: Add ability to modify orderline to increase quantity 2023-11-09 10:15:05 -03:00
newordersubscription.pl
newordersuggestion.pl Bug 23991: Move SearchSuggestion to Koha::Suggestions 2022-06-27 12:30:28 -03:00
ordered.pl Bug 31631: Optionally use tax-exclusive values for calculating fund values 2023-10-18 15:41:35 -03:00
orderreceive.pl Bug 8179: Add vendor id on breadcrumb link 2023-05-17 14:44:42 -03:00
parcel.pl Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
parcels.pl Bug 31115: Add support for additional fields for invoices 2022-10-24 14:11:06 -03:00
showorder.pl
spent.pl Bug 31631: (QA follow-up) Tidy code 2023-10-18 15:41:37 -03:00
supplier.pl Bug 33103: Add the ability to create vendor aliases 2023-04-20 15:48:36 -03:00
transferorder.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
uncertainprice.pl
updatesupplier.pl Bug 33104: Add the ability to create vendor interfaces 2023-05-05 10:18:46 -03:00
vendor_issues.pl Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage 2024-01-15 15:22:24 +01:00
z3950_search.pl