2615ee1010
This patch allows merging of records with many items without the web server timing out. Test plan: Without the patch: - Create 2 records (one with e.g. 1000 items). - Do a cataloguing search that displays both records, select them and click "Merge selected". - Choose the record with many items as the one to be eliminated. - Start the merging. - After a while the web server should give you a timeout error (the merging process may still continue) With the patch: - Do the same as above - This time verify that the records are merged without timeout - Create a new biblio with an item - Add with the item: * acquisition order * hold (reserve) - Merge the biblio to another one - Verify that the item and its related data was moved - Verify that tests pass: prove -v t/db_dependent/Koha/Biblio.t prove -v t/db_dependent/Koha/Item.t prove -v t/db_dependent/Koha/SearchEngine/Indexer.t Signed-off-by: Michal Denar <black23@gmail.com> Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
108 lines
2.9 KiB
Perl
Executable file
108 lines
2.9 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Move an item from a biblio to another
|
|
#
|
|
# Copyright 2009 BibLibre
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth qw( get_template_and_user );
|
|
use C4::Output qw( output_html_with_http_headers );
|
|
use C4::Items qw( MoveItemFromBiblio );
|
|
use C4::Context;
|
|
use C4::ClassSource;
|
|
use C4::Acquisition qw/GetOrderFromItemnumber ModOrder GetOrder/;
|
|
|
|
use Koha::Biblios;
|
|
|
|
|
|
use MARC::File::XML;
|
|
|
|
use Koha::Items;
|
|
|
|
my $query = CGI->new;
|
|
|
|
# The biblio to move the item to
|
|
my $biblionumber = $query->param('biblionumber');
|
|
|
|
# The barcode of the item to move
|
|
my $barcode = $query->param('barcode');
|
|
|
|
my ($template, $loggedinuser, $cookie) = get_template_and_user(
|
|
{
|
|
template_name => "cataloguing/moveitem.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
flagsrequired => { editcatalogue => 'edit_items' },
|
|
}
|
|
);
|
|
|
|
|
|
|
|
my $biblio = Koha::Biblios->find( $biblionumber );
|
|
$template->param(biblio => $biblio);
|
|
$template->param(biblionumber => $biblionumber);
|
|
|
|
# If we already have the barcode of the item to move and the biblionumber to move the item to
|
|
if ( $barcode && $biblionumber ) {
|
|
|
|
my $itemnumber;
|
|
my $item = Koha::Items->find( { barcode => $barcode } );
|
|
|
|
if ($item) {
|
|
|
|
$itemnumber = $item->itemnumber;
|
|
my $frombiblionumber = $item->biblionumber;
|
|
my $to_biblio = Koha::Biblios->find($biblionumber);
|
|
|
|
my $moveresult = $item->move_to_biblio($to_biblio);
|
|
if ($moveresult) {
|
|
$template->param(
|
|
success => 1,
|
|
from_biblio => Koha::Biblios->find($frombiblionumber),
|
|
);
|
|
}
|
|
else {
|
|
$template->param(
|
|
error => 1,
|
|
errornonewitem => 1
|
|
);
|
|
}
|
|
|
|
}
|
|
else {
|
|
$template->param(
|
|
error => 1,
|
|
errornoitem => 1
|
|
);
|
|
}
|
|
$template->param(
|
|
barcode => $barcode,
|
|
itemnumber => $itemnumber,
|
|
);
|
|
|
|
}
|
|
else {
|
|
$template->param( missingparameter => 1 );
|
|
if ( !$barcode ) { $template->param( missingbarcode => 1 ); }
|
|
if ( !$biblionumber ) { $template->param( missingbiblionumber => 1 ); }
|
|
}
|
|
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|