Koha/circ
Nick Clemens 26722f2a08 Bug 35518: Check authentication and set userenv before fetching userenv variables
Currently we get the userenv before we have set it correctly for the session

To test:
 1 - Sign in as a user with fast cataloging permission
 2 - Bring up a patron, type gibberish into barcode field to get a fast cataloging link
 3 - Check the link, it should have your current signed in barcode
 4 - Sign in to a different browser with a different user and at a different branch
 5 - Bring up a aptron in circulation and type gibberish into barcode field to get a fast cataloging link
 6 - It may have your branch, but it may also have the other user's branch from the other window
 7 - Keep entering gibberish to get a link until one user has the correct branch
 8 - Then switch to the other browser, and keep entering gibberish, watch the branchcode change
 9 - Apply patch, restart all
10 - Test switching between browsers. generating fast cataloging links
11 - Users should now consistently have the correct branch

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 90b6f68616)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2024-02-15 10:48:08 +01:00
..
add_message.pl Bug 21699: Allow circulation messages to be editable 2023-05-05 10:18:55 -03:00
article-request-slip.pl Bug 29771: Scalar context for split 2022-03-08 23:03:34 -10:00
article-requests.pl Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
bookcount.pl Bug 33149: Use template wrapper for breadcrumbs: Circulation part 1 2023-04-06 09:29:26 -03:00
branchoverdues.pl Bug 25835: Include overdues with fines in overdues_report permission 2024-01-15 15:17:43 +01:00
branchtransfers.pl Bug 30409: barcodedecode() should always trim barcode 2022-06-14 07:54:58 -03:00
checkout-notes.pl Bug 29380: Correct table name in joins to prevent errors 2021-11-03 15:40:52 +01:00
circulation-home.pl Bug 33961: Remove built-in offline circ tool 2023-06-12 16:53:25 -03:00
circulation.pl Bug 35518: Check authentication and set userenv before fetching userenv variables 2024-02-15 10:48:08 +01:00
curbside_pickups.pl Bug 32883: (QA follow-up) Adjust ordering for pickups 2023-03-27 11:49:33 +02:00
del_message.pl Bug 29903: Prevent messages to be deleted from unauthorised users 2022-02-02 21:05:29 -10:00
hold-transfer-slip.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
on-site_checkouts.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
overdue.pl Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
pendingreserves.pl Bug 32421: Add collection column to holds to pull 2023-03-14 09:06:14 -03:00
renew.pl Bug 33444: Update AddRenewal to take a hashref of params 2023-07-19 12:06:52 -03:00
request-article.pl Bug 34519: Add a template plugin for fetch searchable patron attributes 2023-11-08 17:52:37 -03:00
reserveratios.pl Bug 34938: (QA follow-up) Tidy code 2023-11-08 11:41:32 -03:00
returns.pl Bug 29007: Add cancellation reason input on check in 2023-11-10 10:59:35 -03:00
set-library.pl Bug 30624: (QA follow-up) Use C4:Context to get permissions 2023-03-13 15:23:20 -03:00
transfer-slip.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
transfers_to_send.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
transferstoreceive.pl Bug 24295: Remove GetTransfers from circ/transferstoreceive.pl 2022-08-26 15:42:52 -03:00
view_holdsqueue.pl Bug 28966: Prefetch patron data for holds queue viewer 2023-07-25 16:25:38 -03:00
waitingreserves.pl Bug 35003: Make cancelled hold requests filter by branch 2023-10-27 16:54:06 -03:00