Koha/t
Jonathan Druart 268f03d34b
Bug 24546: Fix intentions of build_sample_item in Club/Hold.t
In t/db_dependent/Koha/Club/Hold.t:
my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode });
my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode });

build_sample_item takes either "library" or the item's attributes.
branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong.

Test plan:
 % prove t/db_dependent/Koha/Club/Hold.t
must return green before and after this patch

Note that this patch also remove an uneeded debugging statement.

This has been caught by bug 24363.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-01-31 13:55:55 +00:00
..
Acquisition
Biblio Bug 23392: Don't display private notes in MARC21 2019-10-24 10:58:02 +01:00
Budgets
Circulation Bug 24361: Remove warning from GetAgeRestriction 2020-01-13 14:48:36 +00:00
db_dependent Bug 24546: Fix intentions of build_sample_item in Club/Hold.t 2020-01-31 13:55:55 +00:00
edi_testfiles
etc
External
Koha Bug 24528: Add a syntax to x-koha-embed to specify counts 2020-01-31 13:50:45 +00:00
LangInstaller/templates
lib Bug 24149: Skip Koha::Statistics for TestBuilder tests 2020-01-24 08:47:43 +00:00
Members
Number
Search
Serials
SIP
Test
00-checkdatabase-version.t
00-deprecated.t
00-load.t
00-merge-conflict-markers.t
00-testcritic.t
00-valid-xml.t
Auth.t
Auth_with_shibboleth.t Bug 23042: Correct shib param escaping 2019-11-27 11:30:20 +00:00
AuthoritiesMarc_MARC21.t
AuthoritiesMarc_UNIMARC.t
AuthUtils.t
Barcodes_annual.t
Barcodes_EAN13.t
Barcodes_hbyymmincr.t
Barcodes_incremental.t
Biblio.t
Biblio2.t
Bookseller.t
Boolean.t
Budgets.t
Calendar.t
Charset.t
Circulation_barcodedecode.t
ClassSortRoutine.t
ClassSortRoutine_Dewey.t
ClassSortRoutine_Generic.t
ClassSortRoutine_LCC.t
ClassSource.t
Context.t
Contract.t
Creators.t
DateUtils.t
Debug.t
dummy.t
Edifact.t Bug 21580: Add test for message buyer_ean method 2019-10-10 08:23:04 +01:00
EdiInvoice.t
Ediorder.t
Ediordrsp.t
EdiTransport.t
Form_MessagingPreferences.t
HtmlTags.t
Images.t
ImportBatch.t
Installer_PerlDependencies.t
Installer_PerlModules.t
Installer_pm.t
ItemCirculationAlertPreference.t
Koha.t Bug 23768: Adjust the test for invalid ISBN 2019-11-07 13:02:59 +00:00
Koha_Email.t
Koha_MetadataRecord.t
Koha_Template_Plugin_Cache.t
Koha_Template_Plugin_Koha.t
Koha_Util_FrameworkPlugin.t
Koha_Util_MARC.t
Labels.t
Labels_split_ccn.t
Labels_split_ddcn.t
Labels_split_lccn.t
Labels_split_Regex.t
LangInstaller.t
Languages.t
Letters.t
Log.t
Logger.t
Makefile.t
Matcher.t
Members_Attributes.t
Members_AttributeTypes.t
Members_Messaging.t
OpenLibrarySearch.t
Output.t
Output_JSONStream.t
Patron.t
Patroncards.t
Patroncards_Batch.t
Patroncards_Lib.t
Patroncards_Patroncard.t
Patroncards_Profile.t
Patroncards_Template.t
perlcriticrc
Prices.t Bug 24408: Do not compare floats with precision in tests 2020-01-13 13:42:45 +00:00
Print.t
QueryParser.t
RecordProcessor.t
Ris.t
Scheduler.t
Scrubber.t
Search.t
Search_PazPar2.t
SimpleMARC.t
SMS.t
SocialData.t
Stats.t
SuggestionEngine.t
SuggestionEngine_AuthorityFile.t
template_filters.t
timezones.t
TmplToken.t
Token.t
XSLT.t