dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
71 lines
2.9 KiB
Text
71 lines
2.9 KiB
Text
[% USE KohaDates %]
|
|
[% SET footerjs = 1 %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Serials › Subscription history</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
|
|
<body id="ser_subscription_history" class="ser">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'serials-search.inc' %]
|
|
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a> › Subscription history</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
<h1>Subscription history for [% title | html %]</h1>
|
|
<div id="subscription_form_history">
|
|
<form method="post" action="/cgi-bin/koha/serials/subscription-history.pl">
|
|
<input type="hidden" name="op" value="mod" />
|
|
<input type="hidden" name="subscriptionid" value="[% subscriptionid | html %]" />
|
|
<p>Hint : you can update the serial history manually. This can be useful for an old subscription or to clean the existing history. Modify those fields with care, as future serial receive will continue to update them automatically.</p>
|
|
<table>
|
|
<tr>
|
|
<td>Subscription start date</td>
|
|
<td>
|
|
<input type="text" size="10" name="histstartdate" value="[% histstartdate | $KohaDates %]" class="datepickerfrom" /> (start date of the 1st subscription)
|
|
<div class="hint">[% INCLUDE 'date-format.inc' %]</div>
|
|
</td>
|
|
</tr>
|
|
<tr>
|
|
<td>Subscription end date</td>
|
|
<td>
|
|
<input type="text" size="10" name="histenddate" value="[% histenddate | $KohaDates %]" class="datepickerto" />(if empty, subscription is still active)
|
|
<div class="hint">[% INCLUDE 'date-format.inc' %]</div>
|
|
</td>
|
|
</tr>
|
|
<tr>
|
|
<td>Received issues</td>
|
|
<td><textarea name="receivedlist" cols="60" rows="5">[% receivedlist | html %]</textarea></td>
|
|
</tr>
|
|
<tr>
|
|
<td>Missing issues</td>
|
|
<td><textarea name="missinglist" cols="60" rows="5">[% missinglist | html %]</textarea></td>
|
|
</tr>
|
|
<tr>
|
|
<td>Note for OPAC</td>
|
|
<td><textarea name="opacnote" cols="60" rows="5">[% opacnote | html %]</textarea></td>
|
|
</tr>
|
|
<tr>
|
|
<td>Note for staff</td>
|
|
<td><textarea name="librariannote" cols="60" rows="5">[% librariannote | html %]</textarea></td>
|
|
</tr>
|
|
</table>
|
|
<input type="submit" value="Save subscription history" />
|
|
</form>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="yui-b">
|
|
[% INCLUDE 'serials-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% INCLUDE 'calendar.inc' %]
|
|
[% END %]
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|