Jonathan Druart
286be46e8a
The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed to return the patrons with an issue history older than a given date. It would make more sense to return a list of Koha::Patrons. On the way, the code from AnonymiseIssueHistory will be moved as well to anonymise_issue_history. Note that these 2 subroutines are strongly linked: one is used to know the number of patrons we will anonymise the history, the other one is used to anonymise the issues history. The problem is that the first one is not used to do the action, but only for displayed purpose. In some cases, these 2 values can differ, which could be confusing. Case 1: The logged in librarian is not superlibrarian and IndependentBranches is set: if 2+ patrons from different libraries match the date parameter, the interface will display "Checkout history for 2 patrons will be anonymized", when actually only 1 will be. Case 2: If 2+ patrons match the date parameter but one of them has his privacy set to forever (privacy=0), the same issue will appear. This patch moves the code from C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons->search_patrons_to_anonymise and from C4::Circulation::AnonymiseIssueHistory to Koha::Patrons->anonymise_issue_history Test plan: 1/ Confirm the 2 issues and make sure they are fixed using the Batch patron anonymization tool (tools/cleanborrowers.pl) 2/ At the OPAC, use the 'Immediate deletion' button to delete all your reading history (regardless the setting of the privacy rule) 3/ Use the cronjob script (misc/cronjobs/batch_anonymise.pl) to anonymise patrons. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
235 lines
7.4 KiB
Perl
Executable file
235 lines
7.4 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
#
|
|
# Written by Antoine Farnault antoine@koha-fr.org on Nov. 2006.
|
|
|
|
=head1 cleanborrowers.pl
|
|
|
|
This script allows to do 2 things.
|
|
|
|
=over 2
|
|
|
|
=item * Anonymise the borrowers' issues if issue is older than a given date. see C<datefilter1>.
|
|
|
|
=item * Delete the borrowers who has not borrowed since a given date. see C<datefilter2>.
|
|
|
|
=back
|
|
|
|
=cut
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
use C4::Members;
|
|
use C4::Circulation; # AnonymiseIssueHistory.
|
|
use Koha::DateUtils qw( dt_from_string output_pref );
|
|
use Koha::Patron::Categories;
|
|
use Koha::Patrons;
|
|
use Date::Calc qw/Today Add_Delta_YM/;
|
|
use Koha::Patrons;
|
|
use Koha::List::Patron;
|
|
|
|
my $cgi = new CGI;
|
|
|
|
# Fetch the paramater list as a hash in scalar context:
|
|
# * returns paramater list as tied hash ref
|
|
# * we can edit the values by changing the key
|
|
# * multivalued CGI paramaters are returned as a packaged string separated by "\0" (null)
|
|
my $params = $cgi->Vars;
|
|
|
|
my $step = $params->{step} || 1;
|
|
my $not_borrowed_since = # the date which filter on issue history.
|
|
$params->{not_borrowed_since}
|
|
? dt_from_string $params->{not_borrowed_since}
|
|
: undef;
|
|
my $last_issue_date = # the date which filter on borrowers last issue.
|
|
$params->{last_issue_date}
|
|
? dt_from_string $params->{last_issue_date}
|
|
: undef;
|
|
my $borrower_dateexpiry =
|
|
$params->{borrower_dateexpiry}
|
|
? dt_from_string $params->{borrower_dateexpiry}
|
|
: undef;
|
|
my $borrower_lastseen =
|
|
$params->{borrower_lastseen}
|
|
? dt_from_string $params->{borrower_lastseen}
|
|
: undef;
|
|
my $patron_list_id = $params->{patron_list_id};
|
|
|
|
my $borrower_categorycode = $params->{'borrower_categorycode'} || q{};
|
|
|
|
# getting the template
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{ template_name => "tools/cleanborrowers.tt",
|
|
query => $cgi,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { tools => 'delete_anonymize_patrons', catalogue => 1 },
|
|
}
|
|
);
|
|
|
|
my $branch = $params->{ branch } || '*';
|
|
$template->param( current_branch => $branch );
|
|
$template->param( OnlyMine => C4::Context->only_my_library );
|
|
|
|
if ( $step == 2 ) {
|
|
|
|
my %checkboxes = map { $_ => 1 } split /\0/, $params->{'checkbox'};
|
|
|
|
my $patrons_to_delete;
|
|
if ( $checkboxes{borrower} ) {
|
|
$patrons_to_delete = GetBorrowersToExpunge(
|
|
_get_selection_params(
|
|
$not_borrowed_since,
|
|
$borrower_dateexpiry,
|
|
$borrower_lastseen,
|
|
$borrower_categorycode,
|
|
$patron_list_id,
|
|
$branch
|
|
)
|
|
);
|
|
}
|
|
_skip_borrowers_with_nonzero_balance($patrons_to_delete);
|
|
|
|
my $patrons_to_anonymize =
|
|
$checkboxes{issue}
|
|
? $branch eq '*'
|
|
? Koha::Patrons->search_patrons_to_anonymise($last_issue_date)
|
|
: Koha::Patrons->search_patrons_to_anonymise( $last_issue_date, $branch )
|
|
: undef;
|
|
|
|
$template->param(
|
|
patrons_to_delete => $patrons_to_delete,
|
|
patrons_to_anonymize => $patrons_to_anonymize,
|
|
patron_list_id => $patron_list_id,
|
|
);
|
|
}
|
|
|
|
elsif ( $step == 3 ) {
|
|
my $do_delete = $params->{'do_delete'};
|
|
my $do_anonym = $params->{'do_anonym'};
|
|
|
|
my ( $totalDel, $totalAno, $radio ) = ( 0, 0, 0 );
|
|
|
|
# delete members
|
|
if ($do_delete) {
|
|
my $patrons_to_delete = GetBorrowersToExpunge(
|
|
_get_selection_params(
|
|
$not_borrowed_since,
|
|
$borrower_dateexpiry,
|
|
$borrower_lastseen,
|
|
$borrower_categorycode,
|
|
$patron_list_id,
|
|
$branch
|
|
)
|
|
);
|
|
_skip_borrowers_with_nonzero_balance($patrons_to_delete);
|
|
|
|
$totalDel = scalar(@$patrons_to_delete);
|
|
$radio = $params->{'radio'};
|
|
for ( my $i = 0 ; $i < $totalDel ; $i++ ) {
|
|
$radio eq 'testrun' && last;
|
|
my $borrowernumber = $patrons_to_delete->[$i]->{'borrowernumber'};
|
|
my $patron = Koha::Patrons->find($borrowernumber);
|
|
$radio eq 'trash' && $patron->move_to_deleted;
|
|
$patron->delete;
|
|
}
|
|
$template->param(
|
|
do_delete => '1',
|
|
TotalDel => $totalDel
|
|
);
|
|
}
|
|
|
|
# Anonymising all members
|
|
if ($do_anonym) {
|
|
#FIXME: anonymisation errors are not handled
|
|
my $rows = Koha::Patrons->search_patrons_to_anonymise( $last_issue_date )->anonymise_issue_history( $last_issue_date );
|
|
$template->param(
|
|
do_anonym => $rows,
|
|
);
|
|
}
|
|
|
|
$template->param(
|
|
trash => ( $radio eq "trash" ) ? (1) : (0),
|
|
testrun => ( $radio eq "testrun" ) ? 1: 0,
|
|
);
|
|
} else { # $step == 1
|
|
my @all_lists = GetPatronLists();
|
|
my @non_empty_lists;
|
|
foreach my $list (@all_lists){
|
|
my @patrons = $list->patron_list_patrons();
|
|
if( scalar @patrons ) { push(@non_empty_lists,$list) }
|
|
}
|
|
$template->param( patron_lists => [ @non_empty_lists ] );
|
|
}
|
|
|
|
my $patron_categories = Koha::Patron::Categories->search_limited({}, {order_by => ['description']});
|
|
|
|
$template->param(
|
|
step => $step,
|
|
not_borrowed_since => $not_borrowed_since,
|
|
borrower_dateexpiry => $borrower_dateexpiry,
|
|
borrower_lastseen => $borrower_lastseen,
|
|
last_issue_date => $last_issue_date,
|
|
borrower_categorycodes => $patron_categories,
|
|
borrower_categorycode => $borrower_categorycode,
|
|
);
|
|
|
|
#writing the template
|
|
output_html_with_http_headers $cgi, $cookie, $template->output;
|
|
|
|
sub _skip_borrowers_with_nonzero_balance {
|
|
my $borrowers = shift;
|
|
my $balance;
|
|
@$borrowers = map {
|
|
my $patron = Koha::Patrons->find( $_->{borrowernumber} );
|
|
my $balance = $patron->account->balance;
|
|
(defined $balance && $balance != 0) ? (): ($_);
|
|
} @$borrowers;
|
|
}
|
|
|
|
sub _get_selection_params {
|
|
my ($not_borrowed_since, $borrower_dateexpiry, $borrower_lastseen,
|
|
$borrower_categorycode, $patron_list_id, $branch) = @_;
|
|
|
|
my $params = {};
|
|
$params->{not_borrowed_since} = output_pref({
|
|
dt => $not_borrowed_since,
|
|
dateformat => 'iso',
|
|
dateonly => 1
|
|
}) if $not_borrowed_since;
|
|
$params->{expired_before} = output_pref({
|
|
dt => $borrower_dateexpiry,
|
|
dateformat => 'iso',
|
|
dateonly => 1
|
|
}) if $borrower_dateexpiry;
|
|
$params->{last_seen} = output_pref({
|
|
dt => $borrower_lastseen,
|
|
dateformat => 'iso',
|
|
dateonly => 1
|
|
}) if $borrower_lastseen;
|
|
$params->{category_code} = $borrower_categorycode if $borrower_categorycode;
|
|
$params->{patron_list_id} = $patron_list_id if $patron_list_id;
|
|
|
|
if ( defined $branch and $branch ne '*' ) {
|
|
$params->{ branchcode } = $branch;
|
|
}
|
|
|
|
return $params;
|
|
};
|