Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/opac
History
Tomas Cohen Arazi 28bcc5aa68 Bug 22420: Remove wrong calculation on approved tags 
Before the patch from bug 14385, the passed structure (that is returned
by get_approval_rows() looks like:

\ [
    [0] {
        approved           1,
        approved_by        51,
        approved_by_name   undef,
        date_approved      "2019-02-26 15:36:42",
        term               "another",
        weight_total       3
    },
    [1] {
    ...

After the introduced 'filtering', we loose the information about the
term weight!:

\ [
    [0] {
        approved               1,
        author                 "Heylin, Clinton.",
        biblionumber           1,
        borrowernumber         51,
        date_created           "2019-02-26 15:36:37",
        language               undef,
        subtitle               [],
        tag_id                 1,
        term                   "word",
        time_created_display   "15:36:37",
        title                  "E Street shuffle :",
        visible                1,
        XSLTBloc               "
            <<<BUNCH OF GENERATED HTML HERE>>>
    ...

The code even calls GetMarcBiblio. This needs to be reverted as it is
plain wrong. If it was worth removing *some* biblios from the
weight_total value, then this calculation should be done somewhere else,
without fetching the MARC data again.

Signed-off-by: Claudio  <costalc@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-05-07 10:48:23 +00:00
..
clubs Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
errors Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
external/overdrive
rss
sci Bug 22739: Test SelfCheckInTimeout <> 0, not just defined 2019-04-25 10:05:00 +00:00
sco Bug 22538: Add a noticeable alert about waiting holds 2019-04-17 12:25:25 +00:00
svc Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
ilsdi.pl Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
maintenance.pl
oai.pl
opac-account-pay-paypal-return.pl Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
opac-account-pay-return.pl
opac-account-pay.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-account.pl Bug 22588: (follow-up) Simplify getting accounts even more 2019-04-16 13:17:33 +00:00
opac-addbybiblionumber.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-alert-subscribe.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-article-request-cancel.pl Bug 22068: (QA follow-up) Return meaningful error codes 2019-04-10 19:58:31 +00:00
opac-authorities-home.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-authoritiesdetail.pl Bug 21871: (QA follow-up) C4::Biblio qw(GetMarcUrls) 2019-01-30 12:12:21 +00:00
opac-basket.pl Bug 19241: Waiting items show as available in the cart 2019-04-25 10:21:19 +00:00
opac-blocked.pl
opac-browser.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
opac-course-details.pl
opac-course-reserves.pl
opac-detail.pl Bug 8995: (follow-up) Add tests, move open_url/coins routines to Koha namespace 2019-04-29 15:34:10 +00:00
opac-discharge.pl
opac-downloadcart.pl Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
opac-downloadshelf.pl Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
opac-export.pl Bug 22075: Fix encoding problem with RIS export in OPAC 2019-04-11 11:47:17 +00:00
opac-ics.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-idref.pl
opac-illrequests.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-image.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-imageviewer.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-ISBDdetail.pl Bug 22696: Prefetch items too 2019-04-24 10:56:34 +00:00
opac-issue-note.pl
opac-main.pl Bug 22318: Example implementation: OpacNavRight system preference 2019-04-18 10:47:03 +00:00
opac-MARCdetail.pl Bug 22735: Resolve internal server error on missing item type 2019-04-24 10:36:30 +00:00
opac-memberentry.pl Bug 10796: Use $category->effective_change_password in the OPAC 2019-04-12 02:32:07 +00:00
opac-messaging.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-modrequest-suspend.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-modrequest.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-mymessages.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-news-rss.pl
opac-overdrive-search.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-passwd.pl Bug 10796: Use $category->effective_change_password in the OPAC 2019-04-12 02:32:07 +00:00
opac-password-recovery.pl Bug 21890: (QA follow-up) Use List::Util::any 2019-04-12 02:32:04 +00:00
opac-patron-consent.pl Bug 20819: Add your consents tab to opac-user 2018-09-20 13:45:26 +00:00
opac-patron-image.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-privacy.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-ratings-ajax.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-ratings.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-readingrecord.pl Bug 11969: Show patrons star rating on their reading history 2019-04-17 12:25:25 +00:00
opac-recordedbooks-search.pl Bug 17602: Fix few minor QA issues 2018-10-01 13:56:56 +00:00
opac-registration-verify.pl Bug 10796: Use $category->effective_change_password in the OPAC 2019-04-12 02:32:07 +00:00
opac-renew.pl Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
opac-request-article.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-reserve.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-restrictedpage.pl
opac-retrieve-file.pl
opac-review.pl Bug 21986: Do not escape quotation marks when cataloguing 2018-12-14 13:33:28 +00:00
opac-routing-lists.pl
opac-search-history.pl
opac-search.pl Bug 22010: Check preferences for ebook integration 2019-04-30 11:42:51 +00:00
opac-sendbasket.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-sendshelf.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-serial-issues.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-shareshelf.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-shelves.pl Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean 2019-05-02 13:40:26 +00:00
opac-showmarc.pl Bug 20083: (follow-up) use same logic in opac-showmarc 2018-04-04 15:45:34 -03:00
opac-showreviews.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-suggestions.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-tags.pl Bug 22420: Remove wrong calculation on approved tags 2019-05-07 10:48:23 +00:00
opac-tags_subject.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-topissues.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-user.pl Bug 22521: Update UI to use accountlines.status 2019-04-17 16:49:36 +00:00
tracklinks.pl
unapi Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00