dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
168 lines
9.5 KiB
Text
168 lines
9.5 KiB
Text
[% USE AuthorisedValues %]
|
|
[% USE Branches %]
|
|
[% USE ItemTypes %]
|
|
[% USE KohaDates %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Serials › Batch edit</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
[% INCLUDE 'calendar.inc' %]
|
|
</head>
|
|
<body id="ser_subscription-batchedit" class="ser">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'serials-search.inc' %]
|
|
|
|
<div id="breadcrumbs">
|
|
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
|
|
›
|
|
<a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
|
|
›
|
|
Batch edit
|
|
</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
<h1>Subscription batch edit</h1>
|
|
|
|
<div>
|
|
<p>You are about to edit the following subscriptions:</p>
|
|
<table>
|
|
<thead>
|
|
<tr>
|
|
<th>ISSN</th>
|
|
<th>Title</th>
|
|
<th>Vendor</th>
|
|
<th>Location</th>
|
|
<th>Library</th>
|
|
<th>Item type</th>
|
|
<th>Public notes</th>
|
|
<th>Nonpublic notes</th>
|
|
<th>Call number</th>
|
|
<th>Create item when receiving</th>
|
|
<th>Expiration date</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
[% FOREACH subscription IN subscriptions %]
|
|
<tr>
|
|
<td>[% subscription.biblio.biblioitem.issn | html %]</td>
|
|
<td><a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscription.subscriptionid | html %]">[% subscription.biblio.title | html %] (#[% subscription.subscriptionid | html %])</a></td>
|
|
<td><a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% subscription.vendor.id | html %]">[% subscription.vendor.name | html %]</a></td>
|
|
<td>[% AuthorisedValues.GetByCode('LOC', subscription.location) | html %]</td>
|
|
<td>[% Branches.GetName(subscription.branchcode) | html %]</td>
|
|
<td>[% ItemTypes.GetDescription( subscription.itemtype ) | html %]</td>
|
|
<td>[% subscription.notes | html %]</td>
|
|
<td>[% subscription.internalnotes | html %]</td>
|
|
<td>[% subscription.callnumber | html %]</td>
|
|
<td>
|
|
[% IF subscription.serialsadditems %]
|
|
<span>Yes</span>
|
|
[% ELSE %]
|
|
<span>No</span>
|
|
[% END %]
|
|
</td>
|
|
<td>[% subscription.enddate | $KohaDates %]</td>
|
|
</tr>
|
|
[% END %]
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
|
|
<form method="post">
|
|
[% FOREACH subscription IN subscriptions %]
|
|
<input type="hidden" name="subscriptionid" value="[% subscription.subscriptionid | html %]"/>
|
|
[% END %]
|
|
[% IF referrer %]
|
|
<input type="hidden" name="referrer" value="[% referrer | html %]"/>
|
|
[% END %]
|
|
<fieldset class="rows">
|
|
<ol>
|
|
<li>
|
|
<label for="booksellerid">Vendor: </label>
|
|
<select id="booksellerid" name="booksellerid">
|
|
<option value="">No change</option>
|
|
[% FOREACH bookseller IN booksellers %]
|
|
<option value="[% bookseller.id | html %]">[% bookseller.name | html %]</option>
|
|
[% END %]
|
|
</select>
|
|
</li>
|
|
<li>
|
|
<label for="location">Location: </label>
|
|
<select id="location" name="location">
|
|
<option value="">No change</option>
|
|
[% FOREACH av IN AuthorisedValues.Get('LOC') %]
|
|
<option value="[% av.authorised_value | html %]">[% av.lib | html %]</option>
|
|
[% END %]
|
|
</select>
|
|
</li>
|
|
<li>
|
|
<label for="branchcode">Library: </label>
|
|
<select id="branchcode" name="branchcode">
|
|
<option value="">No change</option>
|
|
[% FOREACH branch IN Branches.all %]
|
|
<option value="[% branch.branchcode | html %]">[% branch.branchname | html %]</option>
|
|
[% END %]
|
|
</select>
|
|
</li>
|
|
<li>
|
|
<label for="itemtype">Item type: </label>
|
|
<select id="itemtype" name="itemtype">
|
|
<option value="">No change</option>
|
|
[% FOREACH itemtype IN ItemTypes.Get() %]
|
|
<option value="[% itemtype.itemtype | html %]">[% itemtype.description | html %]</option>
|
|
[% END %]
|
|
</select>
|
|
</li>
|
|
<li>
|
|
<label for="notes">Public note: </label>
|
|
<textarea id="notes" name="notes" placeholder="No change"></textarea>
|
|
</li>
|
|
<li>
|
|
<label for="internalnotes">Nonpublic note: </label>
|
|
<textarea id="internalnotes" name="internalnotes" placeholder="No change"></textarea>
|
|
</li>
|
|
<li>
|
|
<label for="serialsadditems">Create item when receiving: </label>
|
|
<select id="serialsadditems" name="serialsadditems">
|
|
<option value="">No change</option>
|
|
<option value="0">No</option>
|
|
<option value="1">Yes</option>
|
|
</select>
|
|
|
|
</li>
|
|
<li>
|
|
<label for="enddate">Expiration date: </label>
|
|
<input type="text" class="datepicker" id="enddate" name="enddate" placeholder="No change"/>
|
|
</li>
|
|
[% FOREACH field IN additional_fields %]
|
|
<li>
|
|
<label for="field_[% field.id | html %]">[% field.name | html %]</label>
|
|
[% IF field.authorised_value_category %]
|
|
<select id="field_[% field.id | html %]" name="field_[% field.id | html %]">
|
|
<option value="">No change</option>
|
|
[% FOREACH av IN AuthorisedValues.Get(field.authorised_value_category) %]
|
|
<option value="[% av.authorised_value | html %]">[% av.lib | html %]</option>
|
|
[% END %]
|
|
</select>
|
|
[% ELSE %]
|
|
<input id="field_[% field.id | html %]" name="field_[% field.id | html %]" placeholder="No change"/>
|
|
[% END %]
|
|
</li>
|
|
[% END %]
|
|
</ol>
|
|
</fieldset>
|
|
|
|
<fieldset class="action">
|
|
<button type="submit" name="batchedit" value="1">Save</button>
|
|
<a class="cancel" href="[% referrer | html %]">Cancel</a>
|
|
</fieldset>
|
|
</form>
|
|
</div>
|
|
</div>
|
|
<div class="yui-b">
|
|
[% INCLUDE 'serials-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|