Koha/cataloguing/value_builder/stocknumberAV.pl
Katrin Fischer 5f227b42c1 Bug 14660: Fix stocknumberAV.pl cataloguing plugin
The cataloguing plugin stocknumberAV.pl is broken and no
longer generating numbers - this patch fixes it.

To test:
- Link a subfield to the plugin - usually it's 952$i or the UNIMARC
  equivalent in your MARC frameworks
- Set up a new authorised value INVENTORY, the code is an uppercase
  prefix - "B"
- The Descriptions is your starting number - 1
- The OPAC description remains empty
- Catalalog an item
- Enter B as stocknumber and activate the plugin by clicking on
  ... at the end of the field
- The number will not get added - Firebug shows an error:
  Undefined subroutine CGI::output_html_with_http_headers
- Apply patch
- Verify numbers are now generated and no errors are shown

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
2015-08-20 13:40:56 -03:00

101 lines
3.4 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright 2012 BibLibre SARL
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use C4::Auth;
use CGI qw ( -utf8 );
use C4::Context;
use C4::Output;
=head1 DESCRIPTION
This plugin is based on authorised values INVENTORY.
It is used for stocknumber computation.
If the user send an empty string, we return a simple incremented stocknumber.
If a prefix is submited, we look for the highest stocknumber with this prefix, and return it incremented.
In this case, a stocknumber has this form : "PREFIX 0009678570".
- PREFIX is an upercase word
- a space separator
- 10 digits, with leading 0s if needed
=cut
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my $res = qq{
<script type='text/javascript'>
function Clic$field_number() {
var code = document.getElementById('$field_number');
\$.ajax({
url: '/cgi-bin/koha/cataloguing/plugin_launcher.pl',
type: 'POST',
data: {
'plugin_name': 'stocknumberAV.pl',
'code' : code.value,
},
success: function(data){
var field = document.getElementById('$field_number');
field.value = data;
return 1;
}
});
}
</script>
};
return ($field_number,$res);
}
sub plugin {
my ($input) = @_;
my $code = $input->param('code');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{ template_name => "cataloguing/value_builder/ajax.tt",
query => $input,
type => "intranet",
authnotrequired => 0,
flagsrequired => { editcatalogue => '*' },
debug => 1,
}
);
my $dbh = C4::Context->dbh;
# If a prefix is submited, we look for the highest stocknumber with this prefix, and return it incremented
$code =~ s/ *$//g;
if ( $code =~ m/^[A-Z]+$/ ) {
my $sth = $dbh->prepare("SELECT lib FROM authorised_values WHERE category='INVENTORY' AND authorised_value=?");
$sth->execute( $code);
if ( my $valeur = $sth->fetchrow ) {
$template->param( return => $code . ' ' . sprintf( '%010s', ( $valeur + 1 ) ), );
my $sth2 = $dbh->prepare("UPDATE authorised_values SET lib=? WHERE category='INVENTORY' AND authorised_value=?");
$sth2->execute($valeur+1,$code);
} else {
$template->param( return => "There is no defined value for $code");
}
# The user entered a custom value, we don't touch it, this could be handled in js
} else {
$template->param( return => $code, );
}
output_html_with_http_headers $input, $cookie, $template->output;
}