b168f4a2e9
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
---|---|---|
.. | ||
holds | ||
rss | ||
social_data | ||
thirdparty | ||
advance_notices.pl | ||
archive_purchase_suggestions.pl | ||
automatic_item_modification_by_age.pl | ||
automatic_renewals.pl | ||
backup.sh | ||
batch_anonymise.pl | ||
build_browser_and_cloud.pl | ||
cart_to_shelf.pl | ||
check-url-quick.pl | ||
check-url.pl | ||
cleanup_database.pl | ||
cloud-kw.pl | ||
cloud-sample.conf | ||
CONFIGURE.gmail | ||
create_koc_db.pl | ||
crontab.example | ||
delete_items.pl | ||
delete_patrons.pl | ||
delete_records_via_leader.pl | ||
edi_cron.pl | ||
fines.pl | ||
gather_print_notices.pl | ||
import_webservice_batch.pl | ||
longoverdue.pl | ||
membership_expiry.pl | ||
merge_authorities.pl | ||
notice_unprocessed_suggestions.pl | ||
overdue_notices.pl | ||
patron_emailer.pl | ||
printoverdues.sh | ||
process_message_queue.pl | ||
purge_suggestions.pl | ||
reconcile_balances.pl | ||
remove_temporary_edifiles.pl | ||
runreport.pl | ||
serialsUpdate.pl | ||
share_usage_with_koha_community.pl | ||
sitemap.pl | ||
staticfines.pl | ||
stockrotation.pl | ||
update_patrons_category.pl | ||
update_totalissues.pl |