Fridolin Somers
2b54196b72
In checkouts table, the is an export form (when some exports syspref are enabled). When selecting some checkouts and selecting "ISO2709 with items" in export format combo-box, clicking on "Export" will select "ISO2709 without items" in the export format combo-box. This is quite strange. Its because the form as 2 inputs with same name and id "output_format" : an hidden input (the wanted arg for tools/export.pl) and a select (the export format combo-box). So an action meant on the hidden input impacts the select. This patch corrects by changing id and name of the export format combo-box : issues-table-output-format TEST plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "ISO2709 with items" in export format combo-box - Click on "Export" => Without patch, the export format combo-box changes to "ISO2709 without items" => With patch, the export format combo-box does not changes - Check the export file contains the items - Check exports "ISO2709 without items" and "CSV" are OK Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
76 lines
4.5 KiB
HTML
76 lines
4.5 KiB
HTML
[% USE Koha %]
|
|
<div id="checkouts">
|
|
[% IF ( issuecount ) %]
|
|
<div id="issues-table-loading-message">
|
|
<p>
|
|
<a id="issues-table-load-now-button" href="#" class="btn"><i class="fa fa-book"></i> Show checkouts</a>
|
|
</p>
|
|
</div>
|
|
<form name="issues" action="/cgi-bin/koha/tools/export.pl" method="post" class="checkboxed">
|
|
<table id="issues-table" style="width: 100% !Important;">
|
|
<thead>
|
|
<tr>
|
|
<th scope="col"> </th>
|
|
<th scope="col"> </th>
|
|
<th scope="col">Due date</th>
|
|
<th scope="col">Due date</th>
|
|
<th scope="col">Title</th>
|
|
<th scope="col">Item type</th>
|
|
<th scope="col">Location</th>
|
|
<th scope="col">Home library</th>
|
|
<th scope="col">Checked out on</th>
|
|
<th scope="col">Checked out from</th>
|
|
<th scope="col">Call no</th>
|
|
<th scope="col">Charge</th>
|
|
<th scope="col">Fine</th>
|
|
<th scope="col">Price</th>
|
|
<th scope="col">Renew <p class="column-tool"><a href="#" id="CheckAllRenewals">select all</a> | <a href="#" id="UncheckAllRenewals">none</a></p></th>
|
|
<th scope="col">Check in <p class="column-tool"><a href="#" id="CheckAllCheckins">select all</a> | <a href="#" id="UncheckAllCheckins">none</a></p></th>
|
|
<th scope="col">Export <p class="column-tool"><a href="#" id="CheckAllExports">select all</a> | <a href="#" id="UncheckAllExports">none</a></p></th>
|
|
</tr>
|
|
</thead>
|
|
[% INCLUDE 'checkouts-table-footer.inc' %]
|
|
</table>
|
|
|
|
<label for="issues-table-load-immediately">Always show checkouts immediately</label>
|
|
<input id="issues-table-load-immediately" type="checkbox" />
|
|
|
|
<div id="issues-table-actions">
|
|
<fieldset class="action">
|
|
[% IF ( CAN_user_circulate_override_renewals ) %]
|
|
[% IF CAN_user_circulate_override_renewals && Koha.Preference( 'AllowRenewalLimitOverride' ) %]
|
|
<label for="override_limit">Override renewal limit:</label>
|
|
<input type="checkbox" name="override_limit" id="override_limit" value="1" />
|
|
[% END %]
|
|
[% END %]
|
|
[% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]
|
|
<button class="btn" id="RenewCheckinChecked"><i class="fa fa-check"></i> Renew or check in selected items</button>
|
|
<button class="btn" id="RenewAll"><i class="fa fa-book"></i> Renew all</button>
|
|
[% END %]
|
|
</fieldset>
|
|
|
|
[% IF ( exports_enabled ) %]
|
|
<fieldset>
|
|
<label for="issues-table-output-format"><b>Export checkouts using format:</b></label>
|
|
<select name="issues-table-output-format" id="issues-table-output-format">
|
|
<option value="iso2709_995">ISO2709 with items</option>
|
|
<option value="iso2709">ISO2709 without items</option>
|
|
[% IF Koha.Preference('ExportWithCsvProfile') %]
|
|
<option value="csv">CSV</option>
|
|
[% END %]
|
|
</select>
|
|
|
|
<label for="export_remove_fields">Don't export fields:</label> <input type="text" id="export_remove_fields" name="export_remove_fields" value="[% export_remove_fields %]" title="Use for iso2709 exports" />
|
|
<input type="hidden" name="op" value="export" />
|
|
<input type="hidden" id="output_format" name="output_format" value="iso2709" />
|
|
<input type="hidden" id="dont_export_item" name="dont_export_item" value="0" />
|
|
<input type="hidden" id="record_type" name="record_type" value="bibs" />
|
|
<button class="btn btn-small" id="export_submit"><i class="fa fa-download"></i> Export</button>
|
|
</fieldset>
|
|
[% END %]
|
|
</div>
|
|
</form>
|
|
[% ELSE %]
|
|
<p>Patron has nothing checked out.</p>
|
|
[% END %]
|
|
</div>
|