Jonathan Druart
2b90ea2cb0
GetMember returned a patron given a borrowernumber, cardnumber or userid. All of these 3 attributes are defined as a unique key at the DB level and so we can use Koha::Patrons->find to replace this subroutine. Additionaly GetMember set category_type and description. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
96 lines
2.5 KiB
Perl
96 lines
2.5 KiB
Perl
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 5;
|
|
use Test::MockModule;
|
|
|
|
use C4::Biblio;
|
|
use C4::Circulation;
|
|
use C4::Items;
|
|
use C4::Members;
|
|
use Koha::Database;
|
|
use Koha::DateUtils;
|
|
use Koha::Patrons;
|
|
|
|
use t::lib::TestBuilder;
|
|
|
|
use MARC::Record;
|
|
|
|
my $schema = Koha::Database->schema;
|
|
$schema->storage->txn_begin;
|
|
my $builder = t::lib::TestBuilder->new;
|
|
|
|
my $library = $builder->build({ source => 'Branch' });
|
|
my $itemtype = $builder->build({ source => 'Itemtype' })->{itemtype};
|
|
my $patron_category = $builder->build({ source => 'Category' });
|
|
|
|
C4::Context->_new_userenv('DUMMY SESSION');
|
|
C4::Context->set_userenv(
|
|
undef, undef, undef, undef, undef,
|
|
$library->{branchcode},
|
|
$library->{branchname}
|
|
);
|
|
|
|
|
|
|
|
my $borrowernumber = AddMember(
|
|
firstname => 'my firstname',
|
|
surname => 'my surname',
|
|
categorycode => $patron_category->{categorycode},
|
|
branchcode => $library->{branchcode},
|
|
);
|
|
|
|
my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
|
|
my $record = MARC::Record->new();
|
|
my ( $biblionumber, $biblioitemnumber ) = AddBiblio( $record, '' );
|
|
|
|
my ( undef, undef, $itemnumber ) = AddItem(
|
|
{ homebranch => $library->{branchcode},
|
|
holdingbranch => $library->{branchcode},
|
|
barcode => 'i_dont_exist',
|
|
itype => $itemtype
|
|
},
|
|
$biblionumber
|
|
);
|
|
|
|
my $item = GetItem( $itemnumber );
|
|
|
|
is ( IsItemIssued( $item->{itemnumber} ), 0, "item is not on loan at first" );
|
|
|
|
AddIssue($borrower, 'i_dont_exist');
|
|
is ( IsItemIssued( $item->{itemnumber} ), 1, "item is now on loan" );
|
|
|
|
is(
|
|
DelItemCheck( $biblionumber, $itemnumber),
|
|
'book_on_loan',
|
|
'item that is on loan cannot be deleted',
|
|
);
|
|
|
|
AddReturn('i_dont_exist', $library->{branchcode});
|
|
is ( IsItemIssued( $item->{itemnumber} ), 0, "item has been returned" );
|
|
|
|
is(
|
|
DelItemCheck( $biblionumber, $itemnumber),
|
|
1,
|
|
'item that is not on loan can be deleted',
|
|
);
|
|
|
|
$schema->storage->txn_rollback;
|
|
|
|
1;
|