Main Koha release repository https://koha-community.org
Find a file
Tomas Cohen Arazi 2b92f43cc3 Bug 32528: Make safe_to_delete exit earlier on error conditions
This patch makes the `Koha::Item->safe_to_delete` method return right
after one of the checked conditions is met. This way we avoid further DB
queries and processing.

No behavior change is expected

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Item.t
=> SUCCESS: Tests pass!
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests STILL pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Bug 32528: Change return logic

Back to 1 return statement
Prevent the Koha::Result::Boolean instanciation duplication

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit cc58ca2a3c)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
2023-01-13 16:18:43 +00:00
acqui Bug 32457: Fix CGI vulnerability in addorder.pl 2022-12-15 13:59:18 +00:00
admin Bug 32348: Add library public in columns settings 2023-01-13 11:28:45 +00:00
api Bug 31160: Required fields in patron api 2022-12-15 13:31:52 +00:00
authorities Bug 30250: Use ApplyFrameworkDefaults when importing a record 2022-11-09 14:03:22 -03:00
basket
bin
C4 Bug 32456: Preserve date accessioned if a date is not explicitly passed 2023-01-13 11:33:57 +00:00
catalogue Bug 31543: Use query string, rather than query, to build link 2022-11-16 15:57:28 -03:00
cataloguing Bug 24606: (QA follow-up) Remove duplicate include 2022-11-11 15:47:36 -03:00
circ Bug 24860: (QA follow-up): Don't assume item group is set for all items 2022-11-04 19:41:45 -03:00
clubs
course_reserves
debian Bug 31675: Remove packages from debian/control that are no longer used 2022-12-08 11:09:18 +00:00
docs 22.11.00: Update history.txt 2022-11-25 15:20:02 -03:00
erm Bug 32030: Add missing sponsors 2022-11-09 12:25:44 -03:00
errors
etc Bug 32030: Add Apache RewriteRule 2022-11-08 09:43:48 -03:00
ill
installer Add executable flag to 221101000.pl 2023-01-12 10:56:05 +00:00
Koha Bug 32528: Make safe_to_delete exit earlier on error conditions 2023-01-13 16:18:43 +00:00
koha-tmpl Bug 31935: (follow-up) Make form look better 2023-01-13 15:56:40 +00:00
labels
lib/CGI/Session/Serialize
members Bug 32119: (bug 31422 follow-up) Fix add guarantee 2022-11-07 11:09:56 -03:00
misc Bug 32481: Limit prefetch size for background jobs worker 2023-01-13 16:16:35 +00:00
offline_circ
opac Bug 32445: (follow-up) Fix availability display on opac-course-details 2023-01-13 15:49:41 +00:00
patron_lists
patroncards
plugins
pos
recalls
reports
reserve
reviews
rotating_collections
serials
services
skel
suggestion Bug 32531: Restore behaviour of 'include archived' filter 2023-01-13 15:54:39 +00:00
svc
t Bug 32349: Remove TEST_QA 2023-01-13 16:12:41 +00:00
tags
tmp/modified_authorities
tools Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file 2022-11-15 18:44:30 -03:00
virtualshelves
xt Bug 32349: Remove find-nonutf8 tests 2023-01-13 16:13:12 +00:00
.editorconfig
.eslintrc.json
.gitignore Bug 32030: Add dist dir to .gitignore 2022-11-08 09:49:57 -03:00
.htaccess
.mailmap 22.11.00: Update .mailmap 2022-11-25 15:20:01 -03:00
.perlcriticrc
.proverc.dist
.stylelintrc.json
about.pl Bug 30808: Add support for version codenames 2022-11-25 15:20:00 -03:00
app.psgi
changelanguage.pl
cpanfile Bug 12758: Make LWP::Protocol::https required module 2022-11-09 09:52:13 -03:00
cypress.json Bug 32030: Move cypress to t/ 2022-11-08 09:44:51 -03:00
fix-perl-path.PL
gulpfile.js Bug 32422: Hardcoded paths in _common.scss precent using external node_modules 2022-12-15 13:23:41 +00:00
help.pl
INSTALL
Koha.pm Increment version for 22.11.01 release 2022-12-21 11:27:09 +00:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 32030: Fix Makefile.t 2022-11-09 09:48:30 -03:00
MANIFEST.SKIP
package.json Bug 32212: (bug 32030 follow-up) Restore bootstrap 4 2022-11-17 14:49:07 -03:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 32030: Move cypress to t/ 2022-11-08 09:44:51 -03:00
yarn.lock Bug 32212: Updated yarn.lock 2022-11-18 12:04:29 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo