dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
37 lines
2.3 KiB
HTML
37 lines
2.3 KiB
HTML
[% FOR m IN messages %]
|
|
[% SWITCH m.code %]
|
|
[% CASE 'success_on_insert_library' %]
|
|
<div class="alert alert-success">Library created!</div>
|
|
[% CASE 'error_on_insert_library' %]
|
|
<div class="alert alert-danger">Library already exists and cannot be modified!</div>
|
|
[% CASE 'success_on_insert_category' %]
|
|
<div class="alert alert-success">Patron category created!</div>
|
|
[% CASE 'error_on_insert_category' %]
|
|
<div class="alert alert-danger">Patron category already exists and cannot be modified!</div>
|
|
[% CASE 'success_on_insert_patron' %]
|
|
<div class="alert alert-success">Administrator account created!</div>
|
|
[% CASE 'error_on_insert_patron' %]
|
|
<div class="alert alert-danger">The patron has not been created! Cardnumber or Userid may already exist.</div>
|
|
[% CASE 'ERROR_cardnumber_already_exists' %]
|
|
<div class="alert alert-danger">Card number already in use.</div>
|
|
[% CASE 'ERROR_cardnumber_length' %]
|
|
<div class="alert alert-danger">Card number length is incorrect.</div>
|
|
[% CASE 'ERROR_password_mismatch' %]
|
|
<div class="alert alert-danger">Passwords do not match.</div>
|
|
[% CASE 'success_on_insert_itemtype' %]
|
|
<div class="alert alert-success">New item type created!</div>
|
|
[% CASE 'error_on_insert_itemtype' %]
|
|
<div class="alert alert-danger">Item type already exists!</div>
|
|
[% CASE 'success_on_insert_circ_rule' %]
|
|
<div class="alert alert-success">Circulation rule created!</div>
|
|
[% CASE 'error_on_insert_circ_rule' %]
|
|
<div class="alert alert-danger">Circulation rule not created!</div>
|
|
[% CASE 'ERROR_password_too_short' %]
|
|
<div class="alert alert-danger">The patron has not been created the entered password was too short</div>
|
|
[% CASE 'ERROR_password_too_weak' %]
|
|
<div class="alert alert-danger">The patron has not been created the entered password was too weak, must contain at least one uppercase, and lower case letter and one number</div>
|
|
[% CASE 'ERROR_password_has_whitespaces' %]
|
|
<div class="alert alert-danger">The patron has not been created the entered password contained whitespaces</div>
|
|
[% CASE %][% message | html %]
|
|
[% END %]
|
|
[% END %]
|