89e2f5bc22
This can be used to instruct staff how the item should handled when it's checked in. For example items notforloan status has been changed as "Invoiced item" while item has been on loan. When it's checked in staff sees that they should put item aside for further processing. To test: 1. Apply patch and update database if needed 2. Set items notforloan status as -1 (or create new one) 3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin 4. Check item out for patron. 5. Check item in. => Description of notforloan status should be displayed. => Confirm notforloan status hasn't changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
547 lines
21 KiB
Perl
Executable file
547 lines
21 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 49;
|
|
use DateTime::Duration;
|
|
|
|
use t::lib::Mocks;
|
|
use t::lib::TestBuilder;
|
|
|
|
use C4::Biblio qw( AddBiblio );
|
|
use C4::Circulation qw( AddIssue AddIssuingCharge AddRenewal AddReturn GetIssuingCharges GetRenewCount GetUpcomingDueIssues );
|
|
use C4::Context;
|
|
use C4::Items;
|
|
use C4::Reserves qw( AddReserve );
|
|
use Koha::Checkouts;
|
|
use Koha::Database;
|
|
use Koha::DateUtils qw( dt_from_string output_pref );
|
|
use Koha::Holds;
|
|
use Koha::Items;
|
|
use Koha::Library;
|
|
use Koha::Patrons;
|
|
use Koha::CirculationRules;
|
|
use Koha::Statistics;
|
|
|
|
BEGIN {
|
|
require_ok('C4::Circulation');
|
|
}
|
|
|
|
can_ok(
|
|
'C4::Circulation',
|
|
qw(AddIssue
|
|
AddIssuingCharge
|
|
AddRenewal
|
|
AddReturn
|
|
GetIssuingCharges
|
|
GetRenewCount
|
|
GetUpcomingDueIssues
|
|
)
|
|
);
|
|
|
|
#Start transaction
|
|
my $schema = Koha::Database->schema;
|
|
$schema->storage->txn_begin;
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my $builder = t::lib::TestBuilder->new();
|
|
|
|
$dbh->do(q|DELETE FROM issues|);
|
|
$dbh->do(q|DELETE FROM items|);
|
|
$dbh->do(q|DELETE FROM borrowers|);
|
|
$dbh->do(q|DELETE FROM categories|);
|
|
$dbh->do(q|DELETE FROM accountlines|);
|
|
$dbh->do(q|DELETE FROM circulation_rules|);
|
|
$dbh->do(q|DELETE FROM reserves|);
|
|
$dbh->do(q|DELETE FROM old_reserves|);
|
|
$dbh->do(q|DELETE FROM statistics|);
|
|
|
|
# Generate sample datas
|
|
my $itemtype = $builder->build(
|
|
{ source => 'Itemtype',
|
|
value => { notforloan => undef, rentalcharge => 0 }
|
|
}
|
|
)->{itemtype};
|
|
my $branchcode_1 = $builder->build({ source => 'Branch' })->{branchcode};
|
|
my $branchcode_2 = $builder->build({ source => 'Branch' })->{branchcode};
|
|
my $branchcode_3 = $builder->build({ source => 'Branch' })->{branchcode};
|
|
my $categorycode = $builder->build({
|
|
source => 'Category',
|
|
value => { enrolmentfee => undef }
|
|
})->{categorycode};
|
|
|
|
# A default issuingrule should always be present
|
|
Koha::CirculationRules->set_rules(
|
|
{
|
|
itemtype => '*',
|
|
categorycode => '*',
|
|
branchcode => '*',
|
|
rules => {
|
|
lengthunit => 'days',
|
|
issuelength => 0,
|
|
renewalperiod => 0,
|
|
renewalsallowed => 0
|
|
}
|
|
}
|
|
);
|
|
|
|
# Add Dates
|
|
my $dt_today = dt_from_string;
|
|
my $today = output_pref(
|
|
{ dt => $dt_today,
|
|
dateformat => 'iso',
|
|
timeformat => '24hr',
|
|
dateonly => 1
|
|
}
|
|
);
|
|
|
|
my $dt_today2 = dt_from_string;
|
|
my $dur10 = DateTime::Duration->new( days => -10 );
|
|
$dt_today2->add_duration($dur10);
|
|
my $daysago10 = output_pref(
|
|
{ dt => $dt_today2,
|
|
dateformat => 'iso',
|
|
timeformat => '24hr',
|
|
dateonly => 1
|
|
}
|
|
);
|
|
|
|
# Add biblio and item
|
|
my $record = MARC::Record->new();
|
|
$record->append_fields(
|
|
MARC::Field->new( '952', '0', '0', a => $branchcode_1 ) );
|
|
|
|
my ( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio( $record, '' );
|
|
|
|
my $barcode_1 = 'barcode_1';
|
|
my $barcode_2 = 'barcode_2';
|
|
my $item_id1 = Koha::Item->new(
|
|
{
|
|
biblionumber => $biblionumber,
|
|
barcode => $barcode_1,
|
|
itemcallnumber => 'callnumber1',
|
|
homebranch => $branchcode_1,
|
|
holdingbranch => $branchcode_1,
|
|
itype => $itemtype
|
|
},
|
|
)->store->itemnumber;
|
|
my $item_id2 = Koha::Item->new(
|
|
{
|
|
biblionumber => $biblionumber,
|
|
barcode => $barcode_2,
|
|
itemcallnumber => 'callnumber2',
|
|
homebranch => $branchcode_2,
|
|
holdingbranch => $branchcode_2,
|
|
notforloan => 1,
|
|
itype => $itemtype
|
|
},
|
|
)->store->itemnumber;
|
|
|
|
#Add borrower
|
|
my $borrower_id1 = Koha::Patron->new({
|
|
firstname => 'firstname1',
|
|
surname => 'surname1 ',
|
|
categorycode => $categorycode,
|
|
branchcode => $branchcode_1
|
|
})->store->borrowernumber;
|
|
my $patron_1 = Koha::Patrons->find( $borrower_id1 );
|
|
my $borrower_1 = $patron_1->unblessed;
|
|
my $borrower_id2 = Koha::Patron->new({
|
|
firstname => 'firstname2',
|
|
surname => 'surname2 ',
|
|
categorycode => $categorycode,
|
|
branchcode => $branchcode_2,
|
|
})->store->borrowernumber;
|
|
my $patron_2 = Koha::Patrons->find( $borrower_id2 );
|
|
my $borrower_2 = $patron_2->unblessed;
|
|
|
|
t::lib::Mocks::mock_userenv({ patron => $patron_1 });
|
|
|
|
#Begin Tests
|
|
|
|
#Test AddIssue
|
|
my $query = " SELECT count(*) FROM issues";
|
|
my $sth = $dbh->prepare($query);
|
|
$sth->execute;
|
|
my $countissue = $sth -> fetchrow_array;
|
|
is ($countissue ,0, "there is no issue");
|
|
my $issue1 = C4::Circulation::AddIssue( $borrower_1, $barcode_1, $daysago10,0, $today, '' );
|
|
is( ref $issue1, 'Koha::Checkout',
|
|
'AddIssue returns a Koha::Checkout object' );
|
|
my $datedue1 = dt_from_string( $issue1->date_due() );
|
|
like(
|
|
$datedue1,
|
|
qr/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}/,
|
|
"Koha::Checkout->date_due() returns a date"
|
|
);
|
|
my $issue_id1 = $issue1->issue_id;
|
|
|
|
my $issue2 = C4::Circulation::AddIssue( $borrower_1, 'nonexistent_barcode' );
|
|
is( $issue2, undef, "AddIssue returns undef if no datedue is specified" );
|
|
|
|
$sth->execute;
|
|
$countissue = $sth -> fetchrow_array;
|
|
is ($countissue,1,"1 issues have been added");
|
|
|
|
#Test AddIssuingCharge
|
|
$query = " SELECT count(*) FROM accountlines";
|
|
$sth = $dbh->prepare($query);
|
|
$sth->execute;
|
|
my $countaccount = $sth->fetchrow_array;
|
|
is ($countaccount,0,"0 accountline exists");
|
|
my $checkout = Koha::Checkouts->find( $issue_id1 );
|
|
my $charge = C4::Circulation::AddIssuingCharge( $checkout, 10, 'RENT' );
|
|
is( ref( $charge ), 'Koha::Account::Line', "An issuing charge has been added" );
|
|
is( $charge->issue_id, $issue_id1, 'Issue id is set correctly for issuing charge' );
|
|
my $offset = Koha::Account::Offsets->find( { debit_id => $charge->id } );
|
|
is( $offset->credit_id, undef, 'Offset was created');
|
|
$sth->execute;
|
|
$countaccount = $sth->fetchrow_array;
|
|
is ($countaccount,1,"1 accountline has been added");
|
|
|
|
# Test AddRenewal
|
|
|
|
my $se = Test::MockModule->new( 'C4::Context' );
|
|
$se->mock( 'interface', sub {return 'intranet'});
|
|
|
|
# Let's renew this one at a different library for statistical purposes to test Bug 17781
|
|
# Mocking userenv with a different branchcode
|
|
t::lib::Mocks::mock_userenv({ patron => $patron_2, branchcode => $branchcode_3 });
|
|
|
|
my $datedue3 = AddRenewal( $borrower_id1, $item_id1, $branchcode_1, $datedue1, $daysago10 );
|
|
|
|
# Restoring the userenv with the original branchcode
|
|
t::lib::Mocks::mock_userenv({ patron => $patron_1});
|
|
|
|
like(
|
|
$datedue3,
|
|
qr/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}/,
|
|
"AddRenewal returns a date"
|
|
);
|
|
|
|
my $stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef, $borrower_id1, $item_id1, $branchcode_3 );
|
|
ok( $stat, "Bug 17781 - 'Improper branchcode set during renewal' still fixed" );
|
|
|
|
subtest 'Show that AddRenewal respects OpacRenewalBranch and interface' => sub {
|
|
plan tests => 10;
|
|
|
|
my $item_library = $builder->build_object( { class => 'Koha::Libraries' } );
|
|
my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
|
|
my $logged_in_user = $builder->build_object( { class => 'Koha::Patrons' } );
|
|
t::lib::Mocks::mock_userenv( { patron => $logged_in_user } );
|
|
|
|
my $OpacRenewalBranch = {
|
|
opacrenew => "OPACRenew",
|
|
checkoutbranch => $logged_in_user->branchcode,
|
|
patronhomebranch => $patron->branchcode,
|
|
itemhomebranch => $item_library->branchcode,
|
|
none => "",
|
|
};
|
|
|
|
while ( my ( $syspref, $expected_branchcode ) = each %$OpacRenewalBranch ) {
|
|
|
|
t::lib::Mocks::mock_preference( 'OpacRenewalBranch', $syspref );
|
|
|
|
{
|
|
$se->mock( 'interface', sub { return 'opac' } );
|
|
|
|
my $item = $builder->build_sample_item(
|
|
{ library => $item_library->branchcode, itype => $itemtype } );
|
|
my $opac_renew_issue =
|
|
C4::Circulation::AddIssue( $patron->unblessed, $item->barcode );
|
|
|
|
AddRenewal( $patron->borrowernumber, $item->itemnumber,
|
|
"Stavromula", $datedue1, $daysago10 );
|
|
|
|
my $stat = Koha::Statistics->search(
|
|
{ itemnumber => $item->itemnumber, type => 'renew' } )->next;
|
|
is( $stat->branch, $expected_branchcode,
|
|
"->renewal_branchcode is respected for OpacRenewalBranch = $syspref"
|
|
);
|
|
}
|
|
|
|
{
|
|
$se->mock( 'interface', sub { return 'intranet' } );
|
|
|
|
my $item = $builder->build_sample_item(
|
|
{ library => $item_library->branchcode, itype => $itemtype } );
|
|
my $opac_renew_issue =
|
|
C4::Circulation::AddIssue( $patron->unblessed, $item->barcode );
|
|
|
|
AddRenewal( $patron->borrowernumber, $item->itemnumber,
|
|
"Stavromula", $datedue1, $daysago10 );
|
|
|
|
my $stat = Koha::Statistics->search(
|
|
{ itemnumber => $item->itemnumber, type => 'renew' } )->next;
|
|
is( $stat->branch, $logged_in_user->branchcode,
|
|
"->renewal_branchcode is always logged in branch for intranet"
|
|
);
|
|
}
|
|
}
|
|
};
|
|
|
|
|
|
my @renewcount;
|
|
#Test GetRenewCount
|
|
my $issue3 = C4::Circulation::AddIssue( $borrower_1, $barcode_1 );
|
|
#Without anything in DB
|
|
@renewcount = C4::Circulation::GetRenewCount();
|
|
is_deeply(
|
|
\@renewcount,
|
|
[ 0, 0, 0, 0, 0, 0 ], # FIXME Need to be fixed, see FIXME in GetRenewCount
|
|
"Without issuing rules and without parameter, GetRenewCount returns renewcount = 0, renewsallowed = undef, renewsleft = 0"
|
|
);
|
|
@renewcount = C4::Circulation::GetRenewCount(-1);
|
|
is_deeply(
|
|
\@renewcount,
|
|
[ 0, 0, 0, 0, 0, 0 ], # FIXME Need to be fixed
|
|
"Without issuing rules and without wrong parameter, GetRenewCount returns renewcount = 0, renewsallowed = undef, renewsleft = 0"
|
|
);
|
|
@renewcount = C4::Circulation::GetRenewCount($borrower_id1, $item_id1);
|
|
is_deeply(
|
|
\@renewcount,
|
|
[ 2, 0, 0, 0, 0, 0 ],
|
|
"Without issuing rules and with a valid parameter, renewcount = 2, renewsallowed = undef, renewsleft = 0"
|
|
);
|
|
|
|
#With something in DB
|
|
@renewcount = C4::Circulation::GetRenewCount();
|
|
is_deeply(
|
|
\@renewcount,
|
|
[ 0, 0, 0, 0, 0, 0 ],
|
|
"With issuing rules (renewal disallowed) and without parameter, GetRenewCount returns renewcount = 0, renewsallowed = 0, renewsleft = 0"
|
|
);
|
|
@renewcount = C4::Circulation::GetRenewCount(-1);
|
|
is_deeply(
|
|
\@renewcount,
|
|
[ 0, 0, 0, 0, 0, 0 ],
|
|
"With issuing rules (renewal disallowed) and without wrong parameter, GetRenewCount returns renewcount = 0, renewsallowed = 0, renewsleft = 0"
|
|
);
|
|
@renewcount = C4::Circulation::GetRenewCount($borrower_id1, $item_id1);
|
|
is_deeply(
|
|
\@renewcount,
|
|
[ 2, 0, 0, 0, 0, 0 ],
|
|
"With issuing rules (renewal disallowed) and with a valid parameter, Getrenewcount returns renewcount = 2, renewsallowed = 0, renewsleft = 0"
|
|
);
|
|
|
|
# Add a default rule: renewal is allowed
|
|
Koha::CirculationRules->set_rules(
|
|
{
|
|
categorycode => undef,
|
|
itemtype => undef,
|
|
branchcode => undef,
|
|
rules => {
|
|
renewalsallowed => 3,
|
|
}
|
|
}
|
|
);
|
|
@renewcount = C4::Circulation::GetRenewCount($borrower_id1, $item_id1);
|
|
is_deeply(
|
|
\@renewcount,
|
|
[ 2, 3, 1, 0, 0, 0 ],
|
|
"With issuing rules (renewal allowed) and with a valid parameter, Getrenewcount of item1 returns 3 renews left"
|
|
);
|
|
|
|
AddRenewal( $borrower_id1, $item_id1, $branchcode_1,
|
|
$datedue3, $daysago10 );
|
|
@renewcount = C4::Circulation::GetRenewCount($borrower_id1, $item_id1);
|
|
is_deeply(
|
|
\@renewcount,
|
|
[ 3, 3, 0, 0, 0, 0 ],
|
|
"With issuing rules (renewal allowed, 1 remaining) and with a valid parameter, Getrenewcount of item1 returns 0 renews left"
|
|
);
|
|
|
|
$dbh->do("DELETE FROM old_issues");
|
|
AddReturn($barcode_1);
|
|
my $return = $dbh->selectrow_hashref("SELECT DATE(returndate) AS return_date, CURRENT_DATE() AS today FROM old_issues LIMIT 1" );
|
|
ok( $return->{return_date} eq $return->{today}, "Item returned with no return date specified has todays date" );
|
|
|
|
$dbh->do("DELETE FROM old_issues");
|
|
C4::Circulation::AddIssue( $borrower_1, $barcode_1, $daysago10, 0, $today );
|
|
AddReturn($barcode_1, undef, undef, dt_from_string('2014-04-01 23:42'));
|
|
$return = $dbh->selectrow_hashref("SELECT * FROM old_issues LIMIT 1" );
|
|
ok( $return->{returndate} eq '2014-04-01 23:42:00', "Item returned with a return date of '2014-04-01 23:42' has that return date" );
|
|
|
|
my $itemnumber = Koha::Item->new(
|
|
{
|
|
biblionumber => $biblionumber,
|
|
barcode => 'barcode_3',
|
|
itemcallnumber => 'callnumber3',
|
|
homebranch => $branchcode_1,
|
|
holdingbranch => $branchcode_1,
|
|
notforloan => 1,
|
|
itype => $itemtype
|
|
},
|
|
)->store->itemnumber;
|
|
|
|
t::lib::Mocks::mock_preference( 'UpdateNotForLoanStatusOnCheckin', q{} );
|
|
t::lib::Mocks::mock_preference( 'CataloguingLog', 1 );
|
|
my $log_count_before = $schema->resultset('ActionLog')->search({module => 'CATALOGUING'})->count();
|
|
|
|
AddReturn( 'barcode_3', $branchcode_1 );
|
|
my $item = Koha::Items->find( $itemnumber );
|
|
ok( $item->notforloan eq 1, 'UpdateNotForLoanStatusOnCheckin does not modify value when not enabled' );
|
|
|
|
t::lib::Mocks::mock_preference( 'UpdateNotForLoanStatusOnCheckin', '1: 9' );
|
|
AddReturn( 'barcode_3', $branchcode_1 );
|
|
$item = Koha::Items->find( $itemnumber );
|
|
ok( $item->notforloan eq 9, q{UpdateNotForLoanStatusOnCheckin updates notforloan value from 1 to 9 with setting "1: 9"} );
|
|
my $log_count_after = $schema->resultset('ActionLog')->search({module => 'CATALOGUING'})->count();
|
|
is($log_count_before, $log_count_after, "Change from UpdateNotForLoanStatusOnCheckin is not logged");
|
|
|
|
AddReturn( 'barcode_3', $branchcode_1 );
|
|
$item = Koha::Items->find( $itemnumber );
|
|
ok( $item->notforloan eq 9, q{UpdateNotForLoanStatusOnCheckin does not update notforloan value from 9 with setting "1: 9"} );
|
|
|
|
t::lib::Mocks::mock_preference( 'UpdateNotForLoanStatusOnCheckin', '1: ONLYMESSAGE' );
|
|
$item->notforloan(1)->store;
|
|
AddReturn( 'barcode_3', $branchcode_1 );
|
|
$item = Koha::Items->find( $itemnumber );
|
|
ok( $item->notforloan eq 1, q{UpdateNotForLoanStatusOnCheckin does not update notforloan value from 1 with setting "1: ONLYMESSAGE"} );
|
|
|
|
my $itemnumber2 = Koha::Item->new(
|
|
{
|
|
biblionumber => $biblionumber,
|
|
barcode => 'barcode_4',
|
|
itemcallnumber => 'callnumber4',
|
|
homebranch => $branchcode_1,
|
|
holdingbranch => $branchcode_1,
|
|
location => 'FIC',
|
|
itype => $itemtype
|
|
}
|
|
)->store->itemnumber;
|
|
|
|
t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', q{} );
|
|
AddReturn( 'barcode_4', $branchcode_1 );
|
|
my $item2 = Koha::Items->find( $itemnumber2 );
|
|
ok( $item2->location eq 'FIC', 'UpdateItemLocationOnCheckin does not modify value when not enabled' );
|
|
|
|
t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', 'FIC: GEN' );
|
|
$log_count_before = $schema->resultset('ActionLog')->search({module => 'CATALOGUING'})->count();
|
|
AddReturn( 'barcode_4', $branchcode_1 );
|
|
$item2 = Koha::Items->find( $itemnumber2 );
|
|
is( $item2->location, 'GEN', q{UpdateItemLocationOnCheckin updates location value from 'FIC' to 'GEN' with setting "FIC: GEN"} );
|
|
is( $item2->permanent_location, 'GEN', q{UpdateItemLocationOnCheckin updates permanent_location value from 'FIC' to 'GEN' with setting "FIC: GEN"} );
|
|
$log_count_after = $schema->resultset('ActionLog')->search({module => 'CATALOGUING'})->count();
|
|
is($log_count_before, $log_count_after, "Change from UpdateNotForLoanStatusOnCheckin is not logged");
|
|
AddReturn( 'barcode_4', $branchcode_1 );
|
|
$item2 = Koha::Items->find( $itemnumber2 );
|
|
ok( $item2->location eq 'GEN', q{UpdateItemLocationOnCheckin does not update location value from 'GEN' with setting "FIC: GEN"} );
|
|
|
|
t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', '_ALL_: CART' );
|
|
AddReturn( 'barcode_4', $branchcode_1 );
|
|
$item2 = Koha::Items->find( $itemnumber2 );
|
|
ok( $item2->location eq 'CART', q{UpdateItemLocationOnCheckin updates location value from 'GEN' with setting "_ALL_: CART"} );
|
|
Koha::Item::Transfer->new({
|
|
itemnumber => $itemnumber2,
|
|
frombranch => $branchcode_2,
|
|
tobranch => $branchcode_1,
|
|
datesent => '2020-01-01'
|
|
})->store;
|
|
AddReturn( 'barcode_4', $branchcode_1 );
|
|
$item2 = Koha::Items->find( $itemnumber2 );
|
|
ok( $item2->location eq 'CART', q{UpdateItemLocationOnCheckin updates location value from 'GEN' with setting "_ALL_: CART" when transfer filled} );
|
|
|
|
ok( $item2->permanent_location eq 'GEN', q{UpdateItemLocationOnCheckin does not update permanent_location value from 'GEN' with setting "_ALL_: CART"} );
|
|
AddIssue( $borrower_1, 'barcode_4', $daysago10,0, $today, '' );
|
|
$item2 = Koha::Items->find( $itemnumber2 );
|
|
ok( $item2->location eq 'GEN', q{Location updates from 'CART' to permanent location on issue} );
|
|
|
|
t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', "GEN: _BLANK_\n_BLANK_: PROC\nPROC: _PERM_" );
|
|
AddReturn( 'barcode_4', $branchcode_1 );
|
|
$item2 = Koha::Items->find( $itemnumber2 );
|
|
ok( $item2->location eq '', q{UpdateItemLocationOnCheckin updates location value from 'GEN' to '' with setting "GEN: _BLANK_"} );
|
|
AddReturn( 'barcode_4', $branchcode_1 );
|
|
$item2 = Koha::Items->find( $itemnumber2 );
|
|
ok( $item2->location eq 'PROC' , q{UpdateItemLocationOnCheckin updates location value from '' to 'PROC' with setting "_BLANK_: PROC"} );
|
|
ok( $item2->permanent_location eq '' , q{UpdateItemLocationOnCheckin does not update permanent_location value from '' to 'PROC' with setting "_BLANK_: PROC"} );
|
|
AddReturn( 'barcode_4', $branchcode_1 );
|
|
$item2 = Koha::Items->find( $itemnumber2 );
|
|
ok( $item2->location eq '' , q{UpdateItemLocationOnCheckin updates location value from 'PROC' to '' with setting "PROC: _PERM_" } );
|
|
ok( $item2->permanent_location eq '' , q{UpdateItemLocationOnCheckin does not update permanent_location from '' with setting "PROC: _PERM_" } );
|
|
|
|
# Bug 28472
|
|
my $itemnumber3 = Koha::Item->new(
|
|
{
|
|
biblionumber => $biblionumber,
|
|
barcode => 'barcode_5',
|
|
itemcallnumber => 'callnumber5',
|
|
homebranch => $branchcode_1,
|
|
holdingbranch => $branchcode_1,
|
|
location => undef,
|
|
itype => $itemtype
|
|
}
|
|
)->store->itemnumber;
|
|
|
|
t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', '_ALL_: CART' );
|
|
AddReturn( 'barcode_5', $branchcode_1 );
|
|
my $item3 = Koha::Items->find( $itemnumber3 );
|
|
is( $item3->location, 'CART', q{UpdateItemLocationOnCheckin updates location value from NULL (i.e. the item has no shelving location set) to 'CART' with setting "_ALL_: CART"} );
|
|
|
|
|
|
|
|
# Bug 14640 - Cancel the hold on checking out if asked
|
|
my $reserve_id = AddReserve(
|
|
{
|
|
branchcode => $branchcode_1,
|
|
borrowernumber => $borrower_id1,
|
|
biblionumber => $biblionumber,
|
|
priority => 1,
|
|
notes => "a note",
|
|
title => "a title",
|
|
}
|
|
);
|
|
ok( $reserve_id, 'The reserve should have been inserted' );
|
|
AddIssue( $borrower_2, $barcode_1, dt_from_string, 'cancel' );
|
|
my $hold = Koha::Holds->find( $reserve_id );
|
|
is( $hold, undef, 'The reserve should have been correctly cancelled' );
|
|
|
|
# Unseen rewnewals
|
|
t::lib::Mocks::mock_preference('UnseenRenewals', 1);
|
|
# Add a default circ rule: 3 unseen renewals allowed
|
|
Koha::CirculationRules->set_rules(
|
|
{
|
|
categorycode => undef,
|
|
itemtype => undef,
|
|
branchcode => undef,
|
|
rules => {
|
|
renewalsallowed => 10,
|
|
unseen_renewals_allowed => 3
|
|
}
|
|
}
|
|
);
|
|
|
|
my $unseen_library = $builder->build_object( { class => 'Koha::Libraries' } );
|
|
my $unseen_patron = $builder->build_object( { class => 'Koha::Patrons' } );
|
|
my $unseen_item = $builder->build_sample_item(
|
|
{ library => $unseen_library->branchcode, itype => $itemtype } );
|
|
my $unseen_issue = C4::Circulation::AddIssue( $unseen_patron->unblessed, $unseen_item->barcode );
|
|
|
|
# Does an unseen renewal increment the issue's count
|
|
my ( $unseen_before ) = ( C4::Circulation::GetRenewCount( $unseen_patron->borrowernumber, $unseen_item->itemnumber ) )[3];
|
|
AddRenewal( $unseen_patron->borrowernumber, $unseen_item->itemnumber, $branchcode_1, undef, undef, undef, 0 );
|
|
my ( $unseen_after ) = ( C4::Circulation::GetRenewCount( $unseen_patron->borrowernumber, $unseen_item->itemnumber ) )[3];
|
|
is( $unseen_after, $unseen_before + 1, 'unseen_renewals increments' );
|
|
|
|
# Does a seen renewal reset the unseen count
|
|
AddRenewal( $unseen_patron->borrowernumber, $unseen_item->itemnumber, $branchcode_1, undef, undef, undef, 1 );
|
|
my ( $unseen_reset ) = ( C4::Circulation::GetRenewCount( $unseen_patron->borrowernumber, $unseen_item->itemnumber ) )[3];
|
|
is( $unseen_reset, 0, 'seen renewal resets the unseen count' );
|
|
|
|
#End transaction
|
|
$schema->storage->txn_rollback;
|