Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Kyle M Hall 2c67648093 Bug 17781 - Improper branchcode set during renewal 
For no discernable reason, when AddIssue calls AddRenewal, it passes the
branchcode generated from _GetCircControlBranch. Assume
_GetCircControlBranch is set to return items.homebranch. So:
1) If an item owned by LibraryA is checked out at LibraryB, the
  statistic line branchcode will be LibraryB
2) If an item is renewed via the ajax datatables renewal function, the
  statistic line branchcode will be LibraryB the
3) If an item is renewed via scanning the item into the checkout again,
  statistic line branchcode will be *LibraryA*

This is clearly improper behavior. The renewal is taking place at
LibraryB, so the branchcode passed to AddRenewal should be LibraryB,
the logged in library. This also jives with the documentation for
the subroutine.

Test Plan:
1) Set CircControl to "the library the item is from" aka ( ItemHomeLibrary )
2) Set HomeOrHoldingBranch to 'The library the items is from" ( aka homebranch )
3) Create item with homebranch of LibraryA and holdingbranch of LibraryB
4) Set the logged in library to LibraryB
4) Check the item out to a patron at LibraryB
5) Note the statistics line has a branchcode of LibraryB
6) Check the item out again to trigger a renewal, renew the item
7) Note the statistic line has a branchcode of LibraryA!
8) Apply this patch
9) Repeat step 6
10) Note the statistics line has a branchcode of LibraryB!

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: David Kuhn <kuhn@monterey.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-12-28 13:35:46 +00:00
..
Acquisition Bug 17578: GetMemberDetails - Remove GetMemberDetails 2016-12-16 13:12:44 +00:00
api/v1 Bug 17654: Add tests to enforce swagger definition files integrity 2016-11-18 14:04:22 +00:00
Auth
Biblio
Circulation Bug 17781 - Improper branchcode set during renewal 2016-12-28 13:35:46 +00:00
Creators
data
Exporter Bug 17644 - t/db_dependent/Exporter/Record.t fails 2016-11-17 11:05:52 +00:00
Holds Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings 2016-12-05 15:30:20 +00:00
Items Bug 17251: Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping 2016-10-21 15:23:06 +00:00
Koha Bug 14637: Followup - Fix number of tests due to rebase 2016-12-28 13:31:21 +00:00
Labels
LDAP
Letters Bug 17246: Do no support arrayref to define multiple FK 2016-12-28 13:32:10 +00:00
Members Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings 2016-12-05 15:25:44 +00:00
OAI Bug 16172: fix OAI Server tests broken by bug 15946 2016-03-31 16:51:38 +00:00
Patron Bug 17603: Remove itemtype-related Borrower_Discharge.t warnings 2016-11-12 02:38:19 +00:00
Record Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests 2016-10-21 15:13:55 +00:00
Reports Bug 12787 [QA Followup] - Retain change to Reports_Guided.t 2016-04-22 00:54:36 +00:00
Reserves Bug 17599: Make the tests pass 2016-11-15 15:54:24 +00:00
Search Bug 17323: Column search_history.time cannot be null 2016-11-18 13:51:37 +00:00
selenium Bug 13691: Add changes for 3.22 2016-07-08 20:36:57 +00:00
Serials Bug 13321: Rename variables 2016-10-28 13:45:59 +00:00
SIP Bug 15006: Centralize timeout logic and allow zero client timeout 2016-07-15 14:11:05 +00:00
Template/Plugin Bug 17796: Replace Koha::Issue[s] with Koha::Checkout[s] 2016-12-20 15:13:28 +00:00
Utils Bug 14874 - Add ability to search for patrons by date of birth from checkout and patron quick searches 2016-10-27 13:21:13 +00:00
www Bug 17540: (Bug 7216 followup) Fix tests for auth_values_input_www.t 2016-11-04 11:08:41 +00:00
XSLT_Handler Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00
00-strict.t
Accounts.t Bug 17586: Move ->get_balance to Koha::Account->balance 2016-12-16 14:50:18 +00:00
Acquisition.t Bug 17562: Fix Acquisition.t 2016-11-10 13:37:54 +00:00
AdditionalField.t
Amazon.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
ArticleRequests.t Bug 14610 - Add unit tests 2016-10-26 12:15:15 +00:00
AudioAlerts.t
Auth.t Bug 16853: Move changepassword to Koha::Patron->update_password 2016-07-15 18:09:17 +00:00
Auth_with_cas.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Auth_with_ldap.t Bug 17637: Fix tests Auth_with_ldap.t 2016-11-16 14:01:33 +00:00
AuthorisedValues.t Bug 17642: Do not explode if no authorised value exist 2016-11-18 15:52:01 +00:00
AuthoritiesMarc.t
BackgroundJob.t Bug 17426: Do not set AutoCommit in tests 2016-10-21 14:34:21 +00:00
Barcodes.t Bug 15878 - Updated unit tests for hbyymmincr barcodes 2016-05-23 17:42:10 +00:00
Barcodes_ValueBuilder.t
Biblio.t Bug 16431: Use Koha::Cache to cache marc subfield structure 2016-07-08 12:44:58 +00:00
Bookseller.t Bug 13321: Rename variables 2016-10-28 13:45:59 +00:00
Breeding.t
Budgets.t Bug 16123 - Add unit tests 2016-10-28 15:26:00 +00:00
Charset.t
check_sysprefs.t
Circulation.t Bug 17678: Typo iss in Circulation.t 2016-12-23 11:46:21 +00:00
ClassSource.t Bug 16860: Remove the comment about the warning 2016-07-08 13:29:50 +00:00
ColumnsSettings.t Bug 16177: Fix tests for ColumnsSsettings.t 2016-04-01 19:08:23 +00:00
Context.t Bug 16813: Allow empty string for OPACBaseURL 2016-07-15 15:02:13 +00:00
Contract.t
CourseReserves.t Bug 17716: (followup) Remove dep on existing data and tidy 2016-12-05 15:32:57 +00:00
db_structure.t Bug 16173: db_structure.t shouldn't have a fixed number of tests 2016-04-01 19:14:53 +00:00
DecreaseLoanHighHolds.t Bug 17633: Do not call set_preference from tests 2016-11-16 15:31:01 +00:00
default_search_class.pl Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Filter_MARC_ViewPolicy.t Bug 11592: Add should_hide_marc method to filter 2016-09-08 11:54:16 +00:00
Fines.t
FrameworkPlugin.t
Heading_MARC21.t
Hold.t Bug 14642: (QA followup) Add tests for Koha::Hold->delete 2016-08-17 18:43:13 +00:00
Holds.t Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
HoldsQueue.t Bug 17633: Do not call set_preference from tests 2016-11-16 15:31:01 +00:00
Holidays.t Bug 16376: (regression tests) 2016-12-09 15:25:01 +00:00
ILSDI_Services.t Bug 16155: (QA followup) fix small bug in t/db_dependent/ILSDI_Services.t 2016-05-04 13:47:58 +00:00
ImportBatch.t Bug 9259: Use is instead of is_deeply 2016-07-08 13:43:53 +00:00
Installer.t
Items.t Bug 17633: (QA followup) remove debugging leftover 2016-11-16 15:59:00 +00:00
Items_DelItemCheck.t Bug 14504: Changes missed while fixing patches 2016-08-26 12:07:27 +00:00
KitchenSinkPlugin.kpz Bug 17368: Update KitchenSinkPlugin.kpz 2016-10-21 14:48:53 +00:00
Koha.t Bug 14629 - Fix # of unit tests 2016-10-28 12:11:17 +00:00
Koha_Authority.t
Koha_borrower_modifications.t Bug 17494: (QA followup) Fix exception name 2016-11-04 15:45:41 +00:00
Koha_Database.t
Koha_Elasticsearch. Bug 17372: Standardize Elasticsearch paths 2016-10-11 01:07:03 +00:00
Koha_Elasticsearch_Indexer.t Bug 17372: Standardize Elasticsearch paths 2016-10-11 01:07:03 +00:00
Koha_Misc_Files.t
Koha_SearchEngine_Elasticsearch_Search.t Bug 17377: Add tests for json2marc 2016-11-18 13:53:20 +00:00
Languages.t Bug 16866: Catch warning t/db_dependent/Languages.t 2016-07-08 14:50:18 +00:00
Letters.t Bug 5260: make tests pass even without patron cat 'PT' 2016-10-28 11:52:27 +00:00
Linker_FirstMatch.t Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t 2016-08-04 20:04:24 +00:00
Log.t Bug 16829: Unit tests for logaction's 'interface parameter' 2016-08-17 18:01:50 +00:00
MarcModificationTemplates.t
Members.t Bug 17578 [QA Followup] - Update number of tests 2016-12-16 13:14:50 +00:00
MungeMarcPrice.t
NewsChannels.t Bug 15758: Koha::Libraries - Remove GetBranchName 2016-09-08 14:36:01 +00:00
Overdues.t Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
Passwordrecovery.t Bug 15585: Remove "shift on reference is experimental" warning 2016-03-22 23:08:21 +00:00
PatronLists.t Bug 17722: Make PatronLists.t run inside a transaction 2016-12-09 17:50:14 +00:00
Patrons.t Bug 17742: Use TestBuilder to create the library and patron category 2016-12-28 13:34:21 +00:00
Plugins.t Bug 16586: [QA Follow-up] Add test for two metadata conditions 2016-09-09 12:13:39 +00:00
QueryParser.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Record.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t Bug 14048: (QA followup) Default to 1 if no default rule 2016-07-07 10:37:01 -06:00
Reports.t
Reserves.t Bug 17557: Koha::Patrons - Move GetAge to ->set_age (and remove SetAge) 2016-12-16 11:57:38 +00:00
rollingloans.t Bug 17578: GetMemberDetails - Remove GetMemberDetails 2016-12-16 13:12:44 +00:00
RotatingCollections.t
Search.t Bug 17278: Fix test compilation errors 2016-11-22 17:44:51 +00:00
Serials.t Bug 12178: Fix tests not to depend on dateformat syspref 2016-07-15 14:07:41 +00:00
Serials_2.t Bug 7677: UT: Remove $dbh->rollback 2016-09-12 09:13:58 +00:00
Service.t
ShelfBrowser.t
Sitemapper.t Bug 16751: What is sitemaper? 2016-06-24 13:19:06 +00:00
Stats.t
SuggestionEngine_ExplodedTerms.t Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2016-07-08 13:08:09 +00:00
Suggestions.t Bug 17099: C4::Koha - Remove GetSupportName and GetSupportList 2016-09-09 13:30:45 +00:00
sysprefs.t
Tags.t
Templates.t
TestBuilder.t Bug 16890: Make TestBuilder generate date for date columns (and not datetime) 2016-07-15 14:59:46 +00:00
Upload.t Bug 17538: (Bug 17216 follow-up) Fix t/db_dependent/Upload.t 2016-11-04 11:04:51 +00:00
UsageStats.t Bug 15131: Add AllowItemsOnHoldCheckoutSCO to UsageStats 2016-10-21 17:27:07 +00:00
Virtualshelves.t Bug 16551: Display the name of lists to the search results at the OPAC 2016-09-25 15:43:07 +00:00
XISBN.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
XSLT_Handler.t
zebra_config.pl