Koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui
Fridolyn SOMERS 2c7e1390b4 Bug 10543 - add mandatory subfield check to addorderiso2709.pl
When adding orders from staged file, you can create one order per
record using item form in the bottom of addorderiso2709.pl.  The
form was missing checks of mandatory item fields; this patch
adds those checks.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>

All 3 patches pass tests and QA script.

Some additional notes on the test plan from the first patch:
It took me a while to figure out a combination of subfields
that would trigger the bug. I am not sure about the condition
that transforms the input field into a textbox as it does
not seem to happen for every field.

What worked in the end was (MARC21):
- $g cost, normal purchase price = mandatory
- $h serial enumeration/chronolgy = optional, filled with
  text over 100 characters

Checked for:
- Adding items in cataloguing
  Was able to reproduce the problem, mandatory check works
  as expected.
- Adding items from staged file in acq
  Was not able to trigger the problem, because we don't edit
  the item here, but mandatory check works as expected.
- Addings items for serial subscriptions
  Was not able to trigger the problem, because we don't edit
  the items here, but mandatory check works better as before
  as missing mandatory fields are now highlighted and weren't
  before.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-07-30 14:47:36 +00:00
..
csv Bug 7302: Followup: rename "Client number" column with "Account number" 2012-07-24 18:22:09 +02:00
acqui-home.tt Bug 9744 - Add a column Fund name on the home page of acquisitions 2013-06-03 07:45:15 -07:00
addorderiso2709.tt Bug 10543 - add mandatory subfield check to addorderiso2709.pl 2013-07-30 14:47:36 +00:00
ajax.tt Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
basket.tt Bug 10258: offer to create basket group only when staff user has correct permission 2013-07-15 16:15:01 +00:00
basketgroup.tt Bug 7598: make strings in acquisitions JavaScript translatable 2013-07-19 12:49:12 +00:00
basketheader.tt Bug 2835 - Inconsistent use of colon at the end of sentences 2013-04-02 09:03:42 -04:00
booksellers.tt Bug 10381: Followup adding some text around Apply/cancel filter. 2013-05-30 08:40:29 -07:00
histsearch.tt Bug 10313 Fix link to invoice from orders 2013-05-23 07:54:52 -07:00
invoice.tt Bug 10390: Add ability to delete empty invoices 2013-07-05 16:51:18 +00:00
invoices.tt Bug 10390: Add ability to delete empty invoices 2013-07-05 16:51:18 +00:00
lateorders.tt Bug 9108 - Add uk/euro date sort filter to pages which require it 2013-01-17 21:59:30 -05:00
modordernotes.tt Bug 7166: Adds edit order notes when the basket is closed 2012-03-20 16:45:37 +01:00
neworderbiblio.tt But 9791: Remove single pixel on datatable tables 2013-04-01 18:20:22 -04:00
neworderempty.tt Bug 10543 - Unify item mandatory subfields check 2013-07-30 14:47:10 +00:00
neworderempty_duplicate.tt Bug 7760: Add unique ids and a module class to all acquisitions pages 2012-03-22 18:11:54 +01:00
newordersubscription.tt Bug 5343: Fix non english string 2013-03-22 23:54:46 -04:00
newordersuggestion.tt Bug 5345: DataTables integration in acquisition module [9] 2012-05-14 15:41:44 +02:00
ordered.tt Bug 9108 - Add uk/euro date sort filter to pages which require it 2013-01-17 21:59:30 -05:00
orderreceive.tt Bug 10543 - Unify item mandatory subfields check 2013-07-30 14:47:10 +00:00
parcel.tt Bug 10317: improve display when order receiving page is given an invalid invoiceid 2013-07-05 16:32:43 +00:00
parcels.tt Bug 10366: Alert librarian if an invoice number is duplicated 2013-07-06 17:13:45 +00:00
spent.tt Bug 9108 - Add uk/euro date sort filter to pages which require it 2013-01-17 21:59:30 -05:00
supplier.tt Bug 2835 - Inconsistent use of colon at the end of sentences 2013-04-02 09:03:42 -04:00
uncertainprice.tt Bug 7598: make strings in acquisitions JavaScript translatable 2013-07-19 12:49:12 +00:00
z3950_search.tt Bug 2835 - Inconsistent use of colon at the end of sentences 2013-04-02 09:03:42 -04:00