Jonathan Druart
2d74d926ce
This subroutine just retrieved the messages given some parameters.
Some job should not have been done in this subroutine.
It was called only 3 times, in circ/circulation.pl and opac-user.pl.
Basically it was used to retrieved the message to displaye for a given
patron ($borrowernumber) at the OPAC (B) or Staff (L).
For the 3 calls, the 2 parameters $borrowernumber and $type
(message_type) were passed, the "%" trick at the beginning of the
subroutine was useless.
Moreover, the date formatting should be done on the TT side, not in
subroutine.
The can_delete flag was set if the branchcode given in parameter was the
same as the one of the message. This has been delegated to the template.
Indeed the can_delete was not valid, since it must depend on the
AllowAllMessageDeletion pref.
The test is now:
IF message.branchcode == branch OR
Koha.Preference('AllowAllMessageDeletion'')
There is not specific test plan for this patch, the changes have already
been tested in previous patches.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
|
||
|---|---|---|
| .. | ||
| acqui | ||
| admin | ||
| authorities | ||
| basket | ||
| batch | ||
| catalogue | ||
| cataloguing | ||
| circ | ||
| common | ||
| course_reserves | ||
| errors | ||
| help | ||
| installer | ||
| labels | ||
| members | ||
| offline_circ | ||
| patron_lists | ||
| patroncards | ||
| plugins | ||
| reports | ||
| reserve | ||
| reviews | ||
| rotating_collections | ||
| serials | ||
| services | ||
| sms | ||
| suggestion | ||
| tags | ||
| test | ||
| tools | ||
| virtualshelves | ||
| about.tt | ||
| auth.tt | ||
| intranet-main.tt | ||