252f4674a5
So far the administration module only allowed for 2 permissions:
- circulation conditions (manage_circ_rules)
- everything else (parameters_remaining_permissions)
With this patch almost every section of the administration page
will have its own granular permission.
To test:
- Create different staff users:
1) One with parameters_remaining_permissions
2) One with parameters
3) One with catalogue and no parameters
4) One superlibrarian
- Apply the patch
- Run the database update
- Check the staff users:
1) All subpermissions, but manage_circ_rules
should be checked
2) Nothing should have changed
3) manage_item_serach_fields shoudl be checked
(page had catalogue permission before)
4) Nothing should have changed
- Try different settings of the permissions and
verify that
- Administration page behaves correctly
- Administration menu behaves correctly
! You shoudl only see what you have permission for
https://bugs.koha-community.org/show_bug.cgi?id=14391
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
117 lines
3.4 KiB
Perl
Executable file
117 lines
3.4 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
# Copyright 2017 Rijksmuseum
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
use CGI qw ( -utf8 );
|
|
|
|
use Koha::Database;
|
|
use C4::Auth;
|
|
use C4::Biblio;
|
|
use C4::Output;
|
|
use Koha::BiblioFrameworks;
|
|
use Koha::Caches;
|
|
use Koha::MarcSubfieldStructures;
|
|
|
|
my $input = new CGI;
|
|
|
|
my ( $template, $borrowernumber, $cookie ) = get_template_and_user (
|
|
{
|
|
template_name => "admin/koha2marclinks.tt",
|
|
query => $input,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { parameters => 'manage_marc_frameworks' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $schema = Koha::Database->new->schema;
|
|
my $cache = Koha::Caches->get_instance();
|
|
|
|
# Update data before showing the form
|
|
my $no_upd;
|
|
|
|
if( $input->param('add_field') && $input->request_method eq 'POST' ) {
|
|
# add a mapping to all frameworks
|
|
my ($kohafield, $tag, $sub) = split /,/, $input->param('add_field'), 3;
|
|
my $rs = Koha::MarcSubfieldStructures->search({ tagfield => $tag, tagsubfield => $sub });
|
|
if( $rs->count ) {
|
|
$rs->update({ kohafield => $kohafield });
|
|
} else {
|
|
$template->param( error_add => 1, error_info => "$tag, $sub" );
|
|
}
|
|
|
|
} elsif( $input->param('remove_field') && $input->request_method eq 'POST' ) {
|
|
# remove a mapping from all frameworks
|
|
my ($tag, $sub) = split /,/, $input->param('remove_field'), 2;
|
|
Koha::MarcSubfieldStructures->search({ tagfield => $tag, tagsubfield => $sub })->update({ kohafield => undef });
|
|
|
|
} else {
|
|
$no_upd = 1;
|
|
}
|
|
|
|
# Clear the cache when needed
|
|
unless( $no_upd ) {
|
|
for( qw| default_value_for_mod_marc- MarcSubfieldStructure- | ) {
|
|
$cache->clear_from_cache($_);
|
|
}
|
|
}
|
|
|
|
# Build/Show the form
|
|
my $dbix_map = {
|
|
# Koha to MARC mappings are found in only three tables
|
|
biblio => 'Biblio',
|
|
biblioitems => 'Biblioitem',
|
|
items => 'Item',
|
|
};
|
|
my @cols;
|
|
foreach my $tbl ( sort keys %{$dbix_map} ) {
|
|
push @cols,
|
|
map { "$tbl.$_" } $schema->source( $dbix_map->{$tbl} )->columns;
|
|
}
|
|
my $kohafields = Koha::MarcSubfieldStructures->search({
|
|
frameworkcode => q{},
|
|
kohafield => { '>', '' },
|
|
});
|
|
my @loop_data;
|
|
foreach my $col ( @cols ) {
|
|
my $found;
|
|
my $readonly = $col =~ /\.(biblio|biblioitem|item)number$/;
|
|
foreach my $row ( $kohafields->search({ kohafield => $col }) ) {
|
|
$found = 1;
|
|
push @loop_data, {
|
|
kohafield => $col,
|
|
tagfield => $row->tagfield,
|
|
tagsubfield => $row->tagsubfield,
|
|
liblibrarian => $row->liblibrarian,
|
|
readonly => $readonly,
|
|
};
|
|
}
|
|
push @loop_data, {
|
|
kohafield => $col,
|
|
readonly => $readonly,
|
|
} if !$found;
|
|
}
|
|
|
|
$template->param(
|
|
loop => \@loop_data,
|
|
);
|
|
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|